Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132818/?format=api
{ "id": 132818, "url": "http://patchwork.dpdk.org/api/patches/132818/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1697574677-16578-15-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1697574677-16578-15-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1697574677-16578-15-git-send-email-roretzla@linux.microsoft.com", "date": "2023-10-17T20:31:12", "name": "[v2,14/19] cryptodev: use rte optional stdatomic API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f42885e2d3fa6ddc4f42dfe0a927d095f4bb0ce", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1697574677-16578-15-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29892, "url": "http://patchwork.dpdk.org/api/series/29892/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29892", "date": "2023-10-17T20:30:58", "name": "use rte optional stdatomic API", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29892/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132818/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/132818/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3A8543190;\n\tTue, 17 Oct 2023 22:33:10 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 715F142E62;\n\tTue, 17 Oct 2023 22:31:41 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 84F6342830\n for <dev@dpdk.org>; Tue, 17 Oct 2023 22:31:20 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 454BD20B74CE; Tue, 17 Oct 2023 13:31:18 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 454BD20B74CE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1697574679;\n bh=BuZWB/6ytaxp2GG/syeRa9gqLvYyih2p/nLNala2NsU=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=IsJd/dLPgdwbfLsjRS2zbk8s/ONsub1uTDROr0zSGHD9L29hzq0RFqOvmDlyg+PiL\n NjS5C7XiTqtlecZxhaCGLMf+rrK0S8LKYR3h5xLmIzdQPaAxBzuY2VVZni89FdMld1\n VY252hS8GArFArTeR6Epr8mvVGv+JuOO0aXZ0ybE=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Ciara Power <ciara.power@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Elena Agostini <eagostini@nvidia.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 14/19] cryptodev: use rte optional stdatomic API", "Date": "Tue, 17 Oct 2023 13:31:12 -0700", "Message-Id": "<1697574677-16578-15-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1697574677-16578-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1697497745-20664-1-git-send-email-roretzla@linux.microsoft.com>\n <1697574677-16578-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional stdatomic API\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/cryptodev/rte_cryptodev.c | 22 ++++++++++++----------\n lib/cryptodev/rte_cryptodev.h | 16 ++++++++--------\n 2 files changed, 20 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex 314710b..b258827 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -1535,12 +1535,12 @@ struct rte_cryptodev_cb *\n \t\t/* Stores to cb->fn and cb->param should complete before\n \t\t * cb is visible to data plane.\n \t\t */\n-\t\t__atomic_store_n(&tail->next, cb, __ATOMIC_RELEASE);\n+\t\trte_atomic_store_explicit(&tail->next, cb, rte_memory_order_release);\n \t} else {\n \t\t/* Stores to cb->fn and cb->param should complete before\n \t\t * cb is visible to data plane.\n \t\t */\n-\t\t__atomic_store_n(&list->next, cb, __ATOMIC_RELEASE);\n+\t\trte_atomic_store_explicit(&list->next, cb, rte_memory_order_release);\n \t}\n \n \trte_spinlock_unlock(&rte_cryptodev_callback_lock);\n@@ -1555,7 +1555,8 @@ struct rte_cryptodev_cb *\n \t\t\t\t struct rte_cryptodev_cb *cb)\n {\n \tstruct rte_cryptodev *dev;\n-\tstruct rte_cryptodev_cb **prev_cb, *curr_cb;\n+\tRTE_ATOMIC(struct rte_cryptodev_cb *) *prev_cb;\n+\tstruct rte_cryptodev_cb *curr_cb;\n \tstruct rte_cryptodev_cb_rcu *list;\n \tint ret;\n \n@@ -1601,8 +1602,8 @@ struct rte_cryptodev_cb *\n \t\tcurr_cb = *prev_cb;\n \t\tif (curr_cb == cb) {\n \t\t\t/* Remove the user cb from the callback list. */\n-\t\t\t__atomic_store_n(prev_cb, curr_cb->next,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\trte_atomic_store_explicit(prev_cb, curr_cb->next,\n+\t\t\t\trte_memory_order_relaxed);\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -1673,12 +1674,12 @@ struct rte_cryptodev_cb *\n \t\t/* Stores to cb->fn and cb->param should complete before\n \t\t * cb is visible to data plane.\n \t\t */\n-\t\t__atomic_store_n(&tail->next, cb, __ATOMIC_RELEASE);\n+\t\trte_atomic_store_explicit(&tail->next, cb, rte_memory_order_release);\n \t} else {\n \t\t/* Stores to cb->fn and cb->param should complete before\n \t\t * cb is visible to data plane.\n \t\t */\n-\t\t__atomic_store_n(&list->next, cb, __ATOMIC_RELEASE);\n+\t\trte_atomic_store_explicit(&list->next, cb, rte_memory_order_release);\n \t}\n \n \trte_spinlock_unlock(&rte_cryptodev_callback_lock);\n@@ -1694,7 +1695,8 @@ struct rte_cryptodev_cb *\n \t\t\t\t struct rte_cryptodev_cb *cb)\n {\n \tstruct rte_cryptodev *dev;\n-\tstruct rte_cryptodev_cb **prev_cb, *curr_cb;\n+\tRTE_ATOMIC(struct rte_cryptodev_cb *) *prev_cb;\n+\tstruct rte_cryptodev_cb *curr_cb;\n \tstruct rte_cryptodev_cb_rcu *list;\n \tint ret;\n \n@@ -1740,8 +1742,8 @@ struct rte_cryptodev_cb *\n \t\tcurr_cb = *prev_cb;\n \t\tif (curr_cb == cb) {\n \t\t\t/* Remove the user cb from the callback list. */\n-\t\t\t__atomic_store_n(prev_cb, curr_cb->next,\n-\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\trte_atomic_store_explicit(prev_cb, curr_cb->next,\n+\t\t\t\trte_memory_order_relaxed);\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\ndiff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h\nindex be0698c..9092118 100644\n--- a/lib/cryptodev/rte_cryptodev.h\n+++ b/lib/cryptodev/rte_cryptodev.h\n@@ -979,7 +979,7 @@ struct rte_cryptodev_config {\n * queue pair on enqueue/dequeue.\n */\n struct rte_cryptodev_cb {\n-\tstruct rte_cryptodev_cb *next;\n+\tRTE_ATOMIC(struct rte_cryptodev_cb *) next;\n \t/**< Pointer to next callback */\n \trte_cryptodev_callback_fn fn;\n \t/**< Pointer to callback function */\n@@ -992,7 +992,7 @@ struct rte_cryptodev_cb {\n * Structure used to hold information about the RCU for a queue pair.\n */\n struct rte_cryptodev_cb_rcu {\n-\tstruct rte_cryptodev_cb *next;\n+\tRTE_ATOMIC(struct rte_cryptodev_cb *) next;\n \t/**< Pointer to next callback */\n \tstruct rte_rcu_qsbr *qsbr;\n \t/**< RCU QSBR variable per queue pair */\n@@ -1947,15 +1947,15 @@ int rte_cryptodev_remove_deq_callback(uint8_t dev_id,\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n \n-\t\t/* __ATOMIC_RELEASE memory order was used when the\n+\t\t/* rte_memory_order_release memory order was used when the\n \t\t * call back was inserted into the list.\n \t\t * Since there is a clear dependency between loading\n-\t\t * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order is\n+\t\t * cb and cb->fn/cb->next, rte_memory_order_acquire memory order is\n \t\t * not required.\n \t\t */\n \t\tlist = &fp_ops->qp.deq_cb[qp_id];\n \t\trte_rcu_qsbr_thread_online(list->qsbr, 0);\n-\t\tcb = __atomic_load_n(&list->next, __ATOMIC_RELAXED);\n+\t\tcb = rte_atomic_load_explicit(&list->next, rte_memory_order_relaxed);\n \n \t\twhile (cb != NULL) {\n \t\t\tnb_ops = cb->fn(dev_id, qp_id, ops, nb_ops,\n@@ -2014,15 +2014,15 @@ int rte_cryptodev_remove_deq_callback(uint8_t dev_id,\n \t\tstruct rte_cryptodev_cb_rcu *list;\n \t\tstruct rte_cryptodev_cb *cb;\n \n-\t\t/* __ATOMIC_RELEASE memory order was used when the\n+\t\t/* rte_memory_order_release memory order was used when the\n \t\t * call back was inserted into the list.\n \t\t * Since there is a clear dependency between loading\n-\t\t * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order is\n+\t\t * cb and cb->fn/cb->next, rte_memory_order_acquire memory order is\n \t\t * not required.\n \t\t */\n \t\tlist = &fp_ops->qp.enq_cb[qp_id];\n \t\trte_rcu_qsbr_thread_online(list->qsbr, 0);\n-\t\tcb = __atomic_load_n(&list->next, __ATOMIC_RELAXED);\n+\t\tcb = rte_atomic_load_explicit(&list->next, rte_memory_order_relaxed);\n \n \t\twhile (cb != NULL) {\n \t\t\tnb_ops = cb->fn(dev_id, qp_id, ops, nb_ops,\n", "prefixes": [ "v2", "14/19" ] }