Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132824/?format=api
{ "id": 132824, "url": "http://patchwork.dpdk.org/api/patches/132824/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231018013938.3830742-3-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231018013938.3830742-3-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231018013938.3830742-3-haijie1@huawei.com", "date": "2023-10-18T01:39:35", "name": "[2/4] ethdev: add telemetry command for TM capabilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd43670bf1f3517e53fd0b5290c7295b7e57942a", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231018013938.3830742-3-haijie1@huawei.com/mbox/", "series": [ { "id": 29893, "url": "http://patchwork.dpdk.org/api/series/29893/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29893", "date": "2023-10-18T01:39:34", "name": "add telemetry commands for TM capabilities", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29893/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132824/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132824/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE21D43192;\n\tWed, 18 Oct 2023 03:43:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 766FF406B4;\n\tWed, 18 Oct 2023 03:43:29 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id A29DB40151\n for <dev@dpdk.org>; Wed, 18 Oct 2023 03:43:25 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S9D5W5P0wzvQ90;\n Wed, 18 Oct 2023 09:38:39 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 18 Oct 2023 09:43:23 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH 2/4] ethdev: add telemetry command for TM capabilities", "Date": "Wed, 18 Oct 2023 09:39:35 +0800", "Message-ID": "<20231018013938.3830742-3-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231018013938.3830742-1-haijie1@huawei.com>", "References": "<20231018013938.3830742-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds a telemetry command for traffic management\ncapabilities. An example usage is shown below:\n\n--> /ethdev/tm_capability,0\n{\n \"/ethdev/tm_capability\": {\n \"n_nodes_max\": 265,\n \"n_levels_max\": 3,\n \"non_leaf_nodes_identical\": 1,\n \"leaf_nodes_identical\": 1,\n \"shaper_n_max\": 9,\n \"shaper_private_n_max\": 9,\n \"shaper_private_dual_rate_n_max\": 0,\n \"shaper_private_rate_min\": 0,\n \"shaper_private_rate_max\": 25000000000,\n \"shaper_private_packet_mode_supported\": 0,\n \"shaper_private_byte_mode_supported\": 0,\n \"shaper_shared_n_max\": 0,\n \"shaper_shared_n_nodes_per_shaper_max\": 0,\n \"shaper_shared_n_shapers_per_node_max\": 0,\n \"shaper_share_dual_rate_n_max\": 0,\n \"shaper_shared_rate_min\": 0,\n \"shaper_shared_rate_max\": 0,\n \"shaper_shared_packet_mode_supported\": 0,\n \"shaper_shared_byte_mode_supported\": 0,\n \"shaper_pkt_length_adjust_min\": 20,\n \"shaper_pkt_length_adjust_max\": 24,\n \"sched_n_children_max\": 256,\n \"sched_sp_n_priorities_max\": 1,\n \"sched_wfq_n_children_per_group_max\": 0,\n \"sched_wfq_n_groups_max\": 0,\n \"sched_wfq_weight_max\": 1,\n \"sched_wfq_packet_mode_supported\": 0,\n \"sched_wfq_byte_mode_supported\": 0,\n \"cman_wred_packet_mode_supported\": 0,\n \"cman_wred_byte_mode_supported\": 0,\n \"cman_head_drop_supported\": 0,\n \"cman_wred_context_n_max\": 0,\n \"cman_wred_context_private_n_max\": 0,\n \"cman_wred_context_shared_n_max\": 0,\n \"cman_wred_context_shared_n_nodes_per_context_max\": 0,\n \"cman_wred_context_shared_n_contexts_per_node_max\": 0,\n \"dynamic_update\": \"0x0\",\n \"stats_mask\": \"0x0\"\n }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev_telemetry.c | 108 ++++++++++++++++++++++++++++++\n 1 file changed, 108 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c\nindex f246a03e2966..02d23486806e 100644\n--- a/lib/ethdev/rte_ethdev_telemetry.c\n+++ b/lib/ethdev/rte_ethdev_telemetry.c\n@@ -11,6 +11,7 @@\n #include \"rte_ethdev.h\"\n #include \"ethdev_driver.h\"\n #include \"sff_telemetry.h\"\n+#include \"rte_tm.h\"\n \n static const struct {\n \tuint32_t capa;\n@@ -1021,6 +1022,111 @@ eth_dev_handle_port_vlan(const char *cmd __rte_unused,\n \treturn eth_dev_add_vlan_id(port_id, d);\n }\n \n+static void\n+eth_dev_add_tm_caps(struct rte_tel_data *d, struct rte_tm_capabilities *cap)\n+{\n+\trte_tel_data_add_dict_uint(d, \"n_nodes_max\", cap->n_nodes_max);\n+\trte_tel_data_add_dict_uint(d, \"n_levels_max\", cap->n_levels_max);\n+\trte_tel_data_add_dict_int(d, \"non_leaf_nodes_identical\",\n+\t\tcap->non_leaf_nodes_identical);\n+\trte_tel_data_add_dict_int(d, \"leaf_nodes_identical\",\n+\t\tcap->leaf_nodes_identical);\n+\trte_tel_data_add_dict_uint(d, \"shaper_n_max\", cap->shaper_n_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_private_n_max\",\n+\t\tcap->shaper_private_n_max);\n+\trte_tel_data_add_dict_int(d, \"shaper_private_dual_rate_n_max\",\n+\t\tcap->shaper_private_dual_rate_n_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_private_rate_min\",\n+\t\tcap->shaper_private_rate_min);\n+\trte_tel_data_add_dict_uint(d, \"shaper_private_rate_max\",\n+\t\tcap->shaper_private_rate_max);\n+\trte_tel_data_add_dict_int(d, \"shaper_private_packet_mode_supported\",\n+\t\tcap->shaper_private_packet_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"shaper_private_byte_mode_supported\",\n+\t\tcap->shaper_private_byte_mode_supported);\n+\trte_tel_data_add_dict_uint(d, \"shaper_shared_n_max\",\n+\t\tcap->shaper_shared_n_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_shared_n_nodes_per_shaper_max\",\n+\t\tcap->shaper_shared_n_nodes_per_shaper_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_shared_n_shapers_per_node_max\",\n+\t\tcap->shaper_shared_n_shapers_per_node_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_share_dual_rate_n_max\",\n+\t\tcap->shaper_shared_dual_rate_n_max);\n+\trte_tel_data_add_dict_uint(d, \"shaper_shared_rate_min\",\n+\t\tcap->shaper_shared_rate_min);\n+\trte_tel_data_add_dict_uint(d, \"shaper_shared_rate_max\",\n+\t\tcap->shaper_shared_rate_max);\n+\trte_tel_data_add_dict_int(d, \"shaper_shared_packet_mode_supported\",\n+\t\tcap->shaper_shared_packet_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"shaper_shared_byte_mode_supported\",\n+\t\tcap->shaper_shared_byte_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"shaper_pkt_length_adjust_min\",\n+\t\tcap->shaper_pkt_length_adjust_min);\n+\trte_tel_data_add_dict_int(d, \"shaper_pkt_length_adjust_max\",\n+\t\tcap->shaper_pkt_length_adjust_max);\n+\trte_tel_data_add_dict_uint(d, \"sched_n_children_max\",\n+\t\tcap->sched_n_children_max);\n+\trte_tel_data_add_dict_uint(d, \"sched_sp_n_priorities_max\",\n+\t\tcap->sched_sp_n_priorities_max);\n+\trte_tel_data_add_dict_uint(d, \"sched_wfq_n_children_per_group_max\",\n+\t\tcap->sched_wfq_n_children_per_group_max);\n+\trte_tel_data_add_dict_uint(d, \"sched_wfq_n_groups_max\",\n+\t\tcap->sched_wfq_n_groups_max);\n+\trte_tel_data_add_dict_uint(d, \"sched_wfq_weight_max\",\n+\t\tcap->sched_wfq_weight_max);\n+\trte_tel_data_add_dict_int(d, \"sched_wfq_packet_mode_supported\",\n+\t\tcap->sched_wfq_packet_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"sched_wfq_byte_mode_supported\",\n+\t\tcap->sched_wfq_byte_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"cman_wred_packet_mode_supported\",\n+\t\tcap->cman_wred_packet_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"cman_wred_byte_mode_supported\",\n+\t\tcap->cman_wred_byte_mode_supported);\n+\trte_tel_data_add_dict_int(d, \"cman_head_drop_supported\",\n+\t\tcap->cman_head_drop_supported);\n+\trte_tel_data_add_dict_uint(d, \"cman_wred_context_n_max\",\n+\t\tcap->cman_wred_context_n_max);\n+\trte_tel_data_add_dict_uint(d, \"cman_wred_context_private_n_max\",\n+\t\tcap->cman_wred_context_private_n_max);\n+\trte_tel_data_add_dict_uint(d, \"cman_wred_context_shared_n_max\",\n+\t\tcap->cman_wred_context_shared_n_max);\n+\trte_tel_data_add_dict_uint(d, \"cman_wred_context_shared_n_nodes_per_context_max\",\n+\t\tcap->cman_wred_context_shared_n_nodes_per_context_max);\n+\trte_tel_data_add_dict_uint(d, \"cman_wred_context_shared_n_contexts_per_node_max\",\n+\t\tcap->cman_wred_context_shared_n_contexts_per_node_max);\n+\trte_tel_data_add_dict_uint_hex(d, \"dynamic_update\", cap->dynamic_update_mask, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"stats_mask\", cap->stats_mask, 0);\n+}\n+\n+static int\n+eth_dev_handle_port_tm_caps(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_tm_capabilities cap = {0};\n+\tstruct rte_tm_error error = {0};\n+\tuint16_t port_id;\n+\tchar *end_param;\n+\tint ret;\n+\n+\tret = eth_dev_parse_port_params(params, &port_id, &end_param, false);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\tret = rte_tm_capabilities_get(port_id, &cap, &error);\n+\tif (ret != 0) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"error: %s, error type: %u\\n\",\n+\t\t\terror.message ? error.message : \"no stated reason\",\n+\t\t\terror.type);\n+\t\treturn ret;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\teth_dev_add_tm_caps(d, &cap);\n+\n+\treturn 0;\n+}\n+\n RTE_INIT(ethdev_init_telemetry)\n {\n \trte_telemetry_register_cmd(\"/ethdev/list\", eth_dev_handle_port_list,\n@@ -1056,4 +1162,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns FEC info for a port. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/vlan\", eth_dev_handle_port_vlan,\n \t\t\t\"Returns VLAN info for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/tm_capability\", eth_dev_handle_port_tm_caps,\n+\t\t\t\"Returns TM Capabilities info for a port. Parameters: int port_id\");\n }\n", "prefixes": [ "2/4" ] }