Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132826,
    "url": "http://patchwork.dpdk.org/api/patches/132826/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231018013938.3830742-5-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231018013938.3830742-5-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231018013938.3830742-5-haijie1@huawei.com",
    "date": "2023-10-18T01:39:37",
    "name": "[4/4] ethdev: add telemetry command for TM node capabilities",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5dbdc3df293e949e978a4bd0290dc1aeddf2c5fa",
    "submitter": {
        "id": 2935,
        "url": "http://patchwork.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231018013938.3830742-5-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 29893,
            "url": "http://patchwork.dpdk.org/api/series/29893/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29893",
            "date": "2023-10-18T01:39:34",
            "name": "add telemetry commands for TM capabilities",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/29893/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/132826/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/132826/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 974DC43192;\n\tWed, 18 Oct 2023 03:43:55 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B681340DCE;\n\tWed, 18 Oct 2023 03:43:31 +0200 (CEST)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 7997E40151\n for <dev@dpdk.org>; Wed, 18 Oct 2023 03:43:26 +0200 (CEST)",
            "from kwepemi500020.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S9D7t0WR0zrTSj;\n Wed, 18 Oct 2023 09:40:42 +0800 (CST)",
            "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 18 Oct 2023 09:43:24 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>",
        "Subject": "[PATCH 4/4] ethdev: add telemetry command for TM node capabilities",
        "Date": "Wed, 18 Oct 2023 09:39:37 +0800",
        "Message-ID": "<20231018013938.3830742-5-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.30.0",
        "In-Reply-To": "<20231018013938.3830742-1-haijie1@huawei.com>",
        "References": "<20231018013938.3830742-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.67.165.2]",
        "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "This patch adds a telemetry command for traffic management node\ncapabilities, using (port_id, node_id) as parameters. An example\nusage is shown below:\n\n--> /ethdev/tm_node_capability,0,264\n{\n  \"/ethdev/tm_node_capability\": {\n    \"shaper_private_supported\": 1,\n    \"shaper_private_dual_rate_supported\": 0,\n    \"shaper_private_rate_min\": 0,\n    \"shaper_private_rate_max\": 25000000000,\n    \"shaper_private_packet_mode_supported\": 0,\n    \"shaper_private_byte_mode_supported\": 0,\n    \"shaper_shared_n_max\": 0,\n    \"shaper_shared_packet_mode_supported\": 0,\n    \"shaper_shared_byte_mode_supported\": 0,\n    \"stats_mask\": \"0x0\",\n    \"node_type\": \"nonleaf\",\n    \"children_max\": 8,\n    \"priorities_max\": 1,\n    \"sched_wfq_n_children_per_group_max\": 0,\n    \"sched_wfq_n_groups_max\": 0,\n    \"sched_wfq_weight_max\": 1,\n    \"sched_wfq_packet_mode_supported\": 0,\n    \"sched_wfq_byte_mode_supported\": 0\n  }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev_telemetry.c | 104 ++++++++++++++++++++++++++++++\n 1 file changed, 104 insertions(+)",
    "diff": "diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c\nindex 4a56685be426..b01028ce9b60 100644\n--- a/lib/ethdev/rte_ethdev_telemetry.c\n+++ b/lib/ethdev/rte_ethdev_telemetry.c\n@@ -1293,6 +1293,108 @@ eth_dev_handle_port_tm_level_caps(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static void\n+eth_dev_add_tm_node_basic_caps(struct rte_tel_data *node_data,\n+\t\tstruct rte_tm_node_capabilities *capnode)\n+{\n+\trte_tel_data_add_dict_int(node_data, \"shaper_private_supported\",\n+\t\tcapnode->shaper_private_supported);\n+\trte_tel_data_add_dict_int(node_data, \"shaper_private_dual_rate_supported\",\n+\t\tcapnode->shaper_private_dual_rate_supported);\n+\trte_tel_data_add_dict_uint(node_data, \"shaper_private_rate_min\",\n+\t\tcapnode->shaper_private_rate_min);\n+\trte_tel_data_add_dict_uint(node_data, \"shaper_private_rate_max\",\n+\t\tcapnode->shaper_private_rate_max);\n+\trte_tel_data_add_dict_int(node_data, \"shaper_private_packet_mode_supported\",\n+\t\tcapnode->shaper_private_packet_mode_supported);\n+\trte_tel_data_add_dict_int(node_data, \"shaper_private_byte_mode_supported\",\n+\t\tcapnode->shaper_private_byte_mode_supported);\n+\trte_tel_data_add_dict_uint(node_data, \"shaper_shared_n_max\",\n+\t\tcapnode->shaper_shared_n_max);\n+\trte_tel_data_add_dict_int(node_data, \"shaper_shared_packet_mode_supported\",\n+\t\tcapnode->shaper_shared_packet_mode_supported);\n+\trte_tel_data_add_dict_int(node_data, \"shaper_shared_byte_mode_supported\",\n+\t\tcapnode->shaper_shared_byte_mode_supported);\n+\trte_tel_data_add_dict_uint_hex(node_data, \"stats_mask\",\n+\t\tcapnode->stats_mask, 0);\n+}\n+\n+static void\n+eth_dev_add_tm_type_node_caps(struct rte_tel_data *d, int is_leaf,\n+\t\tstruct rte_tm_node_capabilities *cap)\n+{\n+\trte_tel_data_add_dict_string(d, \"node_type\",\n+\t\t\t\tis_leaf == 0 ? \"nonleaf\" : \"leaf\");\n+\tif (is_leaf == 0) {\n+\t\trte_tel_data_add_dict_uint(d, \"children_max\",\n+\t\t\tcap->nonleaf.sched_n_children_max);\n+\t\trte_tel_data_add_dict_uint(d, \"priorities_max\",\n+\t\t\tcap->nonleaf.sched_sp_n_priorities_max);\n+\t\trte_tel_data_add_dict_uint(d, \"sched_wfq_n_children_per_group_max\",\n+\t\t\tcap->nonleaf.sched_wfq_n_children_per_group_max);\n+\t\trte_tel_data_add_dict_uint(d, \"sched_wfq_n_groups_max\",\n+\t\t\tcap->nonleaf.sched_wfq_n_groups_max);\n+\t\trte_tel_data_add_dict_uint(d, \"sched_wfq_weight_max\",\n+\t\t\tcap->nonleaf.sched_wfq_weight_max);\n+\t\trte_tel_data_add_dict_int(d, \"sched_wfq_packet_mode_supported\",\n+\t\t\tcap->nonleaf.sched_wfq_packet_mode_supported);\n+\t\trte_tel_data_add_dict_int(d, \"sched_wfq_byte_mode_supported\",\n+\t\t\tcap->nonleaf.sched_wfq_byte_mode_supported);\n+\t} else {\n+\t\trte_tel_data_add_dict_int(d, \"cman_wred_packet_mode_supported\",\n+\t\t\tcap->leaf.cman_wred_packet_mode_supported);\n+\t\trte_tel_data_add_dict_int(d, \"cman_wred_byte_mode_supported\",\n+\t\t\tcap->leaf.cman_wred_byte_mode_supported);\n+\t\trte_tel_data_add_dict_int(d, \"cman_head_drop_supported\",\n+\t\t\tcap->leaf.cman_head_drop_supported);\n+\t\trte_tel_data_add_dict_int(d, \"cman_wred_context_private_supported\",\n+\t\t\tcap->leaf.cman_wred_context_private_supported);\n+\t\trte_tel_data_add_dict_uint(d, \"cman_wred_context_shared_n_max\",\n+\t\t\tcap->leaf.cman_wred_context_shared_n_max);\n+\t}\n+}\n+\n+static int\n+eth_dev_handle_port_tm_node_caps(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_tm_node_capabilities cap = {0};\n+\tstruct rte_tm_error error = {0};\n+\tuint32_t node_id;\n+\tuint16_t port_id;\n+\tchar *end_param;\n+\tint is_leaf;\n+\tint ret;\n+\n+\tret = eth_dev_parse_port_params(params, &port_id, &end_param, true);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\tret = eth_dev_parse_tm_params(end_param, &node_id);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\tret = rte_tm_node_capabilities_get(port_id, node_id, &cap, &error);\n+\tif (ret != 0)\n+\t\tgoto out;\n+\n+\tret = rte_tm_node_type_get(port_id, node_id, &is_leaf, &error);\n+\tif (ret != 0)\n+\t\tgoto out;\n+\n+\trte_tel_data_start_dict(d);\n+\teth_dev_add_tm_node_basic_caps(d, &cap);\n+\teth_dev_add_tm_type_node_caps(d, is_leaf, &cap);\n+\n+\treturn 0;\n+out:\n+\tRTE_ETHDEV_LOG(WARNING, \"error: %s, error type: %u\\n\",\n+\t\terror.message ? error.message : \"no stated reason\",\n+\t\terror.type);\n+\treturn ret;\n+}\n+\n RTE_INIT(ethdev_init_telemetry)\n {\n \trte_telemetry_register_cmd(\"/ethdev/list\", eth_dev_handle_port_list,\n@@ -1332,4 +1434,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns TM Capabilities info for a port. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/tm_level_capability\", eth_dev_handle_port_tm_level_caps,\n \t\t\t\"Returns TM Level Capabilities info for a port. Parameters: int port_id, int level_id (see tm_capability for the max)\");\n+\trte_telemetry_register_cmd(\"/ethdev/tm_node_capability\", eth_dev_handle_port_tm_node_caps,\n+\t\t\t\"Returns TM Node Capabilities info for a port. Parameters: int port_id, int node_id (see tm_capability for the max)\");\n }\n",
    "prefixes": [
        "4/4"
    ]
}