Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132985/?format=api
{ "id": 132985, "url": "http://patchwork.dpdk.org/api/patches/132985/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231019154125.308002-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019154125.308002-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019154125.308002-2-thomas@monjalon.net", "date": "2023-10-19T15:31:52", "name": "[1/2] drivers: use macro for PCI address format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b47bd0277041ea5557d4bbaf1dcdac8e99751241", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231019154125.308002-2-thomas@monjalon.net/mbox/", "series": [ { "id": 29920, "url": "http://patchwork.dpdk.org/api/series/29920/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29920", "date": "2023-10-19T15:31:51", "name": "small cleanup - use PCI lib", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29920/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/132985/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/132985/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6D110431AD;\n\tThu, 19 Oct 2023 17:41:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D016F40695;\n\tThu, 19 Oct 2023 17:41:47 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 3D5EE4029F\n for <dev@dpdk.org>; Thu, 19 Oct 2023 17:41:46 +0200 (CEST)", "from compute5.internal (compute5.nyi.internal [10.202.2.45])\n by mailout.nyi.internal (Postfix) with ESMTP id C0E865C0052;\n Thu, 19 Oct 2023 11:41:45 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute5.internal (MEProxy); Thu, 19 Oct 2023 11:41:45 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n 19 Oct 2023 11:41:42 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:date:date:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to; s=fm3; t=1697730105; x=\n 1697816505; bh=1KbYCnJaCDvX1+vaExiN7vhfkO882ZmV6S0HBIK1C+o=; b=a\n C5d+7vJACdYE1akl25Kca7a48OBZBCmyd6VmozcP9ru7xq5oY7jE/h4TkNXZnxEY\n +neY8hEFS3rCJ/qvYx84ogerTH6TyGL/782H9ql3n3Gs7MxRPPlPv4n+TWnuH0e7\n yUF6KgSmyK0r5+B+sfHaL5RMYXlfVjUG5SgC6h7KpENBStGTceKsMuiwyi/b8EWf\n KYd42cZisYgzKCe6phqL9deoMmd26zbkXdTYjLBY6785RxlG5k3sO4sJTw4AqUBV\n NTIpuNF9tvECLvw3xp2YVYHPBID+uFSxNDMwQEjxnvQf0oTk3CLt0QKAIGmsdbuc\n knU/mt1FnUpYfb8MNVibQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1697730105; x=\n 1697816505; bh=1KbYCnJaCDvX1+vaExiN7vhfkO882ZmV6S0HBIK1C+o=; b=V\n p5JYYr6Hm6wzQEGUOoGfQ0DjVv7L0fzDgehy+X1eUMK/onV0opLnYtsg9ujE4/+3\n Sm4YTNPrfqGhkVzDkdsb8IB0nujACyNNomjMZrK+Ct+vzR4V2CSX4ctJdd+oKguY\n NFfVEWVjBtblR2piBDeaIp/snWwJTerGKvUwmhac3hYqwzx/f+HWNo+hp8e6LZ7k\n zC84Tl2AqgVHmxuG9yZ3dTfKNX1SYuQD4xfgeGmkLAq0AKnncMJf3cpkc/jRNOYe\n hltD64FooCG0ixXZkNDejNU/fGOHSMKBCnVgeLhEzD2+ru64GTAYgwFt+UTlB7an\n hokyPXV8561fTEBmzel4Q==" ], "X-ME-Sender": "<xms:OU4xZT8GNnHMJjUvAUY-NWbki8Zh4klsatpXqkzz7GD4d7KqDD8Bjw>\n <xme:OU4xZftep2kLuRkeJa7VBSt7oSeah6QzD97qGUMG9zc6QC4Mf0CFwOSgtJfWyOTGQ\n 9-AOVDGjvDGerS7zw>", "X-ME-Received": "\n <xmr:OU4xZRBLXYxgc1vFekLAONFqdzkArsKrfX3EXis_zrh87UcHTcDnLwWQdm2LL0iptgW38YHsYzKy9PG40Vzhqfetk5xoCV4>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvkedrjeeigdeltdcutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek\n hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh\n homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:OU4xZffBzOwmf44kUBY80TPxhrcjb-6RjDbXubtw1V9I4VK5p4x22w>\n <xmx:OU4xZYNEagdYnCZW3DXmcHua-ViSt2juATaOix64ycVEYntjngn_EQ>\n <xmx:OU4xZRl6d-V4rJqRiiiySFItrn3kxA-ayeHAU2naBlRfNuEnp9ElNA>\n <xmx:OU4xZVw_PtN7MLR3emklHAJ2RCKTCxP7P4oRRixhmpB1v58y-8qf9Q>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>, chenbox@nvidia.com,\n Jerin Jacob <jerinj@marvell.com>, Michal Krawczyk <mk@semihalf.com>,\n Shai Brandes <shaibran@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,\n Igor Chauskin <igorch@amazon.com>, Ron Beider <rbeider@amazon.com>,\n John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Suanming Mou <suanmingm@nvidia.com>, Maciej Czekaj <mczekaj@marvell.com>", "Subject": "[PATCH 1/2] drivers: use macro for PCI address format", "Date": "Thu, 19 Oct 2023 17:31:52 +0200", "Message-ID": "<20231019154125.308002-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231019154125.308002-1-thomas@monjalon.net>", "References": "<20231019154125.308002-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some places were not using the macro PCI_PRI_FMT\nas print format of a PCI address.\n\nNote: RTE prefix is missing in the name of some PCI macros.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/event/skeleton/skeleton_eventdev.c | 2 +-\n drivers/net/ena/ena_ethdev.c | 2 +-\n drivers/net/enic/enic.h | 3 +--\n drivers/net/enic/enic_ethdev.c | 2 +-\n drivers/net/enic/enic_vf_representor.c | 2 +-\n drivers/net/hinic/hinic_pmd_ethdev.c | 4 ++--\n drivers/net/mlx5/linux/mlx5_os.c | 2 +-\n drivers/net/thunderx/nicvf_ethdev.c | 2 +-\n 8 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c\nindex dc9b131641..dd2dab2e27 100644\n--- a/drivers/event/skeleton/skeleton_eventdev.c\n+++ b/drivers/event/skeleton/skeleton_eventdev.c\n@@ -373,7 +373,7 @@ skeleton_eventdev_init(struct rte_eventdev *eventdev)\n \tskel->subsystem_device_id = pci_dev->id.subsystem_device_id;\n \tskel->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id;\n \n-\tPMD_DRV_LOG(DEBUG, \"pci device (%x:%x) %u:%u:%u:%u\",\n+\tPMD_DRV_LOG(DEBUG, \"PCI device (%x:%x) \" PCI_PRI_FMT,\n \t\t\tpci_dev->id.vendor_id, pci_dev->id.device_id,\n \t\t\tpci_dev->addr.domain, pci_dev->addr.bus,\n \t\t\tpci_dev->addr.devid, pci_dev->addr.function);\ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 7345e480f8..b39ec629e7 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2125,7 +2125,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)\n \n \tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n-\tPMD_INIT_LOG(INFO, \"Initializing %x:%x:%x.%d\\n\",\n+\tPMD_INIT_LOG(INFO, \"Initializing \" PCI_PRI_FMT \"\\n\",\n \t\t pci_dev->addr.domain,\n \t\t pci_dev->addr.bus,\n \t\t pci_dev->addr.devid,\ndiff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h\nindex 163a1f037e..78778704f2 100644\n--- a/drivers/net/enic/enic.h\n+++ b/drivers/net/enic/enic.h\n@@ -32,7 +32,6 @@\n \n #define ENICPMD_SETTING(enic, f) ((enic->config.flags & VENETF_##f) ? 1 : 0)\n \n-#define ENICPMD_BDF_LENGTH 13 /* 0000:00:00.0'\\0' */\n #define ENIC_CALC_IP_CKSUM 1\n #define ENIC_CALC_TCP_UDP_CKSUM 2\n #define ENIC_MAX_MTU 9000\n@@ -101,7 +100,7 @@ struct enic {\n \tbool overlay_offload;\n \tstruct rte_eth_dev *rte_dev;\n \tstruct rte_eth_dev_data *dev_data;\n-\tchar bdf_name[ENICPMD_BDF_LENGTH];\n+\tchar bdf_name[PCI_PRI_STR_SIZE];\n \tint dev_fd;\n \tint iommu_group_fd;\n \tint iommu_groupid;\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex a487256fa1..b04b6c9aa1 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1274,7 +1274,7 @@ static int eth_enic_dev_init(struct rte_eth_dev *eth_dev,\n \tenic->pdev = pdev;\n \taddr = &pdev->addr;\n \n-\tsnprintf(enic->bdf_name, ENICPMD_BDF_LENGTH, \"%04x:%02x:%02x.%x\",\n+\tsnprintf(enic->bdf_name, PCI_PRI_STR_SIZE, PCI_PRI_FMT,\n \t\taddr->domain, addr->bus, addr->devid, addr->function);\n \n \terr = enic_check_devargs(eth_dev);\ndiff --git a/drivers/net/enic/enic_vf_representor.c b/drivers/net/enic/enic_vf_representor.c\nindex 46f85964e9..5d8d29135c 100644\n--- a/drivers/net/enic/enic_vf_representor.c\n+++ b/drivers/net/enic/enic_vf_representor.c\n@@ -707,7 +707,7 @@ int enic_vf_representor_init(struct rte_eth_dev *eth_dev, void *init_params)\n \tLIST_INIT(&vf_enic->memzone_list);\n \trte_spinlock_init(&vf_enic->memzone_list_lock);\n \taddr = &vf->bdf;\n-\tsnprintf(vf_enic->bdf_name, ENICPMD_BDF_LENGTH, \"%04x:%02x:%02x.%x\",\n+\tsnprintf(vf_enic->bdf_name, PCI_PRI_STR_SIZE, PCI_PRI_FMT,\n \t\t addr->domain, addr->bus, addr->devid, addr->function);\n \treturn 0;\n }\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex adc9f75c81..d4978e0649 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -3086,7 +3086,7 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)\n \n \tsnprintf(nic_dev->proc_dev_name,\n \t\t sizeof(nic_dev->proc_dev_name),\n-\t\t \"hinic-%.4x:%.2x:%.2x.%x\",\n+\t\t \"hinic-\" PCI_PRI_FMT,\n \t\t pci_dev->addr.domain, pci_dev->addr.bus,\n \t\t pci_dev->addr.devid, pci_dev->addr.function);\n \n@@ -3202,7 +3202,7 @@ static int hinic_dev_init(struct rte_eth_dev *eth_dev)\n \n \tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n-\tPMD_DRV_LOG(INFO, \"Initializing pf hinic-%.4x:%.2x:%.2x.%x in %s process\",\n+\tPMD_DRV_LOG(INFO, \"Initializing pf hinic-\" PCI_PRI_FMT \" in %s process\",\n \t\t pci_dev->addr.domain, pci_dev->addr.bus,\n \t\t pci_dev->addr.devid, pci_dev->addr.function,\n \t\t (rte_eal_process_type() == RTE_PROC_PRIMARY) ?\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex d5ef695e6d..0706e9e9b2 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1952,7 +1952,7 @@ mlx5_device_bond_pci_match(const char *ibdev_name,\n \t\t\t\tifindex, bond_info->ifindex, bond_info->ifname);\n \t}\n \tif (owner == 0 && pf != 0) {\n-\t\tDRV_LOG(INFO, \"PCIe instance %04x:%02x:%02x.%x isn't bonding owner\",\n+\t\tDRV_LOG(INFO, \"PCIe instance \" PCI_PRI_FMT \" isn't bonding owner\",\n \t\t\t\tpci_dev->domain, pci_dev->bus, pci_dev->devid,\n \t\t\t\tpci_dev->function);\n \t}\ndiff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex ab1e714d97..a504d41dfe 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -2218,7 +2218,7 @@ nicvf_eth_dev_init(struct rte_eth_dev *eth_dev)\n \tnic->subsystem_device_id = pci_dev->id.subsystem_device_id;\n \tnic->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id;\n \n-\tPMD_INIT_LOG(DEBUG, \"nicvf: device (%x:%x) %u:%u:%u:%u\",\n+\tPMD_INIT_LOG(DEBUG, \"nicvf: device (%x:%x) \" PCI_PRI_FMT,\n \t\t\tpci_dev->id.vendor_id, pci_dev->id.device_id,\n \t\t\tpci_dev->addr.domain, pci_dev->addr.bus,\n \t\t\tpci_dev->addr.devid, pci_dev->addr.function);\n", "prefixes": [ "1/2" ] }