Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133015/?format=api
http://patchwork.dpdk.org/api/patches/133015/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231019165559.115742-29-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019165559.115742-29-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019165559.115742-29-stephen@networkplumber.org", "date": "2023-10-19T16:55:57", "name": "[v3,28/29] table: remove experimental from API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9eb34278ca97b05417971bc9f41df304f9799a85", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231019165559.115742-29-stephen@networkplumber.org/mbox/", "series": [ { "id": 29922, "url": "http://patchwork.dpdk.org/api/series/29922/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29922", "date": "2023-10-19T16:55:29", "name": "Promote experimental API's to stable.", "version": 3, "mbox": "http://patchwork.dpdk.org/series/29922/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133015/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FA2A431AE;\n\tThu, 19 Oct 2023 18:59:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 73A1442E95;\n\tThu, 19 Oct 2023 18:56:47 +0200 (CEST)", "from mail-oi1-f171.google.com (mail-oi1-f171.google.com\n [209.85.167.171])\n by mails.dpdk.org (Postfix) with ESMTP id F02CC42E34\n for <dev@dpdk.org>; Thu, 19 Oct 2023 18:56:34 +0200 (CEST)", "by mail-oi1-f171.google.com with SMTP id\n 5614622812f47-3b2ea7cc821so1265151b6e.1\n for <dev@dpdk.org>; Thu, 19 Oct 2023 09:56:34 -0700 (PDT)", "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Oct 2023 09:56:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734594;\n x=1698339394; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/Cxt7XYjdWv6GUQuA6c6TD6H9lIsxZBCp7ZK1bd3YRM=;\n b=cT4WG/5Ox7ly1am40YPb/veucA67UVgnWMnlbpS6Ueu52f97ALBRuqfwnpgjoIwbwC\n +wXPAhkLmAWyHrvNQk+McDtkNbT5Tujvx3IWaF2QwSnE2XHYmSWR3URLeKYwsvV9Jkxo\n oTbk+SQycL+PuwgJlbs9KePczl2xTgISy1ETf7RjKiDlWE+Safxiz7Tsts21hDIut1UB\n Pffdc2FucQywkTYeTBXf9bvrMhFqUSHoKmc/4/WPDv42Ys6xA3CadXRRMJt/Sj4Amhj/\n +TA+23kCuuOH0Csa0qKL9LmXEtf0Sru+TuXwTKQflJkSq5jVdIzPpwxNVeyVmi9yTEg2\n oH2g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697734594; x=1698339394;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/Cxt7XYjdWv6GUQuA6c6TD6H9lIsxZBCp7ZK1bd3YRM=;\n b=POJpQySG8xd/6fqECyDUckWF3h9Okx0UdujFb9x0hp27ai9q1moPnGiXskQFv2gmP8\n Ov0ob51ROVmsbuVRpg2T7GsY9fOXv/O9fakrQLSyvSIZzDX+F9RWb7NKBI9QIDmG04dL\n P+yjADzRN3ljNw4j/R3TBfYzodEUhtC7wYbIPWXGnlcV0LSKzC3gPcnYauNz8jB9ewH3\n Yaw+F/z6HefdeT2IAqdwYRZNDXg8CYazGTwOm+ehStR9OdlKiamPlCTj87SlChpgbLZP\n jIQ04mcY9kflQML8Q22yyJNrQZyTD0tqZdzIE8jXFgD14vJO7+iSsZRBxgs5QdqDPrEB\n v9cw==", "X-Gm-Message-State": "AOJu0YyOQkLVNXi3ii+uSGRRQBKZQTdrFx8p01MWKxNcAl3urJrNA0Ig\n rcmzDUZylIZZ/+UFy9cuLV4NveRbg9bzbIFBAPiC8w==", "X-Google-Smtp-Source": "\n AGHT+IHzbdQDIRJwvN05Qs4Ql2uYZn5I03qtnd3P+qP+zCbJ7Lh2/tYmjO3QoIa8bTakWhBPedoiFQ==", "X-Received": "by 2002:a05:6808:98f:b0:3ab:843f:76fd with SMTP id\n a15-20020a056808098f00b003ab843f76fdmr2913807oic.19.1697734594100;\n Thu, 19 Oct 2023 09:56:34 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Subject": "[PATCH v3 28/29] table: remove experimental from API", "Date": "Thu, 19 Oct 2023 09:55:57 -0700", "Message-Id": "<20231019165559.115742-29-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231019165559.115742-1-stephen@networkplumber.org>", "References": "<20230808173527.186042-1-stephen@networkplumber.org>\n <20231019165559.115742-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Though this library is marked for deprecation in future.\nThis patch follows the guideline in deprecation notice which\nstates the experimental API's will become stable.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n doc/guides/rel_notes/deprecation.rst | 2 --\n lib/table/rte_swx_table_learner.h | 10 ----------\n lib/table/rte_swx_table_selector.h | 6 ------\n lib/table/rte_table_hash_func.h | 9 ---------\n lib/table/version.map | 18 ++----------------\n 5 files changed, 2 insertions(+), 43 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 81b93515cbd9..2526040e44f9 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -139,8 +139,6 @@ Deprecation Notices\n \n * table: The table library legacy API (functions rte_table_*)\n will be deprecated and subsequently removed in DPDK 24.11 release.\n- Before this, the new table library API (functions rte_swx_table_*)\n- will gradually transition from experimental to stable status.\n \n * port: The port library legacy API (functions rte_port_*)\n will be deprecated and subsequently removed in DPDK 24.11 release.\ndiff --git a/lib/table/rte_swx_table_learner.h b/lib/table/rte_swx_table_learner.h\nindex c5ea015b8dcf..66be5fd7d032 100644\n--- a/lib/table/rte_swx_table_learner.h\n+++ b/lib/table/rte_swx_table_learner.h\n@@ -107,7 +107,6 @@ struct rte_swx_table_learner_params {\n * @return\n * Table memory footprint in bytes.\n */\n-__rte_experimental\n uint64_t\n rte_swx_table_learner_footprint_get(struct rte_swx_table_learner_params *params);\n \n@@ -121,7 +120,6 @@ rte_swx_table_learner_footprint_get(struct rte_swx_table_learner_params *params)\n * @return\n * Table mailbox footprint in bytes.\n */\n-__rte_experimental\n uint64_t\n rte_swx_table_learner_mailbox_size_get(void);\n \n@@ -135,7 +133,6 @@ rte_swx_table_learner_mailbox_size_get(void);\n * @return\n * Table handle, on success, or NULL, on error.\n */\n-__rte_experimental\n void *\n rte_swx_table_learner_create(struct rte_swx_table_learner_params *params, int numa_node);\n \n@@ -152,7 +149,6 @@ rte_swx_table_learner_create(struct rte_swx_table_learner_params *params, int nu\n * 0 on success or the following error codes otherwise:\n * -EINVAL: Invalid argument(s).\n */\n-__rte_experimental\n int\n rte_swx_table_learner_timeout_update(void *table,\n \t\t\t\t uint32_t key_timeout_id,\n@@ -206,7 +202,6 @@ rte_swx_table_learner_timeout_update(void *table,\n * 0 when the table lookup operation is not yet completed, and 1 when the table lookup operation\n * is completed. No other return values are allowed.\n */\n-__rte_experimental\n int\n rte_swx_table_learner_lookup(void *table,\n \t\t\t void *mailbox,\n@@ -239,7 +234,6 @@ rte_swx_table_learner_lookup(void *table,\n * @return\n * 0 on success, 1 or error (table full).\n */\n-__rte_experimental\n uint32_t\n rte_swx_table_learner_add(void *table,\n \t\t\t void *mailbox,\n@@ -261,7 +255,6 @@ rte_swx_table_learner_add(void *table,\n * @param[in] time\n * Current time measured in CPU clock cycles.\n */\n-__rte_experimental\n void\n rte_swx_table_learner_rearm(void *table,\n \t\t\t void *mailbox,\n@@ -282,7 +275,6 @@ rte_swx_table_learner_rearm(void *table,\n * @param[in] key_timeout_id\n * Key timeout ID.\n */\n-__rte_experimental\n void\n rte_swx_table_learner_rearm_new(void *table,\n \t\t\t\tvoid *mailbox,\n@@ -301,7 +293,6 @@ rte_swx_table_learner_rearm_new(void *table,\n * @param[in] mailbox\n * Mailbox for the current operation.\n */\n-__rte_experimental\n void\n rte_swx_table_learner_delete(void *table,\n \t\t\t void *mailbox);\n@@ -312,7 +303,6 @@ rte_swx_table_learner_delete(void *table,\n * @param[in] table\n * Table handle.\n */\n-__rte_experimental\n void\n rte_swx_table_learner_free(void *table);\n \ndiff --git a/lib/table/rte_swx_table_selector.h b/lib/table/rte_swx_table_selector.h\nindex 05863cc90b0a..1f9b93640b1f 100644\n--- a/lib/table/rte_swx_table_selector.h\n+++ b/lib/table/rte_swx_table_selector.h\n@@ -83,7 +83,6 @@ struct rte_swx_table_selector_group {\n * @return\n * Selector table memory footprint in bytes.\n */\n-__rte_experimental\n uint64_t\n rte_swx_table_selector_footprint_get(uint32_t n_groups_max, uint32_t n_members_per_group_max);\n \n@@ -97,7 +96,6 @@ rte_swx_table_selector_footprint_get(uint32_t n_groups_max, uint32_t n_members_p\n * @return\n * Selector table mailbox footprint in bytes.\n */\n-__rte_experimental\n uint64_t\n rte_swx_table_selector_mailbox_size_get(void);\n \n@@ -115,7 +113,6 @@ rte_swx_table_selector_mailbox_size_get(void);\n * @return\n * Table handle, on success, or NULL, on error.\n */\n-__rte_experimental\n void *\n rte_swx_table_selector_create(struct rte_swx_table_selector_params *params,\n \t\t\t struct rte_swx_table_selector_group **groups,\n@@ -135,7 +132,6 @@ rte_swx_table_selector_create(struct rte_swx_table_selector_params *params,\n * -EINVAL: Invalid argument(s);\n * -ENOSPC: Too many group members.\n */\n-__rte_experimental\n int\n rte_swx_table_selector_group_set(void *table,\n \t\t\t\t uint32_t group_id,\n@@ -177,7 +173,6 @@ rte_swx_table_selector_group_set(void *table,\n * 0 when the operation is not yet completed, and 1 when the operation is complete. No other\n * return values are allowed.\n */\n-__rte_experimental\n int\n rte_swx_table_selector_select(void *table,\n \t\t\t void *mailbox,\n@@ -191,7 +186,6 @@ rte_swx_table_selector_select(void *table,\n * @param[in] table\n * Selector table handle.\n */\n-__rte_experimental\n void\n rte_swx_table_selector_free(void *table);\n \ndiff --git a/lib/table/rte_table_hash_func.h b/lib/table/rte_table_hash_func.h\nindex a962ec2f68e8..d7013ba6c091 100644\n--- a/lib/table/rte_table_hash_func.h\n+++ b/lib/table/rte_table_hash_func.h\n@@ -14,7 +14,6 @@ extern \"C\" {\n #include <rte_compat.h>\n #include <rte_common.h>\n \n-__rte_experimental\n static inline uint64_t\n rte_crc32_u64_generic(uint64_t crc, uint64_t value)\n {\n@@ -53,7 +52,6 @@ rte_crc32_u64(uint64_t crc, uint64_t v)\n \n #endif\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -67,7 +65,6 @@ rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -86,7 +83,6 @@ rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -108,7 +104,6 @@ rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -134,7 +129,6 @@ rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -160,7 +154,6 @@ rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -187,7 +180,6 @@ rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\n@@ -217,7 +209,6 @@ rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,\n \treturn crc0;\n }\n \n-__rte_experimental\n static inline uint64_t\n rte_table_hash_crc_key64(void *key, void *mask, __rte_unused uint32_t key_size,\n \tuint64_t seed)\ndiff --git a/lib/table/version.map b/lib/table/version.map\nindex 6c8991073210..c73bf2fc4ec7 100644\n--- a/lib/table/version.map\n+++ b/lib/table/version.map\n@@ -15,29 +15,15 @@ DPDK_24 {\n \trte_table_lpm_ipv6_ops;\n \trte_table_lpm_ops;\n \trte_table_stub_ops;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n-\t# added in 20.11\n \trte_swx_table_exact_match_ops;\n \trte_swx_table_exact_match_unoptimized_ops;\n-\n-\t# added in 21.05\n \trte_swx_table_wildcard_match_ops;\n-\n-\t# added in 21.08\n \trte_swx_table_selector_create;\n \trte_swx_table_selector_footprint_get;\n \trte_swx_table_selector_free;\n \trte_swx_table_selector_group_set;\n \trte_swx_table_selector_mailbox_size_get;\n \trte_swx_table_selector_select;\n-\n-\t# added in 21.11\n \trte_swx_table_learner_add;\n \trte_swx_table_learner_create;\n \trte_swx_table_learner_delete;\n@@ -45,9 +31,9 @@ EXPERIMENTAL {\n \trte_swx_table_learner_free;\n \trte_swx_table_learner_lookup;\n \trte_swx_table_learner_mailbox_size_get;\n-\n-\t# added in 22.07\n \trte_swx_table_learner_rearm;\n \trte_swx_table_learner_rearm_new;\n \trte_swx_table_learner_timeout_update;\n+\n+\tlocal: *;\n };\n", "prefixes": [ "v3", "28/29" ] }{ "id": 133015, "url": "