Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133028/?format=api
http://patchwork.dpdk.org/api/patches/133028/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231019173011.1186656-12-skori@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019173011.1186656-12-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019173011.1186656-12-skori@marvell.com", "date": "2023-10-19T17:30:10", "name": "[v11,11/12] app/graph: support CLI option to enable graph stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9b047ee62359ed6842948466a7be6d75348a476d", "submitter": { "id": 1318, "url": "http://patchwork.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231019173011.1186656-12-skori@marvell.com/mbox/", "series": [ { "id": 29924, "url": "http://patchwork.dpdk.org/api/series/29924/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29924", "date": "2023-10-19T17:29:59", "name": "add CLI based graph application", "version": 11, "mbox": "http://patchwork.dpdk.org/series/29924/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133028/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6FC71431B0;\n\tThu, 19 Oct 2023 19:31:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 873ED42E1C;\n\tThu, 19 Oct 2023 19:30:43 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id D964242E2B\n for <dev@dpdk.org>; Thu, 19 Oct 2023 19:30:41 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39JCXquU008133 for <dev@dpdk.org>; Thu, 19 Oct 2023 10:30:41 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ttshubs8j-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 19 Oct 2023 10:30:39 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 19 Oct 2023 10:30:38 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 19 Oct 2023 10:30:38 -0700", "from localhost.localdomain (unknown [10.28.34.25])\n by maili.marvell.com (Postfix) with ESMTP id 12AFF3F7097;\n Thu, 19 Oct 2023 10:30:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=4Mq/8hgu6tF5sfU3HoHCt9+GAQCakY3M1osrATbZk6c=;\n b=XR3mlNiLZz2Nj9kgsA5WC7MrrYKynM3+mQoXieNXc6ChApKujLbaVscgF4dVT59g0BqI\n 7I/DWBTuP6lmXa04dpRgji/a+GOLP1GslCj/geCJB3DRHjzzhHGydg6Zi8FPvWTrBBXd\n smY40SfF0CbQaz2AJdk7HlLpL6F9n3PP5hwPl6sPlXVwM66Y+jXnrJfVaJ3G6I9TNH+D\n pPbgVp/AOxS+rSLV07Z4rmpDuEamXWxNydHeM78U5Wa/7SgQRAiONMaMIL/E5yZP5UfZ\n RlCIEJfueaW/XUty5xfPUIT6chryamVAZTjNNUrjE+5Ulv+/4OF4cUC3ohus5vvuvyFv Qw==", "From": "<skori@marvell.com>", "To": "Sunil Kumar Kori <skori@marvell.com>, Rakesh Kudurumalla\n <rkudurumalla@marvell.com>", "CC": "<dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>", "Subject": "[PATCH v11 11/12] app/graph: support CLI option to enable graph stats", "Date": "Thu, 19 Oct 2023 23:00:10 +0530", "Message-ID": "<20231019173011.1186656-12-skori@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231019173011.1186656-1-skori@marvell.com>", "References": "<20231019105000.520914-13-skori@marvell.com>\n <20231019173011.1186656-1-skori@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "a23qHt75I5j3fZ1oos49tK2nSgN-sqDO", "X-Proofpoint-ORIG-GUID": "a23qHt75I5j3fZ1oos49tK2nSgN-sqDO", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-19_16,2023-10-19_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nAdds application's command line parameter \"--enable-graph-stats\"\nto enable dumping graph stats on console.\n\nBy default, no graph stats will be printed on console but same can\nbe dumped via telnet session using \"graph stats show\" command.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nSigned-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n app/graph/main.c | 17 ++++++++++++++++-\n app/graph/module_api.h | 2 ++\n doc/guides/tools/graph.rst | 4 ++++\n 3 files changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/graph/main.c b/app/graph/main.c\nindex c1cb435588..465376425c 100644\n--- a/app/graph/main.c\n+++ b/app/graph/main.c\n@@ -21,12 +21,13 @@\n volatile bool force_quit;\n struct conn *conn;\n \n-static const char usage[] = \"%s EAL_ARGS -- -s SCRIPT [-h HOST] [-p PORT] \"\n+static const char usage[] = \"%s EAL_ARGS -- -s SCRIPT [-h HOST] [-p PORT] [--enable-graph-stats] \"\n \t\t\t \"[--help]\\n\";\n \n static struct app_params {\n \tstruct conn_params conn;\n \tchar *script_name;\n+\tbool enable_graph_stats;\n } app = {\n \t.conn = {\n \t\t.welcome = \"\\nWelcome!\\n\\n\",\n@@ -40,6 +41,7 @@ static struct app_params {\n \t\t.msg_handle_arg = NULL, /* set later. */\n \t},\n \t.script_name = NULL,\n+\t.enable_graph_stats = false,\n };\n \n static void\n@@ -56,6 +58,7 @@ app_args_parse(int argc, char **argv)\n {\n \tstruct option lgopts[] = {\n \t\t{\"help\", 0, 0, 'H'},\n+\t\t{\"enable-graph-stats\", 0, 0, 'g'},\n \t};\n \tint h_present, p_present, s_present, n_args, i;\n \tchar *app_name = argv[0];\n@@ -133,6 +136,12 @@ app_args_parse(int argc, char **argv)\n \t\t\t}\n \t\t\tbreak;\n \n+\t\tcase 'g':\n+\t\t\tapp.enable_graph_stats = true;\n+\t\t\tprintf(\"WARNING! Telnet session can not be accessed with\"\n+\t\t\t \"--enable-graph-stats\");\n+\t\t\tbreak;\n+\n \t\tcase 'H':\n \t\tdefault:\n \t\t\tprintf(usage, app_name);\n@@ -144,6 +153,12 @@ app_args_parse(int argc, char **argv)\n \treturn 0;\n }\n \n+bool\n+app_graph_stats_enabled(void)\n+{\n+\treturn app.enable_graph_stats;\n+}\n+\n bool\n app_graph_exit(void)\n {\ndiff --git a/app/graph/module_api.h b/app/graph/module_api.h\nindex 392dcfb222..a7d287f5c8 100644\n--- a/app/graph/module_api.h\n+++ b/app/graph/module_api.h\n@@ -24,5 +24,7 @@\n extern volatile bool force_quit;\n extern struct conn *conn;\n \n+bool app_graph_stats_enabled(void);\n bool app_graph_exit(void);\n+\n #endif\ndiff --git a/doc/guides/tools/graph.rst b/doc/guides/tools/graph.rst\nindex 08ec57b7f8..bd8611a3d0 100644\n--- a/doc/guides/tools/graph.rst\n+++ b/doc/guides/tools/graph.rst\n@@ -55,6 +55,10 @@ Following are the application command-line options:\n a mandatory parameter which will be used to create desired graph\n for a given use case.\n \n+* ``--enable-graph-stats``\n+\n+ Enable graph statistics printing on console. By default graph statistics are disabled.\n+\n * ``--help``\n \n Dumps application usage\n", "prefixes": [ "v11", "11/12" ] }{ "id": 133028, "url": "