Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133062/?format=api
{ "id": 133062, "url": "http://patchwork.dpdk.org/api/patches/133062/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231020084804.3625099-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231020084804.3625099-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231020084804.3625099-6-maxime.coquelin@redhat.com", "date": "2023-10-20T08:48:02", "name": "[v2,5/7] vhost: fix check on virtqueue access in in-flight getter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "392aa7fa4041786319662ce079ecdbac75078d3d", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231020084804.3625099-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 29927, "url": "http://patchwork.dpdk.org/api/series/29927/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29927", "date": "2023-10-20T08:47:58", "name": "vhost: ensure virtqueue access status is checked", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29927/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133062/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133062/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31B13431BA;\n\tFri, 20 Oct 2023 10:48:46 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AA94A410E6;\n\tFri, 20 Oct 2023 10:48:22 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 2D37940E7C\n for <dev@dpdk.org>; Fri, 20 Oct 2023 10:48:21 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-466-YiVJ5VLoP-2qg8ZVUz3zrw-1; Fri, 20 Oct 2023 04:48:17 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com\n [10.11.54.2])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E70D5868005;\n Fri, 20 Oct 2023 08:48:16 +0000 (UTC)", "from max-p1.redhat.com (unknown [10.39.208.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 974BE40C6F7B;\n Fri, 20 Oct 2023 08:48:15 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1697791700;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=NzDAVRUip9gWtWqiBGGWRMuHGgIeyrMYN5cD4uzgSg4=;\n b=QZyAAsGC+jP5dwsqHnvuIoa8VPoejt4kYHgcQWVnKUXGF+5GuZNL3dBKzjCjzzfpQ0Fi6v\n kSW/Vf0h8yKQZMWpA6C4Z1aAFewQc70ckCoMSykVZXimw87vAn6NnpX+KKWpN4kSarRORi\n npoKhodNFutDRbw7JaC4U36mB67Rsa0=", "X-MC-Unique": "YiVJ5VLoP-2qg8ZVUz3zrw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@outlook.com,\n fengli@smartx.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Subject": "[PATCH v2 5/7] vhost: fix check on virtqueue access in in-flight\n getter", "Date": "Fri, 20 Oct 2023 10:48:02 +0200", "Message-ID": "<20231020084804.3625099-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20231020084804.3625099-1-maxime.coquelin@redhat.com>", "References": "<20231020084804.3625099-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.2", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Acquiring the access lock is not enough to ensure\nvirtqueue's metadata such as vring pointers are valid.\n\nThe access status must also be checked.\n\nFixes: 0c0935c5f794 (\"vhost: allow to check in-flight packets for async vhost\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex ccd3c0e865..a243f88398 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -2073,9 +2073,15 @@ rte_vhost_async_get_inflight(int vid, uint16_t queue_id)\n \t\treturn ret;\n \t}\n \n+\tif (unlikely(!vq->access_ok)) {\n+\t\tret = -1;\n+\t\tgoto out_unlock;\n+\t}\n+\n \tif (vq->async)\n \t\tret = vq->async->pkts_inflight_n;\n \n+out_unlock:\n \trte_rwlock_write_unlock(&vq->access_lock);\n \n \treturn ret;\n", "prefixes": [ "v2", "5/7" ] }