Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133093/?format=api
{ "id": 133093, "url": "http://patchwork.dpdk.org/api/patches/133093/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231020205759.195126-16-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231020205759.195126-16-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231020205759.195126-16-stephen@networkplumber.org", "date": "2023-10-20T20:57:48", "name": "[v5,15/26] power: remove experimental from API's", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "159a03ddd870f62b9ba8242da6f89635fd468735", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231020205759.195126-16-stephen@networkplumber.org/mbox/", "series": [ { "id": 29935, "url": "http://patchwork.dpdk.org/api/series/29935/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29935", "date": "2023-10-20T20:57:33", "name": "Promote many experimental API's to stable", "version": 5, "mbox": "http://patchwork.dpdk.org/series/29935/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133093/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133093/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C12F431BE;\n\tFri, 20 Oct 2023 23:00:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5224C42DE6;\n\tFri, 20 Oct 2023 22:58:31 +0200 (CEST)", "from mail-pg1-f174.google.com (mail-pg1-f174.google.com\n [209.85.215.174])\n by mails.dpdk.org (Postfix) with ESMTP id EC9D142D90\n for <dev@dpdk.org>; Fri, 20 Oct 2023 22:58:25 +0200 (CEST)", "by mail-pg1-f174.google.com with SMTP id\n 41be03b00d2f7-578b407045bso938707a12.0\n for <dev@dpdk.org>; Fri, 20 Oct 2023 13:58:25 -0700 (PDT)", "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n u17-20020a170902e5d100b001c61512f2a6sm1930961plf.220.2023.10.20.13.58.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 20 Oct 2023 13:58:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697835505;\n x=1698440305; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=GpZALQI3YPDdbUUu1wfefgdWhS1l+MzU+jJ6YC1chQg=;\n b=Iy9YP4Vh+XrlrmOEMMcuRoNZueqwTqRuUx/oqFHIb5mKm83YM55nXJ4Ou1lnElqFQZ\n iAkPOmuxochlJKFlyhzzSj8JDK1K48bpvGRGGzP6gH3wsOslCHsuwCyPMOlQcamz8DQ8\n FBVAIaL/yYjMo3z/Ozj5xmQWl6D1mwyOYX4mcPxAEQym2moX6UR+a2lx9R17NUFMrAfe\n eaGSF9zXSjU17pbpfDvs4EnhDKTddCblFIHWtLRg8ZJfpndda4kdtnfa35ySOhae4UQy\n k4w/1Ns+fP3JaUY0SewpbPUlqw/DUuFomA541ZSx8GffrjBlbRNQ4lQvQXSuwWWvm8It\n N3dw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697835505; x=1698440305;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GpZALQI3YPDdbUUu1wfefgdWhS1l+MzU+jJ6YC1chQg=;\n b=Z8tPmrEIIURJn9oXdFvo4cav4EeeZRHBXCouH2+uVzCB1fjNtqnozz2JN0gKiQQZbJ\n GcDgiV7RAkl/zqkjzW+F4r9iztLCGp3kUTR9gNhYfYM3gL46xcgp0Fj3YpIJTiwVLBEt\n vJQbh2JB9DP76UrQZCpYM+pr8URV7TESj0yKYssW6DmAy3sgsUKh01hFBAFsmcstx3yP\n vkTNlgyWyEJuVpbinMveP+++oQxYE3REd+SuDxxVUN88nrpE//MuS450qJt1QXASWgq8\n ppW4BevAXPUiWBxz98ogA2CtLx9gcYtw5IH0dpWfj8dMYJ0tmI5SV0fxfRDcZooW95Az\n y8Hw==", "X-Gm-Message-State": "AOJu0YyBYYBdTINEIC1LXKtImvQwtj9tYB/Sm9nBbNsXMFQ8PkFvlUqJ\n 5nCHyOp4TU2aygUMZtyvhJUYAV2CGl3ILHPzcd04Lw==", "X-Google-Smtp-Source": "\n AGHT+IFbm8/YASu90uBVcmS7Q2pJ3+GhUDv2OjFWJg6hiGaf59bsyJtx7DfqLd+ey6yZLcGZo+pF+A==", "X-Received": "by 2002:a17:902:ecce:b0:1bb:c06e:647a with SMTP id\n a14-20020a170902ecce00b001bbc06e647amr3347868plh.53.1697835504899;\n Fri, 20 Oct 2023 13:58:24 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n David Hunt <david.hunt@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>", "Subject": "[PATCH v5 15/26] power: remove experimental from API's", "Date": "Fri, 20 Oct 2023 13:57:48 -0700", "Message-Id": "<20231020205759.195126-16-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231020205759.195126-1-stephen@networkplumber.org>", "References": "<20230808173527.186042-1-stephen@networkplumber.org>\n <20231020205759.195126-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The power management API's were last changed in 22.11 release.\nTherefore remove experimental for 23.11 release.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: David Hunt<david.hunt@intel.com>\n---\n lib/power/rte_power.h | 4 ---\n lib/power/rte_power_guest_channel.h | 4 ---\n lib/power/rte_power_pmd_mgmt.h | 40 ----------------------------\n lib/power/rte_power_uncore.h | 5 ----\n lib/power/version.map | 41 ++++++++++-------------------\n 5 files changed, 14 insertions(+), 80 deletions(-)", "diff": "diff --git a/lib/power/rte_power.h b/lib/power/rte_power.h\nindex e79bf1c4dd0c..4b624a01c5d7 100644\n--- a/lib/power/rte_power.h\n+++ b/lib/power/rte_power.h\n@@ -25,9 +25,6 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,\n \t\tPM_ENV_AMD_PSTATE_CPUFREQ};\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n- *\n * Check if a specific power management environment type is supported on a\n * currently running system.\n *\n@@ -39,7 +36,6 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,\n * - 0 if unsupported\n * - -1 if error, with rte_errno indicating reason for error.\n */\n-__rte_experimental\n int rte_power_check_env_supported(enum power_management_env env);\n \n /**\ndiff --git a/lib/power/rte_power_guest_channel.h b/lib/power/rte_power_guest_channel.h\nindex b5de1bd24318..55b76dfc4c08 100644\n--- a/lib/power/rte_power_guest_channel.h\n+++ b/lib/power/rte_power_guest_channel.h\n@@ -135,9 +135,6 @@ int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,\n \t\t\tunsigned int lcore_id);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * Receive a message contained in pkt over the Virtio-Serial\n * from the host endpoint.\n *\n@@ -155,7 +152,6 @@ int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,\n * - 0 on success.\n * - Negative on error.\n */\n-__rte_experimental\n int rte_power_guest_channel_receive_msg(void *pkt,\n \t\tsize_t pkt_len,\n \t\tunsigned int lcore_id);\ndiff --git a/lib/power/rte_power_pmd_mgmt.h b/lib/power/rte_power_pmd_mgmt.h\nindex 0f1a2eb22eb4..456145661917 100644\n--- a/lib/power/rte_power_pmd_mgmt.h\n+++ b/lib/power/rte_power_pmd_mgmt.h\n@@ -33,9 +33,6 @@ enum rte_power_pmd_mgmt_type {\n };\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Enable power management on a specified Ethernet device Rx queue and lcore.\n *\n * @note This function is not thread-safe.\n@@ -55,16 +52,12 @@ enum rte_power_pmd_mgmt_type {\n * 0 on success\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id,\n \t\tuint16_t port_id, uint16_t queue_id,\n \t\tenum rte_power_pmd_mgmt_type mode);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Disable power management on a specified Ethernet device Rx queue and lcore.\n *\n * @note This function is not thread-safe.\n@@ -82,42 +75,30 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id,\n * 0 on success\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,\n \t\tuint16_t port_id, uint16_t queue_id);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Set a emptypoll_max to specified value. Used to specify the number of empty\n * polls to wait before entering sleep state.\n *\n * @param max\n * The value to set emptypoll_max to.\n */\n-__rte_experimental\n void\n rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Get the current value of emptypoll_max.\n *\n * @return\n * The current emptypoll_max value\n */\n-__rte_experimental\n unsigned int\n rte_power_pmd_mgmt_get_emptypoll_max(void);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Set the pause_duration. Used to adjust the pause mode callback duration.\n *\n * @note Duration must be greater than zero.\n@@ -128,27 +109,19 @@ rte_power_pmd_mgmt_get_emptypoll_max(void);\n * 0 on success\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_pmd_mgmt_set_pause_duration(unsigned int duration);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Get the current value of pause_duration.\n *\n * @return\n * The current pause_duration value.\n */\n-__rte_experimental\n unsigned int\n rte_power_pmd_mgmt_get_pause_duration(void);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Set the min frequency to be used for frequency scaling or zero to use defaults.\n *\n * @note Supported by: Pstate mode.\n@@ -161,14 +134,10 @@ rte_power_pmd_mgmt_get_pause_duration(void);\n * 0 on success\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore, unsigned int min);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Set the max frequency to be used for frequency scaling or zero to use defaults.\n *\n * @note Supported by: Pstate mode.\n@@ -182,14 +151,10 @@ rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore, unsigned int min);\n * 0 on success\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore, unsigned int max);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Get the current configured min frequency used for frequency scaling.\n *\n * @note Supported by: Pstate mode.\n@@ -202,14 +167,10 @@ rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore, unsigned int max);\n * , in KiloHertz, used for frequency scaling.\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_pmd_mgmt_get_scaling_freq_min(unsigned int lcore);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.\n- *\n * Get the current configured max frequency used for frequency scaling.\n *\n * @note Supported by: Pstate mode.\n@@ -222,7 +183,6 @@ rte_power_pmd_mgmt_get_scaling_freq_min(unsigned int lcore);\n * , in KiloHertz, used for frequency scaling.\n * <0 on error\n */\n-__rte_experimental\n int\n rte_power_pmd_mgmt_get_scaling_freq_max(unsigned int lcore);\n \ndiff --git a/lib/power/rte_power_uncore.h b/lib/power/rte_power_uncore.h\nindex 295017b7f429..45d5235302c2 100644\n--- a/lib/power/rte_power_uncore.h\n+++ b/lib/power/rte_power_uncore.h\n@@ -38,14 +38,12 @@ enum rte_uncore_power_mgmt_env {\n * - 0 on success.\n * - Negative on error.\n */\n-__rte_experimental\n int rte_power_set_uncore_env(enum rte_uncore_power_mgmt_env env);\n \n /**\n * Unset the global uncore environment configuration.\n * This can only be called after all threads have completed.\n */\n-__rte_experimental\n void rte_power_unset_uncore_env(void);\n \n /**\n@@ -54,7 +52,6 @@ void rte_power_unset_uncore_env(void);\n * @return\n * power_management_env The configured environment.\n */\n-__rte_experimental\n enum rte_uncore_power_mgmt_env rte_power_get_uncore_env(void);\n \n /**\n@@ -74,7 +71,6 @@ enum rte_uncore_power_mgmt_env rte_power_get_uncore_env(void);\n * - 0 on success.\n * - Negative on error.\n */\n-__rte_experimental\n int\n rte_power_uncore_init(unsigned int pkg, unsigned int die);\n \n@@ -96,7 +92,6 @@ rte_power_uncore_init(unsigned int pkg, unsigned int die);\n * - 0 on success.\n * - Negative on error.\n */\n-__rte_experimental\n int\n rte_power_uncore_exit(unsigned int pkg, unsigned int die);\n \ndiff --git a/lib/power/version.map b/lib/power/version.map\nindex 53627b59f189..268711ac858b 100644\n--- a/lib/power/version.map\n+++ b/lib/power/version.map\n@@ -1,6 +1,9 @@\n DPDK_24 {\n \tglobal:\n \n+\trte_power_check_env_supported;\n+\trte_power_ethdev_pmgmt_queue_disable;\n+\trte_power_ethdev_pmgmt_queue_enable;\n \trte_power_exit;\n \trte_power_freq_disable_turbo;\n \trte_power_freq_down;\n@@ -12,27 +15,11 @@ DPDK_24 {\n \trte_power_get_capabilities;\n \trte_power_get_env;\n \trte_power_get_freq;\n+\trte_power_get_uncore_env;\n+\trte_power_get_uncore_freq;\n+\trte_power_guest_channel_receive_msg;\n \trte_power_guest_channel_send_msg;\n \trte_power_init;\n-\trte_power_set_env;\n-\trte_power_set_freq;\n-\trte_power_turbo_status;\n-\trte_power_unset_env;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n-\trte_power_check_env_supported;\n-\trte_power_guest_channel_receive_msg;\n-\n-\t# added in 21.02\n-\trte_power_ethdev_pmgmt_queue_disable;\n-\trte_power_ethdev_pmgmt_queue_enable;\n-\n-\t# added in 22.07\n \trte_power_pmd_mgmt_get_emptypoll_max;\n \trte_power_pmd_mgmt_get_pause_duration;\n \trte_power_pmd_mgmt_get_scaling_freq_max;\n@@ -41,21 +28,21 @@ EXPERIMENTAL {\n \trte_power_pmd_mgmt_set_pause_duration;\n \trte_power_pmd_mgmt_set_scaling_freq_max;\n \trte_power_pmd_mgmt_set_scaling_freq_min;\n-\n-\t# added in 22.11\n-\trte_power_get_uncore_freq;\n+\trte_power_set_env;\n+\trte_power_set_freq;\n+\trte_power_set_uncore_env;\n \trte_power_set_uncore_freq;\n+\trte_power_turbo_status;\n \trte_power_uncore_exit;\n \trte_power_uncore_freq_max;\n \trte_power_uncore_freq_min;\n+\trte_power_uncore_freqs;\n \trte_power_uncore_get_num_dies;\n \trte_power_uncore_get_num_freqs;\n \trte_power_uncore_get_num_pkgs;\n \trte_power_uncore_init;\n-\n-\t# added in 23.11\n-\trte_power_get_uncore_env;\n-\trte_power_set_uncore_env;\n-\trte_power_uncore_freqs;\n+\trte_power_unset_env;\n \trte_power_unset_uncore_env;\n+\n+\tlocal: *;\n };\n", "prefixes": [ "v5", "15/26" ] }