Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133225/?format=api
{ "id": 133225, "url": "http://patchwork.dpdk.org/api/patches/133225/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231024022849.3092506-21-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231024022849.3092506-21-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231024022849.3092506-21-chaoyong.he@corigine.com", "date": "2023-10-24T02:28:44", "name": "[v2,20/25] vdpa/nfp: add the logic of remap PCI memory", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e4ee2560947237ed6e0615893657b4f5ff6bf52f", "submitter": { "id": 2554, "url": "http://patchwork.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231024022849.3092506-21-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29961, "url": "http://patchwork.dpdk.org/api/series/29961/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29961", "date": "2023-10-24T02:28:24", "name": "add the NFP vDPA PMD", "version": 2, "mbox": "http://patchwork.dpdk.org/series/29961/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133225/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DDAF431EB;\n\tTue, 24 Oct 2023 04:32:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6CD6242E02;\n\tTue, 24 Oct 2023 04:30:20 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100])\n by mails.dpdk.org (Postfix) with ESMTP id 70C9C42D76\n for <dev@dpdk.org>; Tue, 24 Oct 2023 04:30:16 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH8PR13MB6182.namprd13.prod.outlook.com (2603:10b6:510:259::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Tue, 24 Oct\n 2023 02:30:15 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::142e:d47c:7320:8a9d]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::142e:d47c:7320:8a9d%4]) with mapi id 15.20.6907.021; Tue, 24 Oct 2023\n 02:30:15 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fyTT3cbC+nP+cpnR0Hyzf5m7Cne3vGbtA5046558Se8LwP1+snxZZwnAKiQ3BTfd/FyVpW2lJctSZ/2kisHydF0FI9eab44kwZttDY5hggFpHQWdfjSXu7wezvQSe5SRL4MMhwFq18ky6YzrFmFh1ZwBsmukVLmwERPwdOzmw5kBNly8sevjUObleq/8ZMRMh5n+XCsRkz06uAphEF1W7nLZwQkeK7gS5NVGm2wvyntZOi2HK556JW199p0wWSLpODAWNM9dw7Cd/qQ8oDdYQCDtYSZXfSKLf0JnRwtGH7ijyeRoTZVpxmZ8wdiCc80A7ggfJAGgnmGY3WBn320zEw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jk/CbMQztnVDf2I4hFCWS4AwJwyfhhq7mTjnyIunuEA=;\n b=CrQxgSJf1+g5PyrFwEHqnBZzb/TtizLecfLmtPtvqd9K0qufWq4EoacR65+EAdiqnzU+QchA6PLVrpvLVEXvhFnZUAVZpI9NQ4ALNtRQO8iEO8WLIlEox5BFjFI5a4XB0lVU1qIyGGAOAmnbl5n5IaOI5aI5fcjdQrKSHdFo7U7S9CjdE9EfuJ8nLWKmTfEUfCDsiyUuYYAtEBUfkzMPC1ONU07vhXrBWRG/1PJHpXwp7kddOEXemyQLJBYA6nYFW81nuGRlKbXaAUuk44gML6U00K9pshdhpZG7hDfTEE6iSdEBHA97vMAt51H8HSmJHzgSSZnR36AHkj/yBvEcYA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jk/CbMQztnVDf2I4hFCWS4AwJwyfhhq7mTjnyIunuEA=;\n b=ix152++hrLBSiaUkY5Y6qrd/pETI/tdegzytawA0b2ZJupTDEbK1c5E5WIGIok71cW78S0H5dmCWVRq9zDFLy8KWCAMNqWal2IsZu9IK3ePo/THpM/mto+IiAFFAicdW2E6idxxnu7mnfay9sy4AWaQwkZzmEhm4xEHpZrNLocY=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Shujing Dong <shujing.dong@corigine.com>, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v2 20/25] vdpa/nfp: add the logic of remap PCI memory", "Date": "Tue, 24 Oct 2023 10:28:44 +0800", "Message-Id": "<20231024022849.3092506-21-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231024022849.3092506-1-chaoyong.he@corigine.com>", "References": "<20231017054545.1692509-1-chaoyong.he@corigine.com>\n <20231024022849.3092506-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BYAPR04CA0015.namprd04.prod.outlook.com\n (2603:10b6:a03:40::28) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH8PR13MB6182:EE_", "X-MS-Office365-Filtering-Correlation-Id": "46b6e814-2b1f-40e7-ff13-08dbd43927b9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n KvAwQ689BBvW19hfBkiNS2rD/572yYMYI1HpzfzuH2P63Hhz5g3sZfSJ0d897OuUEPoumIWSdNMo1Ol1D3JL2tFgxKS4FiFCdhzNgK3/RcsZdlgvtL4jLSvxA3gSwyvX+UrqE//rdEnl8A1SAWOyyd8+NOaGJuXy9xwTN50ERE8WlwN9Y9ea91FtCnLQTeVd1G58AxrbfJllwuS+dvzL2nePNckZkiltdHBunpqOMb+5ghQ4RxI7U5MG2s31DG8x6MIqyxHQuCmB7umVqMSJ6jlW5BlWuf+V4qpC/TJMl9ZsHPlYgdVRFTaTjp/Z4AGsxh4ErwwEcl0sGD8eFKyaBoUirKMhNTsL8ZRq+UH/2at6IMc9g1jGsnXeoXUyE8KEYT7ZHIANHnOvEVVs3/08hzUwkgBj3T+K//QJ+fNWrn2ZT2asNg/GEp0eMSvT7MS7cCxCciAPyPTHIz7C4XITyEBq19cxt0fWx3KMF5kFgvbFXaJoQo1Ah3cWHX/lXBji4K6fpVfIHyQliG0KTKT2Ao+llUcGX0YslhUGa6HlB+G89asKv3NZ+3QHGKhQhpNncfU1mGGUYbUuNWIbnfNMrR3jwRCxwxupa19AgcdEAz99WstQrBF5n57XVsFkbofeI56zTeNvh9+qAzi7RO2UAnySxdPFv/IRxVyebh9FhLY=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(366004)(396003)(376002)(39830400003)(346002)(136003)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(86362001)(66946007)(316002)(2906002)(54906003)(66476007)(6916009)(66556008)(5660300002)(8936002)(44832011)(8676002)(4326008)(36756003)(41300700001)(2616005)(38100700002)(478600001)(1076003)(52116002)(6506007)(107886003)(6666004)(38350700005)(6512007)(26005)(83380400001)(6486002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n G+WX9BwsgVkmmvFwSp+phVz3q6GUG+fzh+0qCIMn5eCpGIVlNxYfAZUQc4rNcWyEiKCdSlleU6U0xyOExu8eElxTvgky18JJ6wg8xXkhFrOf/1b3ji+C+eD42s867QgteTw46ZRfL88NJ1sibLIBntB068xzHFv1pTBnl+kFqdk1ZYMzfvNGb2YiMxlE7CO077K4N05AwTzSg3rREsD61ObEFTldeTl20nLGrMwp6CyG0lxnnAykJph4f2ALY0kcDM2OXbdbBFaCFTi3rzs5hmdsn9Dz035ufY1o4+lOp5qN6uQf5JFQDojsvH1EIFyxkBYJ08mzEHKOAV699fMOfTic1XASThjWf6OTuV49DALvyishjz9FPJU+dek3IVzUQuv/4mTtG54tUaxuvQS4cEVzC/a+AJxzBTi2gLu1mnjJM2ENCtS7UAlZMpwiorRuAa3NkiD8L07bnJ2qSrEHLuPuNRUnspiYAB7f56JxhxBsggh0kR3EnnpbirXBvY9h1k7BIa6uRGmWr9HxsJDTfQ8STATtdbeRwG2Q5SkoTfnSIpNEwmigHTXH0Jo08CFE+Naxo0u/gSaKw44ERpON28kODVFOrdFRtRjaR05ItmJW7CFCWpS1i1Az+TsxgwfYOKKOXNDGBvho/AlNzNQ51wJBkmTMIKENW7IbzGu8hTkSqpFfpdHshOK8wvdFqYFiugpTb2Q8+D79ASHSBTWqjnIGwKTzu1Rq8RfunkP76d3W+ENpdv2FkfJrIKSVPCBWeXvkh9Nzn2EnTCzcpZCg40J2vGSqlZDDdjV9LsrEi8hnIBlTv7vGjh6JtPbBC/pwCvRPGvsaHC4oe3heHnjdf6aTeaeAX8O8zYEVaiQYHdk8U33XfdOIJn5L58uzTglkvPfuGbV0oPGJowaU0OEhvIE8N8IfTaCZwIhM4im5ScItZVnuiV1vcPROy2Z8FZszjtPHMLgpTGHDGfQiyibgM0945CX9Xljes9CVQ9dBDgcvmvNAIz1Zq+c2DnxtbCfkqEN30CN/xoHk7JXL8GuXw8TII23SStempT0GrScMl1v52rZ7m8S1gSr0tcd5zKFpVaeHkL0xBB1+M2OPcu+cRj4YRspa09tSZPkIlCDc61vtgkcfO1IrOWL6nD7qiZ+1+W3keEStAskB4axMZyfHbUXumi7lBwoPmXDuwKROsT5U0EvdOesRVXO6bKDKKsN5yjvLpHlQkcOUXoGX4AQOuDAjUeDYqOSH/MgqJRvCQIxDZ1NrrT3vulVczH+SOeUenUG8FAvkybbgo/74W9ZYDBLVMlH3B81Z4yJrCrwHUq5CDVDDfXBeI6+hKGI720nJdbuiZak25MDNNu2/YWthJ7pri74QNzh4rT3eRHLaP4dupW1xcgBVt6cNbxuL/6SKUAfZn1JzAtO8F9Sh4P74MpfID45PYHay5QtRzVIGlxWUC33FaZfpkWiqkopQEI7ZGqNeG1FV0zBkLcVegerrMg6zGrgJAP0e9oR2hyr9+YQU6fYH1FDQ8ahwCTK0A2KnQvxWGwN4JutLQ2YQOFenQgMqNGKlWGRz0z2ITNbLy8fnM9+565zEl+X7c6/xfRLpSF2jO7dUv0IQzUteXslaaw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 46b6e814-2b1f-40e7-ff13-08dbd43927b9", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Oct 2023 02:30:15.0331 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n wfRf/Daz0FQ0K9kmXnhWzCXv7t4iQkRYdmVnJPJOp5nbf2Zd51bDgA9U4znKtTcptwAaj/utfdouKeGgLYFog3rmgC/v9yAMVU4SGYXF5Bo=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH8PR13MB6182", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add the logic of remap PCI memory.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Shujing Dong <shujing.dong@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/vdpa/nfp/nfp_vdpa.c | 65 ++++++++++++++++++++++++++++++++++++-\n 1 file changed, 64 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/nfp/nfp_vdpa.c b/drivers/vdpa/nfp/nfp_vdpa.c\nindex ef4ae4946a..824b0d681a 100644\n--- a/drivers/vdpa/nfp/nfp_vdpa.c\n+++ b/drivers/vdpa/nfp/nfp_vdpa.c\n@@ -7,6 +7,7 @@\n \n #include <nfp_common_pci.h>\n #include <nfp_dev.h>\n+#include <rte_vfio.h>\n #include <vdpa_driver.h>\n \n #include \"nfp_vdpa_log.h\"\n@@ -16,6 +17,11 @@\n struct nfp_vdpa_dev {\n \tstruct rte_pci_device *pci_dev;\n \tstruct rte_vdpa_device *vdev;\n+\n+\tint vfio_container_fd;\n+\tint vfio_group_fd;\n+\tint vfio_dev_fd;\n+\tint iommu_group;\n };\n \n struct nfp_vdpa_dev_node {\n@@ -53,12 +59,62 @@ nfp_vdpa_find_node_by_pdev(struct rte_pci_device *pdev)\n \treturn NULL;\n }\n \n+static int\n+nfp_vdpa_vfio_setup(struct nfp_vdpa_dev *device)\n+{\n+\tint ret;\n+\tchar dev_name[RTE_DEV_NAME_MAX_LEN] = {0};\n+\tstruct rte_pci_device *pci_dev = device->pci_dev;\n+\n+\trte_pci_unmap_device(pci_dev);\n+\n+\trte_pci_device_name(&pci_dev->addr, dev_name, RTE_DEV_NAME_MAX_LEN);\n+\trte_vfio_get_group_num(rte_pci_get_sysfs_path(), dev_name,\n+\t\t\t&device->iommu_group);\n+\n+\tdevice->vfio_container_fd = rte_vfio_container_create();\n+\tif (device->vfio_container_fd < 0)\n+\t\treturn -1;\n+\n+\tdevice->vfio_group_fd = rte_vfio_container_group_bind(\n+\t\t\tdevice->vfio_container_fd, device->iommu_group);\n+\tif (device->vfio_group_fd < 0)\n+\t\tgoto container_destroy;\n+\n+\tDRV_VDPA_LOG(DEBUG, \"container_fd=%d, group_fd=%d,\\n\",\n+\t\t\tdevice->vfio_container_fd, device->vfio_group_fd);\n+\n+\tret = rte_pci_map_device(pci_dev);\n+\tif (ret != 0)\n+\t\tgoto group_unbind;\n+\n+\tdevice->vfio_dev_fd = rte_intr_dev_fd_get(pci_dev->intr_handle);\n+\n+\treturn 0;\n+\n+group_unbind:\n+\trte_vfio_container_group_unbind(device->vfio_container_fd, device->iommu_group);\n+container_destroy:\n+\trte_vfio_container_destroy(device->vfio_container_fd);\n+\n+\treturn -1;\n+}\n+\n+static void\n+nfp_vdpa_vfio_teardown(struct nfp_vdpa_dev *device)\n+{\n+\trte_pci_unmap_device(device->pci_dev);\n+\trte_vfio_container_group_unbind(device->vfio_container_fd, device->iommu_group);\n+\trte_vfio_container_destroy(device->vfio_container_fd);\n+}\n+\n struct rte_vdpa_dev_ops nfp_vdpa_ops = {\n };\n \n static int\n nfp_vdpa_pci_probe(struct rte_pci_device *pci_dev)\n {\n+\tint ret;\n \tstruct nfp_vdpa_dev *device;\n \tstruct nfp_vdpa_dev_node *node;\n \n@@ -75,10 +131,14 @@ nfp_vdpa_pci_probe(struct rte_pci_device *pci_dev)\n \n \tdevice->pci_dev = pci_dev;\n \n+\tret = nfp_vdpa_vfio_setup(device);\n+\tif (ret != 0)\n+\t\tgoto free_device;\n+\n \tdevice->vdev = rte_vdpa_register_device(&pci_dev->device, &nfp_vdpa_ops);\n \tif (device->vdev == NULL) {\n \t\tDRV_VDPA_LOG(ERR, \"Failed to register device %s\", pci_dev->name);\n-\t\tgoto free_device;\n+\t\tgoto vfio_teardown;\n \t}\n \n \tnode->device = device;\n@@ -88,6 +148,8 @@ nfp_vdpa_pci_probe(struct rte_pci_device *pci_dev)\n \n \treturn 0;\n \n+vfio_teardown:\n+\tnfp_vdpa_vfio_teardown(device);\n free_device:\n \tfree(device);\n free_node:\n@@ -118,6 +180,7 @@ nfp_vdpa_pci_remove(struct rte_pci_device *pci_dev)\n \tpthread_mutex_unlock(&vdpa_list_lock);\n \n \trte_vdpa_unregister_device(device->vdev);\n+\tnfp_vdpa_vfio_teardown(device);\n \n \tfree(device);\n \tfree(node);\n", "prefixes": [ "v2", "20/25" ] }