Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133263/?format=api
{ "id": 133263, "url": "http://patchwork.dpdk.org/api/patches/133263/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231024102128.16832-4-shaibran@amazon.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231024102128.16832-4-shaibran@amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231024102128.16832-4-shaibran@amazon.com", "date": "2023-10-24T10:21:26", "name": "[3/5] net/ena: report Rx overrun errors in xstats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc3e33b1b764a870da8a2701beb02d09420e2991", "submitter": { "id": 2930, "url": "http://patchwork.dpdk.org/api/people/2930/?format=api", "name": "Brandes, Shai", "email": "shaibran@amazon.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231024102128.16832-4-shaibran@amazon.com/mbox/", "series": [ { "id": 29965, "url": "http://patchwork.dpdk.org/api/series/29965/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=29965", "date": "2023-10-24T10:21:23", "name": "net/ena: v2.8.0 driver release", "version": 1, "mbox": "http://patchwork.dpdk.org/series/29965/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133263/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7D1D431EF;\n\tTue, 24 Oct 2023 12:22:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E70FB40ED8;\n\tTue, 24 Oct 2023 12:21:55 +0200 (CEST)", "from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com\n [52.95.48.154])\n by mails.dpdk.org (Postfix) with ESMTP id 822FA4111C\n for <dev@dpdk.org>; Tue, 24 Oct 2023 12:21:54 +0200 (CEST)", "from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO\n email-inbound-relay-pdx-2c-m6i4x-d2040ec1.us-west-2.amazon.com) ([10.43.8.2])\n by smtp-border-fw-6001.iad6.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 10:21:54 +0000", "from smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev\n (pdx2-ws-svc-p26-lb5-vlan2.pdx.amazon.com [10.39.38.66])\n by email-inbound-relay-pdx-2c-m6i4x-d2040ec1.us-west-2.amazon.com (Postfix)\n with ESMTPS id 25EDF40D9B; Tue, 24 Oct 2023 10:21:53 +0000 (UTC)", "from EX19MTAEUA002.ant.amazon.com [10.0.10.100:26284]\n by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.24.96:2525]\n with esmtp (Farcaster)\n id 81a75e8d-b47a-45fd-b71f-798273505ee5;\n Tue, 24 Oct 2023 10:21:51 +0000 (UTC)", "from EX19D017EUA001.ant.amazon.com (10.252.50.71) by\n EX19MTAEUA002.ant.amazon.com (10.252.50.126) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1118.39; Tue, 24 Oct 2023 10:21:51 +0000", "from EX19MTAUWB001.ant.amazon.com (10.250.64.248) by\n EX19D017EUA001.ant.amazon.com (10.252.50.71) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1118.39; Tue, 24 Oct 2023 10:21:50 +0000", "from HFA15-CG15235BS.amazon.com (10.85.143.172) by\n mail-relay.amazon.com (10.250.64.254) with Microsoft SMTP Server id\n 15.2.1118.39 via Frontend Transport; Tue, 24 Oct 2023 10:21:48 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n t=1698142915; x=1729678915;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version;\n bh=v/bYiicxGaz5mvPhBhhGqHEEnt8TVk7qf1AB+y7Srac=;\n b=hoW5sy4/c7OIiwW5sMFdtaoMVGRPbuBoFng7Lm72AfEc3hMFbJeXODUx\n 6+Xku25zFmsDjKGKbhpQAhgsI+0GiqI+mVJSb404wC6Q59FKrqXVr6Zx8\n yi8Mu5DCp7U42ninl941mH3ju+LhbJE3B+AD6fshYwrszu1D4M04o1QQL c=;", "X-IronPort-AV": "E=Sophos;i=\"6.03,247,1694736000\"; d=\"scan'208\";a=\"366000737\"", "X-Farcaster-Flow-ID": "81a75e8d-b47a-45fd-b71f-798273505ee5", "From": "<shaibran@amazon.com>", "To": "<ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, Shai Brandes <shaibran@amazon.com>, Michal Krawczyk\n <mk@semihalf.com>, Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin\n <igorch@amazon.com>, Ron Beider <rbeider@amazon.com>", "Subject": "[PATCH 3/5] net/ena: report Rx overrun errors in xstats", "Date": "Tue, 24 Oct 2023 13:21:26 +0300", "Message-ID": "<20231024102128.16832-4-shaibran@amazon.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231024102128.16832-1-shaibran@amazon.com>", "References": "<20231024102128.16832-1-shaibran@amazon.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Shai Brandes <shaibran@amazon.com>\n\nRX overrun error occur when a packet arrives but there are\nnot enough free buffers in the RX ring to receive it.\nThe driver publishes the extended statistics with the RX\nbuffer overrun errors as reported by the device.\n\nSigned-off-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n doc/guides/rel_notes/release_23_11.rst | 1 +\n drivers/net/ena/ena_ethdev.c | 4 ++++\n drivers/net/ena/ena_ethdev.h | 1 +\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex eefbcc08fe..f622d93384 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -148,6 +148,7 @@ New Features\n \n * Upgraded ENA HAL to latest version.\n * Added support for connection tracking allowance utilization metric.\n+ * Added support for reporting rx overrun errors in xstats.\n \n * **Updated Solarflare net driver.**\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex daec7f7d16..b3ebda6049 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -90,6 +90,7 @@ static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(dev_start),\n \tENA_STAT_GLOBAL_ENTRY(dev_stop),\n \tENA_STAT_GLOBAL_ENTRY(tx_drops),\n+\tENA_STAT_GLOBAL_ENTRY(rx_overruns),\n };\n \n /*\n@@ -3894,15 +3895,18 @@ static void ena_keep_alive(void *adapter_data,\n \tstruct ena_admin_aenq_keep_alive_desc *desc;\n \tuint64_t rx_drops;\n \tuint64_t tx_drops;\n+\tuint64_t rx_overruns;\n \n \tadapter->timestamp_wd = rte_get_timer_cycles();\n \n \tdesc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e;\n \trx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low;\n \ttx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low;\n+\trx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low;\n \n \tadapter->drv_stats->rx_drops = rx_drops;\n \tadapter->dev_stats.tx_drops = tx_drops;\n+\tadapter->dev_stats.rx_overruns = rx_overruns;\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 9268d44dde..3f29764ca6 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -219,6 +219,7 @@ struct ena_stats_dev {\n \t * As a workaround it is being published as an extended statistic.\n \t */\n \tu64 tx_drops;\n+\tu64 rx_overruns;\n };\n \n struct ena_stats_metrics {\n", "prefixes": [ "3/5" ] }