Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 133749,
    "url": "http://patchwork.dpdk.org/api/patches/133749/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231102022321.2254224-3-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231102022321.2254224-3-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231102022321.2254224-3-chaoyong.he@corigine.com",
    "date": "2023-11-02T02:23:12",
    "name": "[02/11] net/nfp: fix the failure to initialize the LSC mask",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "dc8a0f01c7b98b4ac718c86f4f618ff93a379ab1",
    "submitter": {
        "id": 2554,
        "url": "http://patchwork.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231102022321.2254224-3-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 30106,
            "url": "http://patchwork.dpdk.org/api/series/30106/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30106",
            "date": "2023-11-02T02:23:10",
            "name": "Add the support of multiple PF",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/30106/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/133749/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/133749/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9106943267;\n\tThu,  2 Nov 2023 03:24:04 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1986042E5D;\n\tThu,  2 Nov 2023 03:23:51 +0100 (CET)",
            "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1nam02on2120.outbound.protection.outlook.com [40.107.96.120])\n by mails.dpdk.org (Postfix) with ESMTP id 59E7440C35;\n Thu,  2 Nov 2023 03:23:48 +0100 (CET)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by BY5PR13MB4455.namprd13.prod.outlook.com (2603:10b6:a03:1d4::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Thu, 2 Nov\n 2023 02:23:46 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.027; Thu, 2 Nov 2023\n 02:23:46 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=I8ZeexMMqhk2cpGgYBAsSQkIZAI2IZfi1BT4asXU4FRMA0UK/9lQMxsUYdlZELvewd1pjGdCLwPsvC2LCX5D1goPld0CZlfsQjbP5X8snZsNr2PsBw7EYxn5rrbFdaKBawXviq2kvaelKX4G3VS+9mqXnlk+2+5LXpapiRL0kvkjLDRlIFeGt9xPuySUqWWNT3VLLuAKC0fbntSp8H9eZZshQtl5gZx0iqrJOys7b75/OS0jqmY81Kxly50LQOyKIcVlSyBdd4hycyb/9TgZQ/i0+DJAVpXGZGoJjEbkfOieLTRMBTeJBAJXL7CQaV5ddaB8hmEWdONxpb2uzGHFxw==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=oYmpoIGAAVW7+auhek3wx++v6pQcmXxGqAHq810M2gs=;\n b=Wu8FWTwZGGivg/dby8bR6rurVXHAcwgYqaLz9mcspkaOHiFPKrkhE0bdyqw94qa2qQRgPZIEKRlVDhw4ImPrIYFeGgAHGK+SWPhklrIVc1EfDljd1uh+5vmOH3MvNF6QKXOHanxnx4PbwTdmpR1qS2ZB5QogWaHf17+5GjlWt9B0Gp0deocx7PAjv3VVcAkhdQFaFQkzFkwyt0gyEmx5x7A88Qe/PnJ5mFBQwDDjiObSNWCnMd05xxHaHHi+EYwRN1MysDuK4Wz6VIChiQ2I4d7M9+5+xvzM1BOGLL8zX4vnpX1sGGWOFKDGDd3F1smfD9kBUnkJza9bRj4Gnlkleg==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=oYmpoIGAAVW7+auhek3wx++v6pQcmXxGqAHq810M2gs=;\n b=hSqDReSor9CEzzavyoB9XVA/6C4xWhvnkInyKZAIbh5lkiSStsTgiWL4xMcMTr727+qRfMz1HF12iOGsFV6abh3tvjtwVb5M6pN8+tcvZVAy2c6fqLm03ojkLGkP/sdCCdyedCt+bbrlkn3gXcVcolYl8Sq5yiyfCLnP6BA8FDA=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "oss-drivers@corigine.com, Peng Zhang <peng.zhang@corigine.com>,\n stable@dpdk.org, Shihong Wang <shihong.wang@corigine.com>,\n Chaoyong He <chaoyong.he@corigine.com>",
        "Subject": "[PATCH 02/11] net/nfp: fix the failure to initialize the LSC mask",
        "Date": "Thu,  2 Nov 2023 10:23:12 +0800",
        "Message-Id": "<20231102022321.2254224-3-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20231102022321.2254224-1-chaoyong.he@corigine.com>",
        "References": "<20231102022321.2254224-1-chaoyong.he@corigine.com>",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-ClientProxiedBy": "BY5PR20CA0030.namprd20.prod.outlook.com\n (2603:10b6:a03:1f4::43) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|BY5PR13MB4455:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "b576300c-7fa9-4d9e-3172-08dbdb4abdfc",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n mnS7c0bIl1wH9R34qMxobr8MhxJRZuid+7U2Mr14WwkJi+r/8PTYJoH/z58RfDvKPY/nsFZ7FhYAusg3qQJ1UeCv/Nw4NXsVxMiPWUW4Nom5RXPNQO9Z+CXMcT27/3uQpGWPVxSBWoB1zBDpuDMe6dZkVyZUywrWiiLlk13S6G4dZUQYXBToq5P1criS8xu3XTfJAp331EMfU1T/I7av4mWiywCJtcjQsuzY6oOSXbwtMjzEMrMXCMEh+JWm0eqVOXoalMZELI7FEfFuE2AAivsvQKADCocMQhko3ZjokeS/N3xEYZKQRwfnQETXuPEpCVLpPZ6L5IqB/GvM+6/m9utGm8jJvWK94X1vqRGLJzIpW6T0xTqcpMSpOBR88dC8LoYuvuyFKFljeO59glGh7wyx0hpqEom+Ej+p91U3nKq7vLA109uljbCJDuJvwwzFrJIgUU6nRMfvY6/iAkbEXcENpQ18UCXPMphf80ybI/axySr9353MTD4uFRJ1w/CjZZ1l+vRzQt/CjWUh4Gf3GI5SekgMdL+KwlCpL9MckHFBwzJ5PqCUM4Shd6Yhoqk0hmof1t9IVu/1o2gGtwOhMt2pJf3rXvbHW0XNtovyT6RFcOKhQZarmEKVcaqvKVIzWR5igwhsXFnCJqBjPxhQhY9eGzWaiynJTJVSpSO0cNY=",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(346002)(396003)(136003)(39830400003)(376002)(366004)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(2906002)(8936002)(4326008)(8676002)(44832011)(450100002)(6666004)(41300700001)(6486002)(478600001)(66556008)(316002)(66476007)(6916009)(54906003)(5660300002)(66946007)(6506007)(52116002)(107886003)(1076003)(26005)(2616005)(83380400001)(38350700005)(6512007)(36756003)(86362001)(38100700002);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "\n y+Rw93LfG7Lle0AV/LLbyaBLnQPc9z5GhzJkP49SNJZcyPRs5j+niZNzKdlhtEvyZEZDH6nDfw2sPCo1mxopIKNEGj/wZHwKt3q41dGMk6vr4d5bpb6GQAs6b1AZVSx5ExDguFUhgnZIV4xteWCz+1bnzL0zpiN1M96vaDjNbh5w/16wgb919Ayy7cr4T7aLcngJWS31BBFupOy0PO1U27UsJaUjISL2dmRqG0K5kh0w8hCs81+Knz1IKsSMoY/14Zw+NK2I/csz9enxUeVENtVucUZJNiiEKjTPbBY8BXS3vtP6+1FA2LqI6WdpOGklOJGfUaJzXWRWMrYmM8LGLgAye0G61uqHZd76oa+alX0n7KPJY/dUL/usojSF5jjtzux55Di3Ai8G7H4/zKjJPSCUBrs2KI2sU4mtFeE0hxtSJubYcf9NSmJ6UmO+v3Vp4VzpvtASqfzz52GS67O+Bhe/49aDj8yRgQNCBucnInufOD8kBv5jj7+Pkl2SXdvCuxFh3rVdFse+ML4RwREyqpZg7DCUEpudca8vCvkbcnfbrm/W0pNIrFxgt+LH6ag111MBPlUdyExyqTAz3yb8KGwkFxSvVLrr/XGrLiIQVgrWYl/LcQVn6rJI0+P2wB+Cio9N/s4ijji8aMrnFugA90z4KyBux1Ro7vL0dZOHkrhFsA4ErAovF/66NzFHnYsT2joQmbv6mwo3TtmpijSK/Ls9NIiOgumFkVXKOXAZnfHqxaq5agrK5YzcyegQ37T2MQpi6cBdhMkFfchu9PGj/XKV87FUy+jyjmcSlPAIjftlTgYF0rqcjg0LvoxNHKDzpNrM53fCwCarJxVIRnH+3ylfY0vNr0kUbmfuUq1Av3g7Aq0e+vCn5rxR4CVS2+wfqs/jy2SjXh9yQZh1s8QCJti01rM3jc/hCKBzuPvNK3sTMd5tsuXK+TSWxwTXz6FTJ0yLlY9bxi2bv8MFqbxw+qk6dHqF0uyqahzihO8307EPf8AzL4MAgW/cqTsfjdc7vW2HpF578hzXVurz6VOzsbXycCtXwFkfPRKSuqUneqseUndijOg/bz3yartqWzXuMIklYJ5RCiJhQ9Xtn9BBcYQfNalK7wwFvckDhCAxUD8gedXwv6WKeV8kd1bU4BG0S+0EByGDQA2Lc4hKQ4xoIuknxno/8VylCgwpxgDtPqbMs/DqWTayh1S4KB3Gyrs23Ol023diW59Q5QFFLEL2x6LPszhhHMeohM6+5B2gF9nXHyHBJ2qsPt4aVuT/zdbCfAbR6GphlouxHW28IirBnDizNj6zaKsgn8DxRrp28uQKX+ATbAgN4a6Sd+B3a1gLP2jPIVywlnlj/vR0KQZBLGPIz+B6dkZc7BUGBj6GuIA1pz6+WEF7Rh69mGRHFofEtphlJu7QhTQJnekhH4ORL9nAVKOEVeNv4X+17/2hi1aT7Ef3yyf/hraJS43qIUA8CoWe5f34D30nlB7ifQx9LYNF1XOWSxIlGAreWKTBC4lTby0zpUYX8vEv+ywb46TD84hUPzQ5lihvcNn5W86bbaPE57a0q9NRUOSKtNICBVci7e7VypIxH1oPhpAb+Jw5nU5htv3Ev/OOybsHfjDFTw==",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b576300c-7fa9-4d9e-3172-08dbdb4abdfc",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Nov 2023 02:23:46.7574 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n KstH9Lh4DyN7Yw5I3PbC+RdfiI18klysxAp+k7PNbnooSgvjKNJXB/E2pDRvd8cr73r7rxLnygqe5ZNWkvm03J5l16L6RHy/igFl1H+k5wM=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR13MB4455",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Peng Zhang <peng.zhang@corigine.com>\n\nIn rare cases, when DPDK application exit, the interrupt handler was not\nprocessed the interrupt in time, resulting in the LSC interrupt mask bit\nnot being cleared. So when the DPDK application start again, the newly\ncoming LSC interrupts cannot be received and processed properly.\n\nFix this problem by force clear the LSC interrupt mask on port\ninitialization.\n\nFixes: 6c53f87b3497 (\"nfp: add link status interrupt\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shihong Wang <shihong.wang@corigine.com>\nSigned-off-by: Peng Zhang <peng.zhang@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev.c     | 2 ++\n drivers/net/nfp/nfp_ethdev_vf.c  | 2 ++\n drivers/net/nfp/nfp_net_common.c | 2 +-\n drivers/net/nfp/nfp_net_common.h | 1 +\n 4 files changed, 6 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 705465046c..abaf31e27b 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -590,6 +590,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n \t/* Telling the firmware about the LSC interrupt entry */\n \tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n+\t/* Unmask the LSC interrupt */\n+\tnfp_net_irq_unmask(eth_dev);\n \t/* Recording current stats counters values */\n \tnfp_net_stats_reset(eth_dev);\n \ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex f3aa649054..cc345e9218 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -351,6 +351,8 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev)\n \t\t\tnfp_net_dev_interrupt_handler, (void *)eth_dev);\n \t/* Telling the firmware about the LSC interrupt entry */\n \tnn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX);\n+\t/* Unmask the LSC interrupt */\n+\tnfp_net_irq_unmask(eth_dev);\n \t/* Recording current stats counters values */\n \tnfp_net_stats_reset(eth_dev);\n \ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex 4efcdff76f..f8ef049a42 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -1319,7 +1319,7 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev)\n  * If MSI-X auto-masking is enabled clear the mask bit, otherwise\n  * clear the ICR for the entry.\n  */\n-static void\n+void\n nfp_net_irq_unmask(struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\ndiff --git a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h\nindex 1f9001c81d..b9df2fe563 100644\n--- a/drivers/net/nfp/nfp_net_common.h\n+++ b/drivers/net/nfp/nfp_net_common.h\n@@ -205,6 +205,7 @@ int nfp_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id);\n int nfp_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id);\n void nfp_net_params_setup(struct nfp_net_hw *hw);\n void nfp_net_cfg_queue_setup(struct nfp_net_hw *hw);\n+void nfp_net_irq_unmask(struct rte_eth_dev *dev);\n void nfp_net_dev_interrupt_handler(void *param);\n void nfp_net_dev_interrupt_delayed_handler(void *param);\n int nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n",
    "prefixes": [
        "02/11"
    ]
}