Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 133772,
    "url": "http://patchwork.dpdk.org/api/patches/133772/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231102082020.2588392-6-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231102082020.2588392-6-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231102082020.2588392-6-haijie1@huawei.com",
    "date": "2023-11-02T08:20:16",
    "name": "[v9,5/9] app/proc-info: fix never show RSS info",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "bf754ddc24ce870ae62f4a6b3e5416e976e0b4d7",
    "submitter": {
        "id": 2935,
        "url": "http://patchwork.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231102082020.2588392-6-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 30113,
            "url": "http://patchwork.dpdk.org/api/series/30113/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30113",
            "date": "2023-11-02T08:20:14",
            "name": "support setting and querying RSS algorithms",
            "version": 9,
            "mbox": "http://patchwork.dpdk.org/series/30113/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/133772/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/133772/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB8294326B;\n\tThu,  2 Nov 2023 09:24:17 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4C57940E72;\n\tThu,  2 Nov 2023 09:24:01 +0100 (CET)",
            "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 32089402EB\n for <dev@dpdk.org>; Thu,  2 Nov 2023 09:23:57 +0100 (CET)",
            "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SLcJj05Fxz1P7tv;\n Thu,  2 Nov 2023 16:20:52 +0800 (CST)",
            "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Thu, 2 Nov 2023 16:23:55 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "<dev@dpdk.org>, Reshma Pattan <reshma.pattan@intel.com>, John McNamara\n <john.mcnamara@intel.com>, Vipin Varghese <vipin.varghese@amd.com>",
        "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>",
        "Subject": "[PATCH v9 5/9] app/proc-info: fix never show RSS info",
        "Date": "Thu, 2 Nov 2023 16:20:16 +0800",
        "Message-ID": "<20231102082020.2588392-6-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.30.0",
        "In-Reply-To": "<20231102082020.2588392-1-haijie1@huawei.com>",
        "References": "<20230315110033.30143-1-liudongdong3@huawei.com>\n <20231102082020.2588392-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.67.165.2]",
        "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Command show-port should show RSS info (rss_key, len and rss_hf),\nHowever, the information is shown only when rss_conf.rss_key is not\nNULL. Since no memory is allocated for rss_conf.rss_key, rss_key\nwill always be NULL and the rss_info will never show. This patch\nfixes it.\n\nFixes: 8a37f37fc243 (\"app/procinfo: add --show-port\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\nAcked-by: Reshma Pattan <reshma.pattan@intel.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\nAcked-by: Huisong Li <lihuisong@huawei.com>\n---\n app/proc-info/main.c | 21 ++++++++++++---------\n 1 file changed, 12 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex ce53bc30dfec..3a441ba07586 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -151,6 +151,8 @@ struct desc_param {\n static struct desc_param rx_desc_param;\n static struct desc_param tx_desc_param;\n \n+#define RSS_HASH_KEY_SIZE 64\n+\n /* display usage */\n static void\n proc_info_usage(const char *prgname)\n@@ -1011,6 +1013,7 @@ show_port(void)\n \t\tstruct rte_eth_fc_conf fc_conf;\n \t\tstruct rte_ether_addr mac;\n \t\tstruct rte_eth_dev_owner owner;\n+\t\tuint8_t rss_key[RSS_HASH_KEY_SIZE];\n \n \t\t/* Skip if port is not in mask */\n \t\tif ((enabled_port_mask & (1ul << i)) == 0)\n@@ -1169,17 +1172,17 @@ show_port(void)\n \t\t\tprintf(\"\\n\");\n \t\t}\n \n+\t\trss_conf.rss_key = rss_key;\n+\t\trss_conf.rss_key_len = dev_info.hash_key_size;\n \t\tret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);\n \t\tif (ret == 0) {\n-\t\t\tif (rss_conf.rss_key) {\n-\t\t\t\tprintf(\"  - RSS\\n\");\n-\t\t\t\tprintf(\"\\t  -- RSS len %u key (hex):\",\n-\t\t\t\t\t\trss_conf.rss_key_len);\n-\t\t\t\tfor (k = 0; k < rss_conf.rss_key_len; k++)\n-\t\t\t\t\tprintf(\" %x\", rss_conf.rss_key[k]);\n-\t\t\t\tprintf(\"\\t  -- hf 0x%\"PRIx64\"\\n\",\n-\t\t\t\t\t\trss_conf.rss_hf);\n-\t\t\t}\n+\t\t\tprintf(\"  - RSS\\n\");\n+\t\t\tprintf(\"\\t  -- RSS len %u key (hex):\",\n+\t\t\t\t\trss_conf.rss_key_len);\n+\t\t\tfor (k = 0; k < rss_conf.rss_key_len; k++)\n+\t\t\t\tprintf(\" %x\", rss_conf.rss_key[k]);\n+\t\t\tprintf(\"\\t  -- hf 0x%\"PRIx64\"\\n\",\n+\t\t\t\t\trss_conf.rss_hf);\n \t\t}\n \n #ifdef RTE_LIB_SECURITY\n",
    "prefixes": [
        "v9",
        "5/9"
    ]
}