Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133823/?format=api
http://patchwork.dpdk.org/api/patches/133823/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231103073811.13196-5-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231103073811.13196-5-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231103073811.13196-5-fengchengwen@huawei.com", "date": "2023-11-03T07:38:10", "name": "[v3,4/5] net/tap: use new API to parse kvargs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "36ec7509c4099c326e9fcbe00827aff0e5d3d461", "submitter": { "id": 2146, "url": "http://patchwork.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231103073811.13196-5-fengchengwen@huawei.com/mbox/", "series": [ { "id": 30132, "url": "http://patchwork.dpdk.org/api/series/30132/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30132", "date": "2023-11-03T07:38:06", "name": "fix segment fault when parse args", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30132/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133823/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DDA3A43277;\n\tFri, 3 Nov 2023 08:41:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 060DA42DD4;\n\tFri, 3 Nov 2023 08:41:00 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id C383140ED3\n for <dev@dpdk.org>; Fri, 3 Nov 2023 08:40:53 +0100 (CET)", "from dggpeml100024.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SMCMx36bgzVlwh;\n Fri, 3 Nov 2023 15:40:45 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 3 Nov 2023 15:40:50 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>", "CC": "<dev@dpdk.org>, <stephen@networkplumber.org>", "Subject": "[PATCH v3 4/5] net/tap: use new API to parse kvargs", "Date": "Fri, 3 Nov 2023 07:38:10 +0000", "Message-ID": "<20231103073811.13196-5-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231103073811.13196-1-fengchengwen@huawei.com>", "References": "<20230314124813.39521-1-fengchengwen@huawei.com>\n <20231103073811.13196-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggpeml100024.china.huawei.com (7.185.36.115)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This driver could handles both key=value and only-key kvargs, so it\nshould use rte_kvargs_process_opt() instead of rte_kvargs_process() to\nparse.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/tap/rte_eth_tap.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex b25a52655f..8b35de0a7a 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2342,7 +2342,7 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev)\n \t\tkvlist = rte_kvargs_parse(params, valid_arguments);\n \t\tif (kvlist) {\n \t\t\tif (rte_kvargs_count(kvlist, ETH_TAP_IFACE_ARG) == 1) {\n-\t\t\t\tret = rte_kvargs_process(kvlist,\n+\t\t\t\tret = rte_kvargs_process_opt(kvlist,\n \t\t\t\t\tETH_TAP_IFACE_ARG,\n \t\t\t\t\t&set_interface_name,\n \t\t\t\t\ttun_name);\n@@ -2546,28 +2546,28 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)\n \t\tkvlist = rte_kvargs_parse(params, valid_arguments);\n \t\tif (kvlist) {\n \t\t\tif (rte_kvargs_count(kvlist, ETH_TAP_IFACE_ARG) == 1) {\n-\t\t\t\tret = rte_kvargs_process(kvlist,\n-\t\t\t\t\t\t\t ETH_TAP_IFACE_ARG,\n-\t\t\t\t\t\t\t &set_interface_name,\n-\t\t\t\t\t\t\t tap_name);\n+\t\t\t\tret = rte_kvargs_process_opt(kvlist,\n+\t\t\t\t\t\t\t ETH_TAP_IFACE_ARG,\n+\t\t\t\t\t\t\t &set_interface_name,\n+\t\t\t\t\t\t\t tap_name);\n \t\t\t\tif (ret == -1)\n \t\t\t\t\tgoto leave;\n \t\t\t}\n \n \t\t\tif (rte_kvargs_count(kvlist, ETH_TAP_REMOTE_ARG) == 1) {\n-\t\t\t\tret = rte_kvargs_process(kvlist,\n-\t\t\t\t\t\t\t ETH_TAP_REMOTE_ARG,\n-\t\t\t\t\t\t\t &set_remote_iface,\n-\t\t\t\t\t\t\t remote_iface);\n+\t\t\t\tret = rte_kvargs_process_opt(kvlist,\n+\t\t\t\t\t\t\t ETH_TAP_REMOTE_ARG,\n+\t\t\t\t\t\t\t &set_remote_iface,\n+\t\t\t\t\t\t\t remote_iface);\n \t\t\t\tif (ret == -1)\n \t\t\t\t\tgoto leave;\n \t\t\t}\n \n \t\t\tif (rte_kvargs_count(kvlist, ETH_TAP_MAC_ARG) == 1) {\n-\t\t\t\tret = rte_kvargs_process(kvlist,\n-\t\t\t\t\t\t\t ETH_TAP_MAC_ARG,\n-\t\t\t\t\t\t\t &set_mac_type,\n-\t\t\t\t\t\t\t &user_mac);\n+\t\t\t\tret = rte_kvargs_process_opt(kvlist,\n+\t\t\t\t\t\t\t ETH_TAP_MAC_ARG,\n+\t\t\t\t\t\t\t &set_mac_type,\n+\t\t\t\t\t\t\t &user_mac);\n \t\t\t\tif (ret == -1)\n \t\t\t\t\tgoto leave;\n \t\t\t}\n", "prefixes": [ "v3", "4/5" ] }{ "id": 133823, "url": "