Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133834/?format=api
{ "id": 133834, "url": "http://patchwork.dpdk.org/api/patches/133834/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231103112016.1945684-1-shubham.rohila@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231103112016.1945684-1-shubham.rohila@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231103112016.1945684-1-shubham.rohila@amd.com", "date": "2023-11-03T11:20:15", "name": "[v2,1/2] bus/cdx: add support for devices without MSI", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ee0495d76ccc6dad329748d9c52a3d50e996dc8", "submitter": { "id": 3220, "url": "http://patchwork.dpdk.org/api/people/3220/?format=api", "name": "Shubham Rohila", "email": "shubham.rohila@amd.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231103112016.1945684-1-shubham.rohila@amd.com/mbox/", "series": [ { "id": 30135, "url": "http://patchwork.dpdk.org/api/series/30135/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30135", "date": "2023-11-03T11:20:15", "name": "[v2,1/2] bus/cdx: add support for devices without MSI", "version": 2, "mbox": "http://patchwork.dpdk.org/series/30135/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133834/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C69B43279;\n\tFri, 3 Nov 2023 12:20:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 58E194027F;\n\tFri, 3 Nov 2023 12:20:35 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2072.outbound.protection.outlook.com [40.107.94.72])\n by mails.dpdk.org (Postfix) with ESMTP id 68E8440273\n for <dev@dpdk.org>; Fri, 3 Nov 2023 12:20:33 +0100 (CET)", "from MN2PR10CA0019.namprd10.prod.outlook.com (2603:10b6:208:120::32)\n by SJ0PR12MB7068.namprd12.prod.outlook.com (2603:10b6:a03:4ae::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov\n 2023 11:20:31 +0000", "from BL6PEPF0001AB51.namprd04.prod.outlook.com\n (2603:10b6:208:120:cafe::6c) by MN2PR10CA0019.outlook.office365.com\n (2603:10b6:208:120::32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.22 via Frontend\n Transport; Fri, 3 Nov 2023 11:20:30 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF0001AB51.mail.protection.outlook.com (10.167.242.75) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6954.21 via Frontend Transport; Fri, 3 Nov 2023 11:20:30 +0000", "from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 3 Nov\n 2023 06:20:30 -0500", "from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com\n (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 3 Nov\n 2023 06:20:29 -0500", "from xhdipdslab61.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com\n (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.32 via\n Frontend Transport; Fri, 3 Nov 2023 06:20:27 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=PhgiAjbEdGD6vKOk7TLBJEETjCvSd5gNyCyllGkv+aADFVw3eR/WKdluOHwyjJwInn+SYSw6QcdJEA7EPloWox06WAs1Lq0f7qjuetPNAo34C4WkSi+NWotdrM3u/Rgl/mf3RnVn/Z8HAvGZ7z4pnMFytIy2KbvCNomhcDOu0F7MVixFAb5+2vzS3WuqivUnz7r/PaFfpOosBsBKmnfXm5KiBFwZsEMzIRWYpy+EkSohUXgXN0BCWs5p0pGFvne4waoqPK/BomL/6nnMtLH4EDp2M61kZgAvB8UQB2Wtxzqed2Ln2IVeVFhBuQCHGPxY5az3g1McrIgzieI0IONxAQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=nLFRa3rTyzSJRZpvWJP2bsc8PWTABxNWe5eJ+Ojby88=;\n b=XQSKViaFf4XlbbqYnDeWK/Uc4MF11/wJviZJ4vWWa0AuqtajbU2FZAgthMpVdhb54DJNjIAwhvqBQL2j/9l9YA+dLoEnTPl/fS1Vff2tGbY3m8U+bRtJ9UPBKEBqSxM2mW9yKInc1iSjsptC1cEC7IxW4EjxHer8tmGvcMowNVTW0fvSbekuOAQVGODFO+GndErMqnB4fJ6nJuEFMrTz/76LerQ3e3hXlPXU8JxIkgY/dMJJ7tzYQrkgh2mlxg37G+Q6D2FMonH+9JWI6kYb8WPcEemJ6aK9QNTBrcQfmFr66uCA48KVLnLAEXwAV3RcdnTxIS+1kBdyTeuEGRW/wg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=nLFRa3rTyzSJRZpvWJP2bsc8PWTABxNWe5eJ+Ojby88=;\n b=lh7Mo+X9Ttx6x8QM346D9S0gKgak7Q9jXjHCdHZbWBLTixbizOBfqlhQ390qxG/fHAubZ4/gmn8KlbNBZg6RQ//pzwc1nEbxwecGcSMaueUOe3W5BFWTXfwSi07OERNbM4KaXEom9D6KJApNtmHfTSJCfRji8e6Wz/scQ6t8Nfg=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Shubham Rohila <shubham.rohila@amd.com>", "To": "<nikhil.agarwal@amd.com>, <david.marchand@redhat.com>,\n <nipun.gupta@amd.com>, <dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>,\n <anatoly.burakov@intel.com>, Shubham Rohila <shubham.rohila@amd.com>", "Subject": "[PATCH v2 1/2] bus/cdx: add support for devices without MSI", "Date": "Fri, 3 Nov 2023 16:50:15 +0530", "Message-ID": "<20231103112016.1945684-1-shubham.rohila@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231027162212.3353973-1-ferruh.yigit@amd.com>", "References": "<20231027162212.3353973-1-ferruh.yigit@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB51:EE_|SJ0PR12MB7068:EE_", "X-MS-Office365-Filtering-Correlation-Id": "eff42f36-3dc4-400f-9382-08dbdc5ee3b5", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 6aybAgqQi1QYUVZ6p1Y2M5BdsoEIH/m8u9jwiTIH0GxmmhKj/fRRyFbfhDfCy9xQ0bF87M5A+uRv1WVDLHAJ92k8eAc7bE9U5hQ6ZNuCo7NTns0RGvzZUhYp552cj5Wl7aoyjUtaOGtYXH9ZqCY42bRlqqyPdW6+/cPoEnJ/1U/6Ch2Phoa3BVexThrfLlAbpsKMDocAVGU4FZXi74R6CuHeT/nLksaFEpN3hcDdiypG2d07g2X+SrGZ5FLnMDzzsen89JKg+iiEkXcVFYOGblcNqdAR6Dj3ZJyjrP/vb4z8CnXwcXJhxOrDYdneyf/klJkbf64X7c8BD7H6vMeLJ6Da3zv8z0eF0zJv+NaramjiLo8k7vD0IgHJnikJ6sPxNbPuc97oRxvIoJAnhhUalYT2y9Cmdj3+09m1FbTdzhiyT9ZZ3QpTx9XQmzlZYJQUmsMFIm+EITIkb9VN8uJy94USE//zch+k7VA3dOL/ZYLP/O6ZRymwz/qh9tm/yLrchZpA+wBHiduwccdq3to37yuYYU5dPgIkSRSymDlaWwhihsnJE6UH1XB7vopJbRKkn8KAUpynO7b0BQkqQLeFSj4j3SqFawQL9XWWc1d7dwas5oANd7OuVSn1ld/NJSsww3BYW98NGj/eKJJzN/bZn71SMUCZpoQvEscvTOhPHuy6VLNO8OZuZOMOuLw+wek6P9QBP21J4ZKTJpzq6RQsK8mxzqKipRv1ZyQ9IOXl9hZDto/F1Q/Xl3k5wFF7RB1Su34px/eghHwMkvOvt3fltA==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(396003)(39860400002)(346002)(376002)(230922051799003)(451199024)(82310400011)(1800799009)(186009)(64100799003)(36840700001)(40470700004)(46966006)(40460700003)(40480700001)(2616005)(26005)(1076003)(36860700001)(478600001)(54906003)(83380400001)(426003)(2906002)(6666004)(336012)(110136005)(44832011)(41300700001)(70206006)(5660300002)(70586007)(8936002)(4326008)(47076005)(316002)(8676002)(36756003)(356005)(82740400003)(81166007)(86362001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Nov 2023 11:20:30.7952 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n eff42f36-3dc4-400f-9382-08dbdc5ee3b5", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB51.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR12MB7068", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Nikhil Agarwal <nikhil.agarwal@amd.com>\n\nUpdate the cleanup routine for cdx device to support\ndevice without MSI. Also, set vfio_dev_fd for such devices\nThis fd can be used for BME reload operations.\n\nSigned-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com>\nSigned-off-by: Shubham Rohila <shubham.rohila@amd.com>\n---\n v2\n - New patch in the series\n drivers/bus/cdx/cdx.c | 2 +-\n drivers/bus/cdx/cdx_vfio.c | 19 +++++++++----------\n 2 files changed, 10 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c\nindex 541aae76c3..62b108e082 100644\n--- a/drivers/bus/cdx/cdx.c\n+++ b/drivers/bus/cdx/cdx.c\n@@ -405,9 +405,9 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr,\n \treturn ret;\n \n error_probe:\n+\tcdx_vfio_unmap_resource(dev);\n \trte_intr_instance_free(dev->intr_handle);\n \tdev->intr_handle = NULL;\n-\tcdx_vfio_unmap_resource(dev);\n error_map_device:\n \treturn ret;\n }\ndiff --git a/drivers/bus/cdx/cdx_vfio.c b/drivers/bus/cdx/cdx_vfio.c\nindex 8a3ac0b995..8cac79782e 100644\n--- a/drivers/bus/cdx/cdx_vfio.c\n+++ b/drivers/bus/cdx/cdx_vfio.c\n@@ -101,13 +101,12 @@ cdx_vfio_unmap_resource_primary(struct rte_cdx_device *dev)\n \tstruct mapped_cdx_res_list *vfio_res_list;\n \tint ret, vfio_dev_fd;\n \n-\tif (rte_intr_fd_get(dev->intr_handle) < 0)\n-\t\treturn -1;\n-\n-\tif (close(rte_intr_fd_get(dev->intr_handle)) < 0) {\n-\t\tCDX_BUS_ERR(\"Error when closing eventfd file descriptor for %s\",\n-\t\t\tdev->device.name);\n-\t\treturn -1;\n+\tif (rte_intr_fd_get(dev->intr_handle) >= 0) {\n+\t\tif (close(rte_intr_fd_get(dev->intr_handle)) < 0) {\n+\t\t\tCDX_BUS_ERR(\"Error when closing eventfd file descriptor for %s\",\n+\t\t\t\tdev->device.name);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \tvfio_dev_fd = rte_intr_dev_fd_get(dev->intr_handle);\n@@ -185,6 +184,9 @@ cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd,\n {\n \tint i, ret;\n \n+\tif (rte_intr_dev_fd_set(dev->intr_handle, vfio_dev_fd))\n+\t\treturn -1;\n+\n \tif (num_irqs == 0)\n \t\treturn 0;\n \n@@ -227,9 +229,6 @@ cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd,\n \t\tif (rte_intr_type_set(dev->intr_handle, RTE_INTR_HANDLE_VFIO_MSIX))\n \t\t\treturn -1;\n \n-\t\tif (rte_intr_dev_fd_set(dev->intr_handle, vfio_dev_fd))\n-\t\t\treturn -1;\n-\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "v2", "1/2" ] }