Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133882/?format=api
{ "id": 133882, "url": "http://patchwork.dpdk.org/api/patches/133882/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231106073125.55280-3-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231106073125.55280-3-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231106073125.55280-3-fengchengwen@huawei.com", "date": "2023-11-06T07:31:21", "name": "[v5,2/5] net/sfc: use new API to parse kvargs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "388c80b82236918aeebd3631fa30fca8eb7b5e85", "submitter": { "id": 2146, "url": "http://patchwork.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231106073125.55280-3-fengchengwen@huawei.com/mbox/", "series": [ { "id": 30165, "url": "http://patchwork.dpdk.org/api/series/30165/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30165", "date": "2023-11-06T07:31:21", "name": "fix segment fault when parse args", "version": 5, "mbox": "http://patchwork.dpdk.org/series/30165/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133882/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3A1D432B7;\n\tMon, 6 Nov 2023 08:34:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 705BC402B6;\n\tMon, 6 Nov 2023 08:34:43 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id A355C402BA\n for <dev@dpdk.org>; Mon, 6 Nov 2023 08:34:41 +0100 (CET)", "from dggpeml100024.china.huawei.com (unknown [172.30.72.56])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SP30P6Ym8zMmb3;\n Mon, 6 Nov 2023 15:30:13 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Mon, 6 Nov 2023 15:34:06 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <stephen@networkplumber.org>", "Subject": "[PATCH v5 2/5] net/sfc: use new API to parse kvargs", "Date": "Mon, 6 Nov 2023 07:31:21 +0000", "Message-ID": "<20231106073125.55280-3-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231106073125.55280-1-fengchengwen@huawei.com>", "References": "<20230314124813.39521-1-fengchengwen@huawei.com>\n <20231106073125.55280-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml100024.china.huawei.com (7.185.36.115)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The sfc_kvargs_process() and sfc_efx_dev_class_get() function could\nhandle both key=value and only-key, so they should use\nrte_kvargs_process_opt() instead of rte_kvargs_process() to parse.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/common/sfc_efx/sfc_efx.c | 4 ++--\n drivers/net/sfc/sfc_kvargs.c | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c\nindex 2dc5545760..3ebac909f1 100644\n--- a/drivers/common/sfc_efx/sfc_efx.c\n+++ b/drivers/common/sfc_efx/sfc_efx.c\n@@ -52,8 +52,8 @@ sfc_efx_dev_class_get(struct rte_devargs *devargs)\n \t\treturn dev_class;\n \n \tif (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) {\n-\t\trte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS,\n-\t\t\t\t sfc_efx_kvarg_dev_class_handler, &dev_class);\n+\t\trte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS,\n+\t\t\t\t sfc_efx_kvarg_dev_class_handler, &dev_class);\n \t}\n \n \trte_kvargs_free(kvargs);\ndiff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c\nindex 783cb43ae6..24bb896179 100644\n--- a/drivers/net/sfc/sfc_kvargs.c\n+++ b/drivers/net/sfc/sfc_kvargs.c\n@@ -70,7 +70,7 @@ sfc_kvargs_process(struct sfc_adapter *sa, const char *key_match,\n \tif (sa->kvargs == NULL)\n \t\treturn 0;\n \n-\treturn -rte_kvargs_process(sa->kvargs, key_match, handler, opaque_arg);\n+\treturn -rte_kvargs_process_opt(sa->kvargs, key_match, handler, opaque_arg);\n }\n \n int\n", "prefixes": [ "v5", "2/5" ] }