Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133890/?format=api
{ "id": 133890, "url": "http://patchwork.dpdk.org/api/patches/133890/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231106131128.33499-4-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231106131128.33499-4-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231106131128.33499-4-fengchengwen@huawei.com", "date": "2023-11-06T13:11:23", "name": "[v3,3/7] net/bnxt: fix race-condition when report error recovery", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "58ee4c108d8859dd9e6af7a52a90408d8f68b37d", "submitter": { "id": 2146, "url": "http://patchwork.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231106131128.33499-4-fengchengwen@huawei.com/mbox/", "series": [ { "id": 30169, "url": "http://patchwork.dpdk.org/api/series/30169/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30169", "date": "2023-11-06T13:11:23", "name": "fix race-condition of proactive error handling mode", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30169/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133890/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C767E432B0;\n\tMon, 6 Nov 2023 14:14:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EBA224067B;\n\tMon, 6 Nov 2023 14:14:14 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id B1196402B6\n for <dev@dpdk.org>; Mon, 6 Nov 2023 14:14:13 +0100 (CET)", "from dggpeml100024.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SPBd81YNbzvQY9;\n Mon, 6 Nov 2023 21:14:04 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Mon, 6 Nov 2023 21:14:10 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>, <ajit.khaparde@broadcom.com>, Somnath Kotur\n <somnath.kotur@broadcom.com>, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "CC": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>,\n <Honnappa.Nagarahalli@arm.com>", "Subject": "[PATCH v3 3/7] net/bnxt: fix race-condition when report error\n recovery", "Date": "Mon, 6 Nov 2023 13:11:23 +0000", "Message-ID": "<20231106131128.33499-4-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231106131128.33499-1-fengchengwen@huawei.com>", "References": "<20230301030610.49468-1-fengchengwen@huawei.com>\n <20231106131128.33499-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpeml100024.china.huawei.com (7.185.36.115)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If set data path functions to dummy functions before reports error\nrecovering event, there maybe a race-condition with data path threads,\nthis patch fixes it by setting data path functions to dummy functions\nonly after reports such event.\n\nFixes: e11052f3a46f (\"net/bnxt: support proactive error handling mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\nAcked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 13 +++++++------\n drivers/net/bnxt/bnxt_ethdev.c | 4 ++--\n 2 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 0733cf4df2..d8947d5b5f 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -168,14 +168,9 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\tPMD_DRV_LOG(INFO, \"Port conn async event\\n\");\n \t\tbreak;\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY:\n-\t\t/*\n-\t\t * Avoid any rx/tx packet processing during firmware reset\n-\t\t * operation.\n-\t\t */\n-\t\tbnxt_stop_rxtx(bp->eth_dev);\n-\n \t\t/* Ignore reset notify async events when stopping the port */\n \t\tif (!bp->eth_dev->data->dev_started) {\n+\t\t\tbnxt_stop_rxtx(bp->eth_dev);\n \t\t\tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \t\t\treturn;\n \t\t}\n@@ -184,6 +179,12 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \t\t\t\t\t RTE_ETH_EVENT_ERR_RECOVERING,\n \t\t\t\t\t NULL);\n \n+\t\t/*\n+\t\t * Avoid any rx/tx packet processing during firmware reset\n+\t\t * operation.\n+\t\t */\n+\t\tbnxt_stop_rxtx(bp->eth_dev);\n+\n \t\tpthread_mutex_lock(&bp->err_recovery_lock);\n \t\tevent_data = data1;\n \t\t/* timestamp_lo/hi values are in units of 100ms */\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 5c4d96d4b1..003a6eec11 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4616,14 +4616,14 @@ static void bnxt_check_fw_health(void *arg)\n \tbp->flags |= BNXT_FLAG_FATAL_ERROR;\n \tbp->flags |= BNXT_FLAG_FW_RESET;\n \n-\tbnxt_stop_rxtx(bp->eth_dev);\n-\n \tPMD_DRV_LOG(ERR, \"Detected FW dead condition\\n\");\n \n \trte_eth_dev_callback_process(bp->eth_dev,\n \t\t\t\t RTE_ETH_EVENT_ERR_RECOVERING,\n \t\t\t\t NULL);\n \n+\tbnxt_stop_rxtx(bp->eth_dev);\n+\n \tif (bnxt_is_primary_func(bp))\n \t\twait_msec = info->primary_func_wait_period;\n \telse\n", "prefixes": [ "v3", "3/7" ] }