Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133899/?format=api
{ "id": 133899, "url": "http://patchwork.dpdk.org/api/patches/133899/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231104102836.2134140-1-liweiguo@xencore.cn/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231104102836.2134140-1-liweiguo@xencore.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/20231104102836.2134140-1-liweiguo@xencore.cn", "date": "2023-11-04T10:28:36", "name": "net/mvpp2: fix null dereference in vmwa release", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "f2506de27f6c4752bb7d1645fdbc85f0a3a2b72d", "submitter": { "id": 3221, "url": "http://patchwork.dpdk.org/api/people/3221/?format=api", "name": "Weiguo Li", "email": "liweiguo@xencore.cn" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231104102836.2134140-1-liweiguo@xencore.cn/mbox/", "series": [ { "id": 30171, "url": "http://patchwork.dpdk.org/api/series/30171/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30171", "date": "2023-11-04T10:28:36", "name": "net/mvpp2: fix null dereference in vmwa release", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30171/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/133899/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/133899/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DD343432B0;\n\tMon, 6 Nov 2023 15:18:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1A22040A67;\n\tMon, 6 Nov 2023 15:18:17 +0100 (CET)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id 605D94028B;\n Sat, 4 Nov 2023 11:28:54 +0100 (CET)", "from liwg-V5320.. ( [36.112.73.58]) by bizesmtp.qq.com (ESMTP) with\n id ; Sat, 04 Nov 2023 18:28:37 +0800 (CST)" ], "X-QQ-mid": "bizesmtp67t1699093728twc2r3w6", "X-QQ-SSF": "01100000000000108000000A0000000", "X-QQ-FEAT": "D6RqbDSxuq6hqTMI5EYBTu9k5YPUVCbuepwFSj3PKPQ1p9vewvOrT+B7kbjxW\n A5Q1rfyBJm782S7s4+Yev4XfAeLo8hKmuv8lYn+izRF69/ZgyqfwbqSF2pgH1Xy3vHzyi3S\n JgHfkLfeTAy0q++rHqZUm7b0a37QzImVR7ieNpKin906P7+8YQ447HyD31XIMYWpmKZQ4e1\n wqi6mmHOhmVSqu8q4t9p4h9gj6SzRRvo2ol89w4iIJ1tLz6SuVgOJAi6343IzI4hjigdhhf\n hoE+qyA+XNYS19x79tj4KZS0kHU62EKSZqhiodZ5gAeaD7aisZ0Y5QxDLsUluf96x484N/u\n iLX5rCMj38HgvGmFNuLYSzNgdRf+0t3IIcx9bG7pb2c2bI63w0L5DMcX1RWnA==", "X-QQ-GoodBg": "0", "X-BIZMAIL-ID": "7644962349576096817", "From": "Weiguo Li <liweiguo@xencore.cn>", "To": "ophirmu@nvidia.com", "Cc": "lironh@marvell.com,\n\tdev@dpdk.org,\n\tstable@dpdk.org", "Subject": "[PATCH] net/mvpp2: fix null dereference in vmwa release", "Date": "Sat, 4 Nov 2023 18:28:36 +0800", "Message-Id": "<20231104102836.2134140-1-liweiguo@xencore.cn>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:xencore.cn:qybglogicsvrgz:qybglogicsvrgz5a-0", "X-Mailman-Approved-At": "Mon, 06 Nov 2023 15:18:13 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Pointer 'mrvl_cfg' is dereferenced and then compared to NULL.\nMove dereference after NULL test to fix this issue.\n\nFixes: 7af10d29a4a0 (\"net/mlx5/linux: refactor VLAN\")\nCc: stable@dpdk.org\n\nSigned-off-by: Weiguo Li <liweiguo@xencore.cn>\n---\n drivers/net/mlx5/linux/mlx5_vlan_os.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_vlan_os.c b/drivers/net/mlx5/linux/mlx5_vlan_os.c\nindex 81611a8d3f..391c9ce832 100644\n--- a/drivers/net/mlx5/linux/mlx5_vlan_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_vlan_os.c\n@@ -37,12 +37,13 @@ mlx5_vlan_vmwa_release(struct rte_eth_dev *dev,\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_nl_vlan_vmwa_context *vmwa = priv->vmwa_context;\n-\tstruct mlx5_nl_vlan_dev *vlan_dev = &vmwa->vlan_dev[0];\n+\tstruct mlx5_nl_vlan_dev *vlan_dev;\n \n \tMLX5_ASSERT(vlan->created);\n \tMLX5_ASSERT(priv->vmwa_context);\n \tif (!vlan->created || !vmwa)\n \t\treturn;\n+\tvlan_dev = &vmwa->vlan_dev[0];\n \tvlan->created = 0;\n \trte_spinlock_lock(&vmwa->sl);\n \tMLX5_ASSERT(vlan_dev[vlan->tag].refcnt);\n", "prefixes": [] }