Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134042/?format=api
{ "id": 134042, "url": "http://patchwork.dpdk.org/api/patches/134042/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231109230900.24572-5-jspewock@iol.unh.edu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231109230900.24572-5-jspewock@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20231109230900.24572-5-jspewock@iol.unh.edu", "date": "2023-11-09T23:07:34", "name": "[v1,4/7] dts: allow passing parameters into interactive apps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8a5634fc9fc6063318171006b89f22ebcf66dd07", "submitter": { "id": 2772, "url": "http://patchwork.dpdk.org/api/people/2772/?format=api", "name": "Jeremy Spewock", "email": "jspewock@iol.unh.edu" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231109230900.24572-5-jspewock@iol.unh.edu/mbox/", "series": [ { "id": 30229, "url": "http://patchwork.dpdk.org/api/series/30229/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30229", "date": "2023-11-09T23:07:30", "name": "dts: Port scatter suite over", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30229/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134042/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7A117432EC;\n\tFri, 10 Nov 2023 00:09:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8FD53427D8;\n\tFri, 10 Nov 2023 00:09:15 +0100 (CET)", "from mail-pf1-f226.google.com (mail-pf1-f226.google.com\n [209.85.210.226])\n by mails.dpdk.org (Postfix) with ESMTP id DAF974064C\n for <dev@dpdk.org>; Fri, 10 Nov 2023 00:09:10 +0100 (CET)", "by mail-pf1-f226.google.com with SMTP id\n d2e1a72fcca58-6b77ab73c6fso1212812b3a.1\n for <dev@dpdk.org>; Thu, 09 Nov 2023 15:09:10 -0800 (PST)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id\n w32-20020a634920000000b005b64e8336dcsm927286pga.20.2023.11.09.15.09.09\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 09 Nov 2023 15:09:10 -0800 (PST)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f])\n by postal.iol.unh.edu (Postfix) with ESMTP id 49F42605C318;\n Thu, 9 Nov 2023 18:09:09 -0500 (EST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1699571350; x=1700176150; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rxomyntegdrXYkBv8b690HuDHshTcpLqZU8Wlt/jce4=;\n b=HHJ7Ho4RTfIwCQL8y/XVqYNGh1bLMYNnir6xZ42Iic+D9tW2UoTubxruB0rP7jIsPP\n Ol0KMXSdUK/aomItj+Le7QmBdAKrNMA7McoYrfiuNgU5wDEu2nse63J8scWQtWizrqzo\n xQOxPtKHfRaMPyd5LhJlu11f49i7gA7Zkk6GQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1699571350; x=1700176150;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=rxomyntegdrXYkBv8b690HuDHshTcpLqZU8Wlt/jce4=;\n b=PuXkLN6GguL5zFAnuObhiWfRYI/iGxTblFkrrrShXYbEXo/vWGH6Wfcwns/F1x8JiR\n ynX/kRtiL+K/3OKYeaaZykG5ZBVi54LAgfdRTWng2bercReEa6/GLW2/QQYdx5tdNU+C\n i0iJKWMMTpQs1VKz1abyJ/U4WzJSCgDfxBHUXc+XW6xXGwHe/DPpyucoT/E0DBCCA/FW\n +Q3/hCoOrMGV0LyKg3ptGp7p/X/bL+wr5C2nggZfA4ZDo1hyxcMdpPih1294gqjWlgR6\n 6eBNPomGgCmm2opDOSZs3ej6Lvk+Ry8AUdjoErCNHvYdedd+S6bzPL0+D+NOqeRmvvz8\n cdag==", "X-Gm-Message-State": "AOJu0Yx/JVxEtiloQtydyXW02Lu6DIHzWPA9jJS/EShwXpt6P+SgA311\n nSx80PHqEgF1JZLDWknVvoJT5WHdsJhBc9BEd0jCkJcs+rdTqA==", "X-Google-Smtp-Source": "\n AGHT+IGKOniTesvfCvLs5YMds8+B91YwUsKLoF/PQzldzk3Tcbc2YHHUCawIprdHIVuWLamZjjOz4IixoiX4", "X-Received": "by 2002:a05:6a20:729a:b0:181:63e5:d500 with SMTP id\n o26-20020a056a20729a00b0018163e5d500mr1131316pzk.6.1699571350075;\n Thu, 09 Nov 2023 15:09:10 -0800 (PST)", "X-Relaying-Domain": "iol.unh.edu", "From": "jspewock@iol.unh.edu", "To": "Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu,\n paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com,\n andrew.rybchenko@oktetlabs.ru", "Cc": "dev@dpdk.org,\n\tJeremy Spewock <jspewock@iol.unh.edu>", "Subject": "[PATCH v1 4/7] dts: allow passing parameters into interactive apps", "Date": "Thu, 9 Nov 2023 18:07:34 -0500", "Message-ID": "<20231109230900.24572-5-jspewock@iol.unh.edu>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231109230900.24572-1-jspewock@iol.unh.edu>", "References": "<20231109230900.24572-1-jspewock@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jeremy Spewock <jspewock@iol.unh.edu>\n\nModified interactive applications to allow for the ability to pass\nparameters into the app on start up. Also modified the way EAL\nparameters are handled so that the trailing \"--\" separator is added be\ndefault after all EAL parameters.\n\nSigned-off-by: Jeremy Spewock <jspewock@iol.unh.edu>\n---\n dts/framework/remote_session/remote/testpmd_shell.py | 2 +-\n dts/framework/testbed_model/sut_node.py | 11 +++++++----\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/dts/framework/remote_session/remote/testpmd_shell.py b/dts/framework/remote_session/remote/testpmd_shell.py\nindex 3ea16c7ab3..3f6a86aa35 100644\n--- a/dts/framework/remote_session/remote/testpmd_shell.py\n+++ b/dts/framework/remote_session/remote/testpmd_shell.py\n@@ -32,7 +32,7 @@ def _start_application(\n self, get_privileged_command: Callable[[str], str] | None\n ) -> None:\n \"\"\"See \"_start_application\" in InteractiveShell.\"\"\"\n- self._app_args += \" -- -i\"\n+ self._app_args += \" -i\"\n super()._start_application(get_privileged_command)\n \n def get_devices(self) -> list[TestPmdDevice]:\ndiff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py\nindex 4161d3a4d5..bcac939e72 100644\n--- a/dts/framework/testbed_model/sut_node.py\n+++ b/dts/framework/testbed_model/sut_node.py\n@@ -377,7 +377,8 @@ def create_interactive_shell(\n shell_cls: Type[InteractiveShellType],\n timeout: float = SETTINGS.timeout,\n privileged: bool = False,\n- eal_parameters: EalParameters | str | None = None,\n+ eal_parameters: EalParameters | str = \"\",\n+ app_parameters: str = \"\",\n ) -> InteractiveShellType:\n \"\"\"Factory method for creating a handler for an interactive session.\n \n@@ -392,12 +393,14 @@ def create_interactive_shell(\n eal_parameters: List of EAL parameters to use to launch the app. If this\n isn't provided or an empty string is passed, it will default to calling\n create_eal_parameters().\n+ app_parameters: Additional arguments to pass into the application on the\n+ command-line.\n Returns:\n Instance of the desired interactive application.\n \"\"\"\n- if not eal_parameters:\n+ if not eal_parameters and shell_cls.dpdk_app:\n eal_parameters = self.create_eal_parameters()\n-\n+ eal_parameters = f\"{eal_parameters} --\"\n # We need to append the build directory for DPDK apps\n if shell_cls.dpdk_app:\n shell_cls.path = self.main_session.join_remote_path(\n@@ -405,7 +408,7 @@ def create_interactive_shell(\n )\n \n return super().create_interactive_shell(\n- shell_cls, timeout, privileged, str(eal_parameters)\n+ shell_cls, timeout, privileged, f\"{eal_parameters} {app_parameters}\"\n )\n \n def bind_ports_to_driver(self, for_dpdk: bool = True) -> None:\n", "prefixes": [ "v1", "4/7" ] }