Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134073/?format=api
http://patchwork.dpdk.org/api/patches/134073/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231110063653.5948-16-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231110063653.5948-16-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231110063653.5948-16-fengchengwen@huawei.com", "date": "2023-11-10T06:36:52", "name": "[15/16] examples/qos_sched: fix memory leak when parse args", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48d1235030dea1b6c2253526265513f332b4af07", "submitter": { "id": 2146, "url": "http://patchwork.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231110063653.5948-16-fengchengwen@huawei.com/mbox/", "series": [ { "id": 30235, "url": "http://patchwork.dpdk.org/api/series/30235/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30235", "date": "2023-11-10T06:36:40", "name": "verify strdup return value", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30235/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134073/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E6291432EF;\n\tFri, 10 Nov 2023 07:40:55 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9D564410ED;\n\tFri, 10 Nov 2023 07:40:33 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 28D2D410ED\n for <dev@dpdk.org>; Fri, 10 Nov 2023 07:40:30 +0100 (CET)", "from dggpeml100024.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SRThs6f23zWh3Y;\n Fri, 10 Nov 2023 14:40:13 +0800 (CST)", "from localhost.localdomain (10.50.165.33) by\n dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 10 Nov 2023 14:40:29 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>, Cristian Dumitrescu\n <cristian.dumitrescu@intel.com>, Slawomir Mrozowicz\n <slawomirx.mrozowicz@intel.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 15/16] examples/qos_sched: fix memory leak when parse args", "Date": "Fri, 10 Nov 2023 06:36:52 +0000", "Message-ID": "<20231110063653.5948-16-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20231110063653.5948-1-fengchengwen@huawei.com>", "References": "<20231110063653.5948-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggpeml100024.china.huawei.com (7.185.36.115)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Should free the memory which allocated by strdup().\n\nFixes: 035b6a4f4bba (\"examples/qos_sched: fix out-of-bounds option parsing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n examples/qos_sched/args.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c\nindex e97273152a..8d61d3e454 100644\n--- a/examples/qos_sched/args.c\n+++ b/examples/qos_sched/args.c\n@@ -103,8 +103,10 @@ app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32\n \n \tn_tokens = rte_strsplit(string, strnlen(string, 32), tokens, n_vals, separator);\n \n-\tif (n_tokens > MAX_OPT_VALUES)\n+\tif (n_tokens > MAX_OPT_VALUES) {\n+\t\tfree(string);\n \t\treturn -1;\n+\t}\n \n \tfor (i = 0; i < n_tokens; i++)\n \t\topt_vals[i] = (uint32_t)atol(tokens[i]);\n", "prefixes": [ "15/16" ] }{ "id": 134073, "url": "