Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134263/?format=api
{ "id": 134263, "url": "http://patchwork.dpdk.org/api/patches/134263/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114110006.91148-5-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114110006.91148-5-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-5-haijie1@huawei.com", "date": "2023-11-14T10:59:48", "name": "[v3,04/22] app/crypto-perf: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "cc0eec222a4263ceff90b8e81b07a747547dbf9a", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114110006.91148-5-haijie1@huawei.com/mbox/", "series": [ { "id": 30291, "url": "http://patchwork.dpdk.org/api/series/30291/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30291", "date": "2023-11-14T10:59:44", "name": "replace strtok with reentrant version", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30291/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134263/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8756743329;\n\tTue, 14 Nov 2023 12:10:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2B019406BA;\n\tTue, 14 Nov 2023 12:10:05 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id CB3B14027B\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:09:56 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.55])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV3QL6Bf0zmXDL\n for <dev@dpdk.org>; Tue, 14 Nov 2023 19:06:34 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:09:53 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Ciara Power <ciara.power@intel.com>, Sergio Gonzalez\n Monroy <sergio.gonzalez.monroy@intel.com>, Pablo de Lara\n <pablo.de.lara.guarch@intel.com>, Piotr Azarewicz\n <piotr.azarewicz@intel.com>, Michal Kobylinski\n <michalx.kobylinski@intel.com>, Declan Doherty <declan.doherty@intel.com>,\n Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>, Marcin Kerlin\n <marcinx.kerlin@intel.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v3 04/22] app/crypto-perf: replace strtok with reentrant\n version", "Date": "Tue, 14 Nov 2023 18:59:48 +0800", "Message-ID": "<20231114110006.91148-5-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: f6cefe253cc8 (\"app/crypto-perf: add range/list of sizes\")\nFixes: f8be1786b1b8 (\"app/crypto-perf: introduce performance test application\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test-crypto-perf/cperf_options_parsing.c | 16 +++++++++-------\n app/test-crypto-perf/cperf_test_vector_parsing.c | 10 ++++++----\n 2 files changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c\nindex 75afedc7fd6e..77cda0eb8e6f 100644\n--- a/app/test-crypto-perf/cperf_options_parsing.c\n+++ b/app/test-crypto-perf/cperf_options_parsing.c\n@@ -161,6 +161,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)\n {\n \tchar *token;\n \tuint32_t number;\n+\tchar *sp = NULL;\n \n \tchar *copy_arg = strdup(arg);\n \n@@ -168,7 +169,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)\n \t\treturn -1;\n \n \terrno = 0;\n-\ttoken = strtok(copy_arg, \":\");\n+\ttoken = strtok_r(copy_arg, \":\", &sp);\n \n \t/* Parse minimum value */\n \tif (token != NULL) {\n@@ -182,7 +183,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)\n \t} else\n \t\tgoto err_range;\n \n-\ttoken = strtok(NULL, \":\");\n+\ttoken = strtok_r(NULL, \":\", &sp);\n \n \t/* Parse increment value */\n \tif (token != NULL) {\n@@ -196,7 +197,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)\n \t} else\n \t\tgoto err_range;\n \n-\ttoken = strtok(NULL, \":\");\n+\ttoken = strtok_r(NULL, \":\", &sp);\n \n \t/* Parse maximum value */\n \tif (token != NULL) {\n@@ -211,7 +212,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, uint32_t *inc)\n \t} else\n \t\tgoto err_range;\n \n-\tif (strtok(NULL, \":\") != NULL)\n+\tif (strtok_r(NULL, \":\", &sp) != NULL)\n \t\tgoto err_range;\n \n \tfree(copy_arg);\n@@ -230,6 +231,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, uint32_t *max)\n \tuint8_t count = 0;\n \tuint32_t temp_min;\n \tuint32_t temp_max;\n+\tchar *sp = NULL;\n \n \tchar *copy_arg = strdup(arg);\n \n@@ -237,7 +239,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, uint32_t *max)\n \t\treturn -1;\n \n \terrno = 0;\n-\ttoken = strtok(copy_arg, \",\");\n+\ttoken = strtok_r(copy_arg, \",\", &sp);\n \n \t/* Parse first value */\n \tif (token != NULL) {\n@@ -253,7 +255,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, uint32_t *max)\n \t} else\n \t\tgoto err_list;\n \n-\ttoken = strtok(NULL, \",\");\n+\ttoken = strtok_r(NULL, \",\", &sp);\n \n \twhile (token != NULL) {\n \t\tif (count == MAX_LIST) {\n@@ -275,7 +277,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, uint32_t *max)\n \t\tif (number > temp_max)\n \t\t\ttemp_max = number;\n \n-\t\ttoken = strtok(NULL, \",\");\n+\t\ttoken = strtok_r(NULL, \",\", &sp);\n \t}\n \n \tif (min)\ndiff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c\nindex 737d61d4af6b..4d2e6053e745 100644\n--- a/app/test-crypto-perf/cperf_test_vector_parsing.c\n+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c\n@@ -220,8 +220,9 @@ parse_values(char *tokens, uint8_t **data, uint32_t *data_length)\n \n \tuint8_t *values, *values_resized;\n \tchar *tok, *error = NULL;\n+\tchar *sp = NULL;\n \n-\ttok = strtok(tokens, CPERF_VALUE_DELIMITER);\n+\ttok = strtok_r(tokens, CPERF_VALUE_DELIMITER, &sp);\n \tif (tok == NULL)\n \t\treturn -1;\n \n@@ -252,7 +253,7 @@ parse_values(char *tokens, uint8_t **data, uint32_t *data_length)\n \t\t\treturn -1;\n \t\t}\n \n-\t\ttok = strtok(NULL, CPERF_VALUE_DELIMITER);\n+\t\ttok = strtok_r(NULL, CPERF_VALUE_DELIMITER, &sp);\n \t\tif (tok == NULL)\n \t\t\tbreak;\n \n@@ -283,6 +284,7 @@ parse_entry(char *entry, struct cperf_test_vector *vector,\n \n \tuint8_t *data = NULL;\n \tchar *token, *key_token;\n+\tchar *sp = NULL;\n \n \tif (entry == NULL) {\n \t\tprintf(\"Expected entry value\\n\");\n@@ -290,10 +292,10 @@ parse_entry(char *entry, struct cperf_test_vector *vector,\n \t}\n \n \t/* get key */\n-\ttoken = strtok(entry, CPERF_ENTRY_DELIMITER);\n+\ttoken = strtok_r(entry, CPERF_ENTRY_DELIMITER, &sp);\n \tkey_token = token;\n \t/* get values for key */\n-\ttoken = strtok(NULL, CPERF_ENTRY_DELIMITER);\n+\ttoken = strtok_r(NULL, CPERF_ENTRY_DELIMITER, &sp);\n \n \tif (key_token == NULL || token == NULL) {\n \t\tprintf(\"Expected 'key = values' but was '%.40s'..\\n\", entry);\n", "prefixes": [ "v3", "04/22" ] }