Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134275/?format=api
{ "id": 134275, "url": "http://patchwork.dpdk.org/api/patches/134275/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114110006.91148-19-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114110006.91148-19-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114110006.91148-19-haijie1@huawei.com", "date": "2023-11-14T11:00:02", "name": "[v3,18/22] net/ark: replace strtok with reentrant version", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7c7700781df898e22145b32b95fed8eb97cf855d", "submitter": { "id": 2935, "url": "http://patchwork.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114110006.91148-19-haijie1@huawei.com/mbox/", "series": [ { "id": 30291, "url": "http://patchwork.dpdk.org/api/series/30291/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30291", "date": "2023-11-14T10:59:44", "name": "replace strtok with reentrant version", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30291/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134275/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D0EC43329;\n\tTue, 14 Nov 2023 12:11:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C121840EDC;\n\tTue, 14 Nov 2023 12:10:19 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 8F0764068A\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:10:02 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV3V156z6zvQF5;\n Tue, 14 Nov 2023 19:09:45 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 19:10:00 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck\n <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v3 18/22] net/ark: replace strtok with reentrant version", "Date": "Tue, 14 Nov 2023 19:00:02 +0800", "Message-ID": "<20231114110006.91148-19-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114110006.91148-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114110006.91148-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThe strtok() is non-reentrant, it is better to replace it with a\nreentrant version.\n\nFixes: 9c7188a68d7b (\"net/ark: provide API for hardware modules pktchkr and pktgen\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/ark/ark_pktchkr.c | 10 +++++-----\n drivers/net/ark/ark_pktgen.c | 10 +++++-----\n 2 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pktchkr.c\nindex e1f336c73c2a..6e8e5339607b 100644\n--- a/drivers/net/ark/ark_pktchkr.c\n+++ b/drivers/net/ark/ark_pktchkr.c\n@@ -359,14 +359,14 @@ set_arg(char *arg, char *val)\n void\n ark_pktchkr_parse(char *args)\n {\n-\tchar *argv, *v;\n+\tchar *argv, *v, *sp = NULL;\n \tconst char toks[] = \"=\\n\\t\\v\\f \\r\";\n-\targv = strtok(args, toks);\n-\tv = strtok(NULL, toks);\n+\targv = strtok_r(args, toks, &sp);\n+\tv = strtok_r(NULL, toks, &sp);\n \twhile (argv && v) {\n \t\tset_arg(argv, v);\n-\t\targv = strtok(NULL, toks);\n-\t\tv = strtok(NULL, toks);\n+\t\targv = strtok_r(NULL, toks, &sp);\n+\t\tv = strtok_r(NULL, toks, &sp);\n \t}\n }\n \ndiff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c\nindex 69ff7072b2ab..d611406a1b46 100644\n--- a/drivers/net/ark/ark_pktgen.c\n+++ b/drivers/net/ark/ark_pktgen.c\n@@ -340,14 +340,14 @@ pmd_set_arg(char *arg, char *val)\n void\n ark_pktgen_parse(char *args)\n {\n-\tchar *argv, *v;\n+\tchar *argv, *v, *sp = NULL;\n \tconst char toks[] = \" =\\n\\t\\v\\f \\r\";\n-\targv = strtok(args, toks);\n-\tv = strtok(NULL, toks);\n+\targv = strtok_r(args, toks, &sp);\n+\tv = strtok_r(NULL, toks, &sp);\n \twhile (argv && v) {\n \t\tpmd_set_arg(argv, v);\n-\t\targv = strtok(NULL, toks);\n-\t\tv = strtok(NULL, toks);\n+\t\targv = strtok_r(NULL, toks, &sp);\n+\t\tv = strtok_r(NULL, toks, &sp);\n \t}\n }\n \n", "prefixes": [ "v3", "18/22" ] }