Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134306/?format=api
{ "id": 134306, "url": "http://patchwork.dpdk.org/api/patches/134306/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114112407.3496460-29-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114112407.3496460-29-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114112407.3496460-29-huangdengdui@huawei.com", "date": "2023-11-14T11:23:52", "name": "[v2,28/43] net/failsafe: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1e6cf4a657aef19c45d665971d2f3d0924f7da1d", "submitter": { "id": 3066, "url": "http://patchwork.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114112407.3496460-29-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30292, "url": "http://patchwork.dpdk.org/api/series/30292/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30292", "date": "2023-11-14T11:23:25", "name": "replace strerror", "version": 2, "mbox": "http://patchwork.dpdk.org/series/30292/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134306/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134306/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3C5643329;\n\tTue, 14 Nov 2023 12:26:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1F9B1410E4;\n\tTue, 14 Nov 2023 12:24:43 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 98C6B402F1\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:24:13 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV3pG5X67zWhNm;\n Tue, 14 Nov 2023 19:23:50 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 19:24:12 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH v2 28/43] net/failsafe: use rte strerror", "Date": "Tue, 14 Nov 2023 19:23:52 +0800", "Message-ID": "<20231114112407.3496460-29-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114112407.3496460-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114112407.3496460-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/failsafe/failsafe.c | 8 ++++----\n drivers/net/failsafe/failsafe_args.c | 4 ++--\n drivers/net/failsafe/failsafe_eal.c | 4 ++--\n drivers/net/failsafe/failsafe_flow.c | 4 ++--\n drivers/net/failsafe/failsafe_ops.c | 2 +-\n drivers/net/failsafe/failsafe_private.h | 6 +++---\n 6 files changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 32811403b4..f89c946ce4 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -92,7 +92,7 @@ failsafe_hotplug_alarm_cancel(struct rte_eth_dev *dev)\n \trte_eal_alarm_cancel(fs_hotplug_alarm, dev);\n \tif (rte_errno) {\n \t\tERROR(\"rte_eal_alarm_cancel failed (errno: %s)\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\tret = -rte_errno;\n \t} else {\n \t\tPRIV(dev)->pending_alarm = 0;\n@@ -138,18 +138,18 @@ fs_mutex_init(struct fs_priv *priv)\n \n \tret = pthread_mutexattr_init(&attr);\n \tif (ret) {\n-\t\tERROR(\"Cannot initiate mutex attributes - %s\", strerror(ret));\n+\t\tERROR(\"Cannot initiate mutex attributes - %s\", rte_strerror(ret));\n \t\treturn ret;\n \t}\n \t/* Allow mutex relocks for the thread holding the mutex. */\n \tret = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);\n \tif (ret) {\n-\t\tERROR(\"Cannot set mutex type - %s\", strerror(ret));\n+\t\tERROR(\"Cannot set mutex type - %s\", rte_strerror(ret));\n \t\treturn ret;\n \t}\n \tret = pthread_mutex_init(&priv->hotplug_mutex, &attr);\n \tif (ret) {\n-\t\tERROR(\"Cannot initiate mutex - %s\", strerror(ret));\n+\t\tERROR(\"Cannot initiate mutex - %s\", rte_strerror(ret));\n \t\treturn ret;\n \t}\n \treturn 0;\ndiff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c\nindex b203e02d9a..77169b7bbe 100644\n--- a/drivers/net/failsafe/failsafe_args.c\n+++ b/drivers/net/failsafe/failsafe_args.c\n@@ -112,7 +112,7 @@ fs_execute_cmd(struct sub_device *sdev, char *cmdline)\n \tfp = popen(sdev->cmdline, \"r\");\n \tif (fp == NULL) {\n \t\tret = -errno;\n-\t\tERROR(\"popen: %s\", strerror(errno));\n+\t\tERROR(\"popen: %s\", rte_strerror(errno));\n \t\treturn ret;\n \t}\n \t/* We only read one line */\n@@ -131,7 +131,7 @@ fs_execute_cmd(struct sub_device *sdev, char *cmdline)\n \t\tERROR(\"Parsing device '%s' failed\", output);\n ret_pclose:\n \tif (pclose(fp) == -1)\n-\t\tERROR(\"pclose: %s\", strerror(errno));\n+\t\tERROR(\"pclose: %s\", rte_strerror(errno));\n \treturn ret;\n }\n \ndiff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c\nindex d71b512f81..b06579692a 100644\n--- a/drivers/net/failsafe/failsafe_eal.c\n+++ b/drivers/net/failsafe/failsafe_eal.c\n@@ -52,7 +52,7 @@ fs_bus_init(struct rte_eth_dev *dev)\n \t\t\tif (ret < 0) {\n \t\t\t\tERROR(\"sub_device %d probe failed %s%s%s\", i,\n \t\t\t\t rte_errno ? \"(\" : \"\",\n-\t\t\t\t rte_errno ? strerror(rte_errno) : \"\",\n+\t\t\t\t rte_errno ? rte_strerror(rte_errno) : \"\",\n \t\t\t\t rte_errno ? \")\" : \"\");\n \t\t\t\tcontinue;\n \t\t\t}\n@@ -100,7 +100,7 @@ fs_bus_init(struct rte_eth_dev *dev)\n \t\t\tret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner);\n \t\t\tif (ret < 0) {\n \t\t\t\tINFO(\"sub_device %d owner set failed (%s), \"\n-\t\t\t\t \"will try again later\", i, strerror(-ret));\n+\t\t\t\t \"will try again later\", i, rte_strerror(-ret));\n \t\t\t\tcontinue;\n \t\t\t} else if (strncmp(rte_eth_devices[pid].device->name,\n \t\t\t\t da->name, strlen(da->name)) != 0) {\ndiff --git a/drivers/net/failsafe/failsafe_flow.c b/drivers/net/failsafe/failsafe_flow.c\nindex 707e6c63b5..5d17182cc5 100644\n--- a/drivers/net/failsafe/failsafe_flow.c\n+++ b/drivers/net/failsafe/failsafe_flow.c\n@@ -33,7 +33,7 @@ fs_flow_allocate(const struct rte_flow_attr *attr,\n \tif (ret < 0) {\n \t\tERROR(\"Unable to process flow rule (%s): %s\",\n \t\t error.message ? error.message : \"unspecified\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\treturn NULL;\n \t}\n \tflow = rte_zmalloc(NULL, offsetof(struct rte_flow, rule) + ret,\n@@ -47,7 +47,7 @@ fs_flow_allocate(const struct rte_flow_attr *attr,\n \tif (ret < 0) {\n \t\tERROR(\"Failed to copy flow rule (%s): %s\",\n \t\t error.message ? error.message : \"unspecified\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\trte_free(flow);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 35649b6244..40bea1d6bf 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -452,7 +452,7 @@ fs_rx_queue_setup(struct rte_eth_dev *dev,\n #ifdef RTE_EXEC_ENV_LINUX\n \trxq->event_fd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n \tif (rxq->event_fd < 0) {\n-\t\tERROR(\"Failed to create an eventfd: %s\", strerror(errno));\n+\t\tERROR(\"Failed to create an eventfd: %s\", rte_strerror(errno));\n \t\tfs_unlock(dev, 0);\n \t\treturn -errno;\n \t}\ndiff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 53a451c1b1..5961222400 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -410,14 +410,14 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \t\tret = pthread_mutex_trylock(&PRIV(dev)->hotplug_mutex);\n \t\tif (ret) {\n \t\t\tDEBUG(\"Hot-plug mutex lock trying failed(%s), will try\"\n-\t\t\t \" again later...\", strerror(ret));\n+\t\t\t \" again later...\", rte_strerror(ret));\n \t\t\treturn ret;\n \t\t}\n \t\tPRIV(dev)->alarm_lock = 1;\n \t} else {\n \t\tret = pthread_mutex_lock(&PRIV(dev)->hotplug_mutex);\n \t\tif (ret) {\n-\t\t\tERROR(\"Cannot lock mutex(%s)\", strerror(ret));\n+\t\t\tERROR(\"Cannot lock mutex(%s)\", rte_strerror(ret));\n \t\t\treturn ret;\n \t\t}\n \t}\n@@ -439,7 +439,7 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \t}\n \tret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex);\n \tif (ret)\n-\t\tERROR(\"Cannot unlock hot-plug mutex(%s)\", strerror(ret));\n+\t\tERROR(\"Cannot unlock hot-plug mutex(%s)\", rte_strerror(ret));\n }\n \n /*\n", "prefixes": [ "v2", "28/43" ] }