Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134344,
    "url": "http://patchwork.dpdk.org/api/patches/134344/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-24-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114123552.398072-24-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114123552.398072-24-huangdengdui@huawei.com",
    "date": "2023-11-14T12:35:33",
    "name": "[v3,23/42] net/bonding: use rte strerror",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "07acf9ac0f6996edefc622fb62d3ed766d5890fd",
    "submitter": {
        "id": 3066,
        "url": "http://patchwork.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-24-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 30293,
            "url": "http://patchwork.dpdk.org/api/series/30293/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30293",
            "date": "2023-11-14T12:35:13",
            "name": "replace strerror",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/30293/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/134344/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/134344/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E15B43329;\n\tTue, 14 Nov 2023 13:38:21 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5854F40ED2;\n\tTue, 14 Nov 2023 13:36:23 +0100 (CET)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id BBE7B402B0\n for <dev@dpdk.org>; Tue, 14 Nov 2023 13:35:57 +0100 (CET)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV5Kd3mF7zmXGm;\n Tue, 14 Nov 2023 20:32:37 +0800 (CST)",
            "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 20:35:56 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>",
        "Subject": "[PATCH v3 23/42] net/bonding: use rte strerror",
        "Date": "Tue, 14 Nov 2023 20:35:33 +0800",
        "Message-ID": "<20231114123552.398072-24-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20231114123552.398072-1-huangdengdui@huawei.com>",
        "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114123552.398072-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/bonding/bonding_testpmd.c   | 4 ++--\n drivers/net/bonding/rte_eth_bond_api.c  | 2 +-\n drivers/net/bonding/rte_eth_bond_flow.c | 4 ++--\n drivers/net/bonding/rte_eth_bond_pmd.c  | 6 +++---\n 4 files changed, 8 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/net/bonding/bonding_testpmd.c b/drivers/net/bonding/bonding_testpmd.c\nindex 8fcd6cadd0..111f9de0e7 100644\n--- a/drivers/net/bonding/bonding_testpmd.c\n+++ b/drivers/net/bonding/bonding_testpmd.c\n@@ -551,7 +551,7 @@ static void cmd_set_bond_mac_addr_parsed(void *parsed_result,\n \t/* check the return value and print it if is < 0 */\n \tif (ret < 0)\n \t\tfprintf(stderr, \"set_bond_mac_addr error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n }\n \n static cmdline_parse_token_string_t cmd_set_bond_mac_addr_set =\n@@ -604,7 +604,7 @@ static void cmd_set_bond_mon_period_parsed(void *parsed_result,\n \t/* check the return value and print it if is < 0 */\n \tif (ret < 0)\n \t\tfprintf(stderr, \"set_bond_mac_addr error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n }\n \n static cmdline_parse_token_string_t cmd_set_bond_mon_period_set =\ndiff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex 99e496556a..1d20d421bc 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -483,7 +483,7 @@ __eth_bond_member_add_lock_free(uint16_t bonding_port_id, uint16_t member_port_i\n \tif (ret != 0) {\n \t\tRTE_BOND_LOG(ERR,\n \t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n-\t\t\t__func__, member_port_id, strerror(-ret));\n+\t\t\t__func__, member_port_id, rte_strerror(-ret));\n \n \t\treturn ret;\n \t}\ndiff --git a/drivers/net/bonding/rte_eth_bond_flow.c b/drivers/net/bonding/rte_eth_bond_flow.c\nindex 71a91675f7..b7e966f393 100644\n--- a/drivers/net/bonding/rte_eth_bond_flow.c\n+++ b/drivers/net/bonding/rte_eth_bond_flow.c\n@@ -31,7 +31,7 @@ bond_flow_alloc(int numa_node, const struct rte_flow_attr *attr,\n \tif (ret < 0) {\n \t\tRTE_BOND_LOG(ERR, \"Unable to process flow rule (%s): %s\",\n \t\t\t     error.message ? error.message : \"unspecified\",\n-\t\t\t     strerror(rte_errno));\n+\t\t\t     rte_strerror(rte_errno));\n \t\treturn NULL;\n \t}\n \tflow = rte_zmalloc_socket(NULL, offsetof(struct rte_flow, rule) + ret,\n@@ -45,7 +45,7 @@ bond_flow_alloc(int numa_node, const struct rte_flow_attr *attr,\n \tif (ret < 0) {\n \t\tRTE_BOND_LOG(ERR, \"Failed to copy flow rule (%s): %s\",\n \t\t\t     error.message ? error.message : \"unspecified\",\n-\t\t\t     strerror(rte_errno));\n+\t\t\t     rte_strerror(rte_errno));\n \t\trte_free(flow);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex c40d18d128..fdf152a51a 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -192,7 +192,7 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,\n \tif (ret != 0) {\n \t\tRTE_BOND_LOG(ERR,\n \t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n-\t\t\t__func__, member_port, strerror(-ret));\n+\t\t\t__func__, member_port, rte_strerror(-ret));\n \n \t\treturn ret;\n \t}\n@@ -223,7 +223,7 @@ bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {\n \t\t\tRTE_BOND_LOG(ERR,\n \t\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n \t\t\t\t__func__, bond_dev->data->port_id,\n-\t\t\t\tstrerror(-ret));\n+\t\t\t\trte_strerror(-ret));\n \n \t\t\treturn ret;\n \t\t}\n@@ -2292,7 +2292,7 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\t\t\t\t\"%s: Error during getting device (port %u) info: %s\\n\",\n \t\t\t\t\t__func__,\n \t\t\t\t\tmember.port_id,\n-\t\t\t\t\tstrerror(-ret));\n+\t\t\t\t\trte_strerror(-ret));\n \n \t\t\t\treturn ret;\n \t\t\t}\n",
    "prefixes": [
        "v3",
        "23/42"
    ]
}