Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134355,
    "url": "http://patchwork.dpdk.org/api/patches/134355/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-29-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114123552.398072-29-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114123552.398072-29-huangdengdui@huawei.com",
    "date": "2023-11-14T12:35:38",
    "name": "[v3,28/42] net/i40e: use rte strerror",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "85ce29c15b67faab1e40ac6a5ee4b04f1ef8bd0b",
    "submitter": {
        "id": 3066,
        "url": "http://patchwork.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-29-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 30293,
            "url": "http://patchwork.dpdk.org/api/series/30293/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30293",
            "date": "2023-11-14T12:35:13",
            "name": "replace strerror",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/30293/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/134355/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/134355/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6509643329;\n\tTue, 14 Nov 2023 13:39:36 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 347EC41144;\n\tTue, 14 Nov 2023 13:36:35 +0100 (CET)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 7E398402E5\n for <dev@dpdk.org>; Tue, 14 Nov 2023 13:35:59 +0100 (CET)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV5Kf2464zmXGN;\n Tue, 14 Nov 2023 20:32:38 +0800 (CST)",
            "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 20:35:57 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>",
        "Subject": "[PATCH v3 28/42] net/i40e: use rte strerror",
        "Date": "Tue, 14 Nov 2023 20:35:38 +0800",
        "Message-ID": "<20231114123552.398072-29-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20231114123552.398072-1-huangdengdui@huawei.com>",
        "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114123552.398072-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/i40e/i40e_testpmd.c | 42 ++++++++++++++++-----------------\n 1 file changed, 21 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c\nindex b6ef5d6e42..d0995531bc 100644\n--- a/drivers/net/i40e/i40e_testpmd.c\n+++ b/drivers/net/i40e/i40e_testpmd.c\n@@ -53,7 +53,7 @@ cmd_queue_region_parsed(void *parsed_result,\n \t\tbreak;\n \tdefault:\n \t\tfprintf(stderr, \"queue region config error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \t}\n }\n \n@@ -148,7 +148,7 @@ cmd_region_flowtype_parsed(void *parsed_result,\n \t\tbreak;\n \tdefault:\n \t\tfprintf(stderr, \"region flowtype config error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \t}\n }\n \n@@ -233,7 +233,7 @@ cmd_user_priority_region_parsed(void *parsed_result,\n \t\tbreak;\n \tdefault:\n \t\tfprintf(stderr, \"user_priority region config error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \t}\n }\n \n@@ -320,7 +320,7 @@ cmd_flush_queue_region_parsed(void *parsed_result,\n \t\tbreak;\n \tdefault:\n \t\tfprintf(stderr, \"queue region config flush error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \t}\n }\n \n@@ -433,7 +433,7 @@ cmd_show_queue_region_info_parsed(void *parsed_result,\n \t\tbreak;\n \tdefault:\n \t\tfprintf(stderr, \"queue region config info show error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \t}\n }\n \n@@ -536,7 +536,7 @@ cmd_flow_director_filter_parsed(void *parsed_result,\n \t\t\t\t\t\t\tadd);\n \tif (ret < 0)\n \t\tfprintf(stderr, \"flow director config error: (%s)\\n\",\n-\t\t\tstrerror(-ret));\n+\t\t\trte_strerror(-ret));\n \tclose_file(conf.input.packet);\n }\n \n@@ -666,7 +666,7 @@ cmd_set_vf_promisc_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -745,7 +745,7 @@ cmd_set_vf_allmulti_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -825,7 +825,7 @@ cmd_set_vf_broadcast_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -908,7 +908,7 @@ cmd_set_vf_vlan_tag_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -1013,7 +1013,7 @@ cmd_vf_max_bw_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -1108,7 +1108,7 @@ cmd_vf_tc_min_bw_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -1158,7 +1158,7 @@ cmd_vf_tc_max_bw_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -1207,7 +1207,7 @@ cmd_strict_link_prio_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -1928,7 +1928,7 @@ cmd_pctype_mapping_reset_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -2000,7 +2000,7 @@ cmd_pctype_mapping_get_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\treturn;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t\treturn;\n \t}\n \n@@ -2111,7 +2111,7 @@ cmd_pctype_mapping_update_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -2191,7 +2191,7 @@ cmd_ptype_mapping_get_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n \n \tif (!ret) {\n@@ -2280,7 +2280,7 @@ cmd_ptype_mapping_replace_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -2347,7 +2347,7 @@ cmd_ptype_mapping_reset_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n@@ -2427,7 +2427,7 @@ cmd_ptype_mapping_update_parsed(void *parsed_result,\n \t\tfprintf(stderr, \"function not implemented\\n\");\n \t\tbreak;\n \tdefault:\n-\t\tfprintf(stderr, \"programming error: (%s)\\n\", strerror(-ret));\n+\t\tfprintf(stderr, \"programming error: (%s)\\n\", rte_strerror(-ret));\n \t}\n }\n \n",
    "prefixes": [
        "v3",
        "28/42"
    ]
}