Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134359/?format=api
{ "id": 134359, "url": "http://patchwork.dpdk.org/api/patches/134359/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-33-huangdengdui@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114123552.398072-33-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114123552.398072-33-huangdengdui@huawei.com", "date": "2023-11-14T12:35:42", "name": "[v3,32/42] net/mlx4: use rte strerror", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "104051fc63354f42ceaf329f098fee7657bce67b", "submitter": { "id": 3066, "url": "http://patchwork.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-33-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30293, "url": "http://patchwork.dpdk.org/api/series/30293/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30293", "date": "2023-11-14T12:35:13", "name": "replace strerror", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30293/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134359/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134359/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03DE643329;\n\tTue, 14 Nov 2023 13:40:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 789D0427D9;\n\tTue, 14 Nov 2023 13:36:39 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 21E1A40647\n for <dev@dpdk.org>; Tue, 14 Nov 2023 13:36:00 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.54])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SV5JC0nc4zMmx5;\n Tue, 14 Nov 2023 20:31:23 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 20:35:57 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH v3 32/42] net/mlx4: use rte strerror", "Date": "Tue, 14 Nov 2023 20:35:42 +0800", "Message-ID": "<20231114123552.398072-33-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114123552.398072-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114123552.398072-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/mlx4/mlx4.c | 14 +++++++-------\n drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++---------\n drivers/net/mlx4/mlx4_rxq.c | 10 +++++-----\n drivers/net/mlx4/mlx4_txq.c | 10 +++++-----\n 4 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex a1a7e93288..f06a6fee6e 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -255,7 +255,7 @@ mlx4_dev_configure(struct rte_eth_dev *dev)\n \tif (ret) {\n \t\tERROR(\"cannot set up internal flow rules (code %d, \\\"%s\\\"),\"\n \t\t \" flow error type %d, cause %p, message: %s\",\n-\t\t -ret, strerror(-ret), error.type, error.cause,\n+\t\t -ret, rte_strerror(-ret), error.type, error.cause,\n \t\t error.message ? error.message : \"(unspecified)\");\n \t\tgoto exit;\n \t}\n@@ -302,7 +302,7 @@ mlx4_dev_start(struct rte_eth_dev *dev)\n \tret = mlx4_rss_init(priv);\n \tif (ret) {\n \t\tERROR(\"%p: cannot initialize RSS resources: %s\",\n-\t\t (void *)dev, strerror(-ret));\n+\t\t (void *)dev, rte_strerror(-ret));\n \t\tgoto err;\n \t}\n #ifdef RTE_LIBRTE_MLX4_DEBUG\n@@ -319,7 +319,7 @@ mlx4_dev_start(struct rte_eth_dev *dev)\n \t\tERROR(\"%p: cannot attach flow rules (code %d, \\\"%s\\\"),\"\n \t\t \" flow error type %d, cause %p, message: %s\",\n \t\t (void *)dev,\n-\t\t -ret, strerror(-ret), error.type, error.cause,\n+\t\t -ret, rte_strerror(-ret), error.type, error.cause,\n \t\t error.message ? error.message : \"(unspecified)\");\n \t\tgoto err;\n \t}\n@@ -793,7 +793,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \terr = mlx4_init_once();\n \tif (err) {\n \t\tERROR(\"unable to init PMD global data: %s\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\treturn -rte_errno;\n \t}\n \tMLX4_ASSERT(pci_drv == &mlx4_driver);\n@@ -946,7 +946,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\terr = mlx4_glue->query_port(ctx, port, &port_attr);\n \t\tif (err) {\n \t\t\terr = ENODEV;\n-\t\t\tERROR(\"port query failed: %s\", strerror(err));\n+\t\t\tERROR(\"port query failed: %s\", rte_strerror(err));\n \t\t\tgoto port_error;\n \t\t}\n \t\tif (port_attr.link_layer != IBV_LINK_LAYER_ETHERNET) {\n@@ -963,7 +963,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\terr = mlx4_fd_set_non_blocking(ctx->async_fd);\n \t\tif (err) {\n \t\t\tERROR(\"cannot make asynchronous FD non-blocking: %s\",\n-\t\t\t strerror(err));\n+\t\t\t rte_strerror(err));\n \t\t\tgoto port_error;\n \t\t}\n \t\t/* Allocate protection domain. */\n@@ -1024,7 +1024,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\terr = mlx4_get_mac(priv, &mac.addr_bytes);\n \t\tif (err) {\n \t\t\tERROR(\"cannot get MAC address, is mlx4_en loaded?\"\n-\t\t\t \" (error: %s)\", strerror(err));\n+\t\t\t \" (error: %s)\", rte_strerror(err));\n \t\t\tgoto port_error;\n \t\t}\n \t\tINFO(\"port %u MAC address is \" RTE_ETHER_ADDR_PRT_FMT,\ndiff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c\nindex bb1dd33e7c..a1cd345aae 100644\n--- a/drivers/net/mlx4/mlx4_ethdev.c\n+++ b/drivers/net/mlx4/mlx4_ethdev.c\n@@ -373,7 +373,7 @@ mlx4_rxmode_toggle(struct rte_eth_dev *dev, enum rxmode_toggle toggle)\n \n \tERROR(\"cannot toggle %s mode (code %d, \\\"%s\\\"),\"\n \t \" flow error type %d, cause %p, message: %s\",\n-\t mode, rte_errno, strerror(rte_errno), error.type, error.cause,\n+\t mode, rte_errno, rte_strerror(rte_errno), error.type, error.cause,\n \t error.message ? error.message : \"(unspecified)\");\n \treturn ret;\n }\n@@ -462,7 +462,7 @@ mlx4_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)\n \tERROR(\"failed to synchronize flow rules after removing MAC address\"\n \t \" at index %d (code %d, \\\"%s\\\"),\"\n \t \" flow error type %d, cause %p, message: %s\",\n-\t index, rte_errno, strerror(rte_errno), error.type, error.cause,\n+\t index, rte_errno, rte_strerror(rte_errno), error.type, error.cause,\n \t error.message ? error.message : \"(unspecified)\");\n }\n \n@@ -501,7 +501,7 @@ mlx4_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n \tERROR(\"failed to synchronize flow rules after adding MAC address\"\n \t \" at index %d (code %d, \\\"%s\\\"),\"\n \t \" flow error type %d, cause %p, message: %s\",\n-\t index, rte_errno, strerror(rte_errno), error.type, error.cause,\n+\t index, rte_errno, rte_strerror(rte_errno), error.type, error.cause,\n \t error.message ? error.message : \"(unspecified)\");\n \treturn ret;\n }\n@@ -558,7 +558,7 @@ mlx4_set_mc_addr_list(struct rte_eth_dev *dev, struct rte_ether_addr *list,\n \t\treturn 0;\n \tERROR(\"failed to synchronize flow rules after modifying MC list,\"\n \t \" (code %d, \\\"%s\\\"), flow error type %d, cause %p, message: %s\",\n-\t rte_errno, strerror(rte_errno), error.type, error.cause,\n+\t rte_errno, rte_strerror(rte_errno), error.type, error.cause,\n \t error.message ? error.message : \"(unspecified)\");\n \treturn ret;\n }\n@@ -600,7 +600,7 @@ mlx4_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n \t \" (code %d, \\\"%s\\\"), \"\n \t \" flow error type %d, cause %p, message: %s\",\n \t on ? \"enabling\" : \"disabling\", vlan_id,\n-\t rte_errno, strerror(rte_errno), error.type, error.cause,\n+\t rte_errno, rte_strerror(rte_errno), error.type, error.cause,\n \t error.message ? error.message : \"(unspecified)\");\n \treturn ret;\n }\n@@ -807,7 +807,7 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \t}\n \t(void)wait_to_complete;\n \tif (mlx4_ifreq(priv, SIOCGIFFLAGS, &ifr)) {\n-\t\tWARN(\"ioctl(SIOCGIFFLAGS) failed: %s\", strerror(rte_errno));\n+\t\tWARN(\"ioctl(SIOCGIFFLAGS) failed: %s\", rte_strerror(rte_errno));\n \t\treturn -rte_errno;\n \t}\n \tmemset(&dev_link, 0, sizeof(dev_link));\n@@ -816,7 +816,7 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \tifr.ifr_data = (void *)&edata;\n \tif (mlx4_ifreq(priv, SIOCETHTOOL, &ifr)) {\n \t\tWARN(\"ioctl(SIOCETHTOOL, ETHTOOL_GSET) failed: %s\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\treturn -rte_errno;\n \t}\n \tlink_speed = ethtool_cmd_speed(&edata);\n@@ -858,7 +858,7 @@ mlx4_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \t\tret = rte_errno;\n \t\tWARN(\"ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM)\"\n \t\t \" failed: %s\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\tgoto out;\n \t}\n \tfc_conf->autoneg = ethpause.autoneg;\n@@ -913,7 +913,7 @@ mlx4_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n \t\tret = rte_errno;\n \t\tWARN(\"ioctl(SIOCETHTOOL, ETHTOOL_SPAUSEPARAM)\"\n \t\t \" failed: %s\",\n-\t\t strerror(rte_errno));\n+\t\t rte_strerror(rte_errno));\n \t\tgoto out;\n \t}\n \tret = 0;\ndiff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c\nindex 781ee256df..d0ec84201e 100644\n--- a/drivers/net/mlx4/mlx4_rxq.c\n+++ b/drivers/net/mlx4/mlx4_rxq.c\n@@ -353,7 +353,7 @@ mlx4_rss_init(struct mlx4_priv *priv)\n \tif (ret) {\n \t\tERROR(\"cannot set up range size for RSS context to %u\"\n \t\t \" (for %u Rx queues), error: %s\",\n-\t\t 1 << log2_range, dev->data->nb_rx_queues, strerror(ret));\n+\t\t 1 << log2_range, dev->data->nb_rx_queues, rte_strerror(ret));\n \t\trte_errno = ret;\n \t\treturn -ret;\n \t}\n@@ -431,7 +431,7 @@ mlx4_rss_init(struct mlx4_priv *priv)\n \treturn 0;\n error:\n \tERROR(\"cannot initialize common RSS resources (queue %u): %s: %s\",\n-\t i, msg, strerror(ret));\n+\t i, msg, rte_strerror(ret));\n \twhile (i--) {\n \t\tstruct rxq *rxq = ETH_DEV(priv)->data->rx_queues[i];\n \n@@ -631,7 +631,7 @@ mlx4_rxq_attach(struct rxq *rxq)\n \t--rxq->usecnt;\n \trte_errno = ret;\n \tERROR(\"error while attaching Rx queue %p: %s: %s\",\n-\t (void *)rxq, msg, strerror(ret));\n+\t (void *)rxq, msg, rte_strerror(ret));\n \tpriv->verbs_alloc_ctx.type = MLX4_VERBS_ALLOC_TYPE_NONE;\n \treturn -ret;\n }\n@@ -882,13 +882,13 @@ mlx4_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \t\t\trte_errno = ENOMEM;\n \t\t\tERROR(\"%p: Rx interrupt completion channel creation\"\n \t\t\t \" failure: %s\",\n-\t\t\t (void *)dev, strerror(rte_errno));\n+\t\t\t (void *)dev, rte_strerror(rte_errno));\n \t\t\tgoto error;\n \t\t}\n \t\tif (mlx4_fd_set_non_blocking(rxq->channel->fd) < 0) {\n \t\t\tERROR(\"%p: unable to make Rx interrupt completion\"\n \t\t\t \" channel non-blocking: %s\",\n-\t\t\t (void *)dev, strerror(rte_errno));\n+\t\t\t (void *)dev, rte_strerror(rte_errno));\n \t\t\tgoto error;\n \t\t}\n \t}\ndiff --git a/drivers/net/mlx4/mlx4_txq.c b/drivers/net/mlx4/mlx4_txq.c\nindex 0db2e55bef..f08c152d5e 100644\n--- a/drivers/net/mlx4/mlx4_txq.c\n+++ b/drivers/net/mlx4/mlx4_txq.c\n@@ -411,7 +411,7 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \tif (!txq->cq) {\n \t\trte_errno = ENOMEM;\n \t\tERROR(\"%p: CQ creation failure: %s\",\n-\t\t (void *)dev, strerror(rte_errno));\n+\t\t (void *)dev, rte_strerror(rte_errno));\n \t\tgoto error;\n \t}\n \tqp_init_attr = (struct ibv_qp_init_attr){\n@@ -431,7 +431,7 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \tif (!txq->qp) {\n \t\trte_errno = errno ? errno : EINVAL;\n \t\tERROR(\"%p: QP creation failure: %s\",\n-\t\t (void *)dev, strerror(rte_errno));\n+\t\t (void *)dev, rte_strerror(rte_errno));\n \t\tgoto error;\n \t}\n \ttxq->max_inline = qp_init_attr.cap.max_inline_data;\n@@ -445,7 +445,7 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \tif (ret) {\n \t\trte_errno = ret;\n \t\tERROR(\"%p: QP state to IBV_QPS_INIT failed: %s\",\n-\t\t (void *)dev, strerror(rte_errno));\n+\t\t (void *)dev, rte_strerror(rte_errno));\n \t\tgoto error;\n \t}\n \tret = mlx4_glue->modify_qp\n@@ -457,7 +457,7 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \tif (ret) {\n \t\trte_errno = ret;\n \t\tERROR(\"%p: QP state to IBV_QPS_RTR failed: %s\",\n-\t\t (void *)dev, strerror(rte_errno));\n+\t\t (void *)dev, rte_strerror(rte_errno));\n \t\tgoto error;\n \t}\n \tret = mlx4_glue->modify_qp\n@@ -469,7 +469,7 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,\n \tif (ret) {\n \t\trte_errno = ret;\n \t\tERROR(\"%p: QP state to IBV_QPS_RTS failed: %s\",\n-\t\t (void *)dev, strerror(rte_errno));\n+\t\t (void *)dev, rte_strerror(rte_errno));\n \t\tgoto error;\n \t}\n \t/* Retrieve device queue information. */\n", "prefixes": [ "v3", "32/42" ] }