Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134362,
    "url": "http://patchwork.dpdk.org/api/patches/134362/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-41-huangdengdui@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231114123552.398072-41-huangdengdui@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231114123552.398072-41-huangdengdui@huawei.com",
    "date": "2023-11-14T12:35:50",
    "name": "[v3,40/42] vdpa/ifc: use rte strerror",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "17607df9c24563fb96bceee45416c9bcffa446f4",
    "submitter": {
        "id": 3066,
        "url": "http://patchwork.dpdk.org/api/people/3066/?format=api",
        "name": "huangdengdui",
        "email": "huangdengdui@huawei.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231114123552.398072-41-huangdengdui@huawei.com/mbox/",
    "series": [
        {
            "id": 30293,
            "url": "http://patchwork.dpdk.org/api/series/30293/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30293",
            "date": "2023-11-14T12:35:13",
            "name": "replace strerror",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/30293/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/134362/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/134362/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49EFC43329;\n\tTue, 14 Nov 2023 13:40:21 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D0C494281D;\n\tTue, 14 Nov 2023 13:36:42 +0100 (CET)",
            "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id BEF0F402EE\n for <dev@dpdk.org>; Tue, 14 Nov 2023 13:35:59 +0100 (CET)",
            "from dggpeml500011.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SV5Kh0DZpzmXDl;\n Tue, 14 Nov 2023 20:32:40 +0800 (CST)",
            "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 20:35:59 +0800"
        ],
        "From": "Dengdui Huang <huangdengdui@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>",
        "Subject": "[PATCH v3 40/42] vdpa/ifc: use rte strerror",
        "Date": "Tue, 14 Nov 2023 20:35:50 +0800",
        "Message-ID": "<20231114123552.398072-41-huangdengdui@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20231114123552.398072-1-huangdengdui@huawei.com>",
        "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114123552.398072-1-huangdengdui@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500011.china.huawei.com (7.185.36.84)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/vdpa/ifc/ifcvf_vdpa.c | 23 ++++++++++++-----------\n 1 file changed, 12 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c\nindex f034bd59ba..34ea450d00 100644\n--- a/drivers/vdpa/ifc/ifcvf_vdpa.c\n+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c\n@@ -23,6 +23,7 @@\n #include <rte_log.h>\n #include <rte_kvargs.h>\n #include <rte_devargs.h>\n+#include <rte_errno.h>\n \n #include \"base/ifcvf.h\"\n \n@@ -446,7 +447,7 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool m_rx)\n \t\t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n \t\t\tif (fd < 0) {\n \t\t\t\tDRV_LOG(ERR, \"can't setup eventfd: %s\",\n-\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\trte_strerror(errno));\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t\tinternal->intr_fd[i] = fd;\n@@ -457,7 +458,7 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool m_rx)\n \tret = ioctl(internal->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Error enabling MSI-X interrupts: %s\",\n-\t\t\t\tstrerror(errno));\n+\t\t\t\trte_strerror(errno));\n \t\treturn -1;\n \t}\n \n@@ -489,7 +490,7 @@ vdpa_disable_vfio_intr(struct ifcvf_internal *internal)\n \tret = ioctl(internal->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Error disabling MSI-X interrupts: %s\",\n-\t\t\t\tstrerror(errno));\n+\t\t\t\trte_strerror(errno));\n \t\treturn -1;\n \t}\n \n@@ -526,7 +527,7 @@ notify_relay(void *arg)\n \t\trte_vhost_get_vhost_vring(internal->vid, qid, &vring);\n \t\tev.data.u64 = qid | (uint64_t)vring.kickfd << 32;\n \t\tif (epoll_ctl(epfd, EPOLL_CTL_ADD, vring.kickfd, &ev) < 0) {\n-\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", strerror(errno));\n+\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", rte_strerror(errno));\n \t\t\treturn 1;\n \t\t}\n \t}\n@@ -552,7 +553,7 @@ notify_relay(void *arg)\n \t\t\t\t\t\tcontinue;\n \t\t\t\t\tDRV_LOG(INFO, \"Error reading \"\n \t\t\t\t\t\t\"kickfd: %s\",\n-\t\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\t\trte_strerror(errno));\n \t\t\t\t}\n \t\t\t\tbreak;\n \t\t\t} while (1);\n@@ -628,7 +629,7 @@ intr_relay(void *arg)\n \tev.data.fd = rte_intr_fd_get(internal->pdev->intr_handle);\n \tif (epoll_ctl(csc_epfd, EPOLL_CTL_ADD,\n \t\trte_intr_fd_get(internal->pdev->intr_handle), &ev) < 0) {\n-\t\tDRV_LOG(ERR, \"epoll add error: %s\", strerror(errno));\n+\t\tDRV_LOG(ERR, \"epoll add error: %s\", rte_strerror(errno));\n \t\tgoto out;\n \t}\n \n@@ -653,7 +654,7 @@ intr_relay(void *arg)\n \t\t\t\t\tcontinue;\n \t\t\t\tDRV_LOG(ERR, \"Error reading from file descriptor %d: %s\\n\",\n \t\t\t\t\tcsc_event.data.fd,\n-\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\trte_strerror(errno));\n \t\t\t\tgoto out;\n \t\t\t} else if (nbytes == 0) {\n \t\t\t\tDRV_LOG(ERR, \"Read nothing from file descriptor %d\\n\",\n@@ -947,7 +948,7 @@ vring_relay(void *arg)\n \t\trte_vhost_get_vhost_vring(vid, qid, &vring);\n \t\tev.data.u64 = qid << 1 | (uint64_t)vring.kickfd << 32;\n \t\tif (epoll_ctl(epfd, EPOLL_CTL_ADD, vring.kickfd, &ev) < 0) {\n-\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", strerror(errno));\n+\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", rte_strerror(errno));\n \t\t\treturn 1;\n \t\t}\n \t}\n@@ -961,7 +962,7 @@ vring_relay(void *arg)\n \t\t\t(uint64_t)internal->intr_fd[qid] << 32;\n \t\tif (epoll_ctl(epfd, EPOLL_CTL_ADD, internal->intr_fd[qid], &ev)\n \t\t\t\t< 0) {\n-\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", strerror(errno));\n+\t\t\tDRV_LOG(ERR, \"epoll add error: %s\", rte_strerror(errno));\n \t\t\treturn 1;\n \t\t}\n \t\tupdate_used_ring(internal, qid);\n@@ -992,7 +993,7 @@ vring_relay(void *arg)\n \t\t\t\t\t\tcontinue;\n \t\t\t\t\tDRV_LOG(INFO, \"Error reading \"\n \t\t\t\t\t\t\"kickfd: %s\",\n-\t\t\t\t\t\tstrerror(errno));\n+\t\t\t\t\t\trte_strerror(errno));\n \t\t\t\t}\n \t\t\t\tbreak;\n \t\t\t} while (1);\n@@ -1265,7 +1266,7 @@ ifcvf_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size)\n \tret = ioctl(internal->vfio_dev_fd, VFIO_DEVICE_GET_REGION_INFO, &reg);\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Get not get device region info: %s\",\n-\t\t\t\tstrerror(errno));\n+\t\t\t\trte_strerror(errno));\n \t\treturn -1;\n \t}\n \n",
    "prefixes": [
        "v3",
        "40/42"
    ]
}