Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134846/?format=api
{ "id": 134846, "url": "http://patchwork.dpdk.org/api/patches/134846/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231205021330.260017-19-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231205021330.260017-19-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231205021330.260017-19-stephen@networkplumber.org", "date": "2023-12-05T02:09:56", "name": "[18/18] hash: convert RTE_LOGTYPE_HASH to dynamic type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6179503417c9b0514c94f4be30d68775fd8ad4e1", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231205021330.260017-19-stephen@networkplumber.org/mbox/", "series": [ { "id": 30446, "url": "http://patchwork.dpdk.org/api/series/30446/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30446", "date": "2023-12-05T02:09:38", "name": "Convert static log types in libraries to dynamic", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30446/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134846/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134846/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86F52433FD;\n\tTue, 5 Dec 2023 03:15:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 94D9D42E07;\n\tTue, 5 Dec 2023 03:14:12 +0100 (CET)", "from mail-oi1-f171.google.com (mail-oi1-f171.google.com\n [209.85.167.171])\n by mails.dpdk.org (Postfix) with ESMTP id 9052242DE3\n for <dev@dpdk.org>; Tue, 5 Dec 2023 03:14:04 +0100 (CET)", "by mail-oi1-f171.google.com with SMTP id\n 5614622812f47-3b844357f7cso2868088b6e.1\n for <dev@dpdk.org>; Mon, 04 Dec 2023 18:14:04 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n p26-20020a62b81a000000b0069346777241sm355958pfe.97.2023.12.04.18.14.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Dec 2023 18:14:03 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701742444;\n x=1702347244; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6yatbEXbk8JjdL02Xj5MmzSrD11/Ce5jY3XPRMVXuGc=;\n b=PyGmQl3MGn72eZHsXneKnDzm1SdRrbzHDnLVRcjQOoLjjjoHQ+302VM/J3ODxJzG3P\n J7r2ptWsgFcKM5CZZ4Gh+09ZwjCD/KuEGVPMDZ56qnUibOjmmugwvZ0vTXwpZVFGRywJ\n A5tTjivxnYyjABHbWNy/2dgCHx8J3r/PxMdDw4DHJQmHu3/Hfeb7C0nj690widbuZeDg\n lJD2r4P6vTgMvZNZ00vVBC6grd/VZ3cS3rXQOY3QkM5DsgBKAMwibsmZ3zeU8PPpTv0v\n 6ALcPkNShmaIuQW5VOG0HHcrIIKTPXHjdU6vRxG7+bzRETOLUtmmTtQHCKGQ+NVlz5xp\n 1IFw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701742444; x=1702347244;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=6yatbEXbk8JjdL02Xj5MmzSrD11/Ce5jY3XPRMVXuGc=;\n b=R3rTWX3wTyxsM8I2scEu9GuVE4tPeasC2UpvRkMIQtpUweyGR9jcSstTum5+iwHpFb\n r5sEYm1sDvbgHUICDO5QK0OQdXGMIOAZlOJLe9W01lzzymxvnRcZYngHUjr2GxXLxn+q\n gaVqpGWPRgqlEOxwGXgNSlQEPu+Pu8klvbUQqxXwuwkhoKJ/uM0Byv7K9xzkvNw+IHxu\n /BlIq5t0CheCLB+hhRMPwtxq3FasVAt7s1vi/yx6KjGqW44HdEvzEFyvic//4M08+vXw\n OKhiRhhz7au1m6TtQc4nmZsDC2DTnPBi6itvWg9lGNIRdhMdzVHb05mpho9JmqBBHWl4\n wI9A==", "X-Gm-Message-State": "AOJu0Yy8EMhzoXGMfuPkU1227/qX5a7q9iOHl10+GGv5HDXtxdF808Hc\n zgmP7l8r1kkHC4ggv5NyUc3mBDVAMUeUzEw6WKs=", "X-Google-Smtp-Source": "\n AGHT+IHhlsqb9zm0gY+hoDNPVnkDWslWuGCLQtGkzvNgjUipnjjeYXm4M6iJX/j/cR757pgwYS54Yw==", "X-Received": "by 2002:a05:6808:118a:b0:3b8:b063:6bb4 with SMTP id\n j10-20020a056808118a00b003b8b0636bb4mr6206359oil.99.1701742444007;\n Mon, 04 Dec 2023 18:14:04 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH 18/18] hash: convert RTE_LOGTYPE_HASH to dynamic type", "Date": "Mon, 4 Dec 2023 18:09:56 -0800", "Message-ID": "<20231205021330.260017-19-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231205021330.260017-1-stephen@networkplumber.org>", "References": "<20230329234049.11071-1-stephen@networkplumber.org>\n <20231205021330.260017-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use dynamic type for hash and add subtypes for crc and gfni.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/hash/rte_cuckoo_hash.c | 5 +++++\n lib/hash/rte_fbk_hash.c | 5 +++++\n lib/hash/rte_thash.c | 3 +++\n lib/hash/rte_thash_gfni.c | 3 +++\n lib/log/log.c | 1 -\n lib/log/rte_log.h | 2 +-\n 6 files changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex ccdc3b989489..8e4364f060a3 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -24,6 +24,11 @@\n #include <rte_tailq.h>\n \n #include \"rte_hash.h\"\n+\n+/* needs to be before rte_cuckoo_hash.h */\n+RTE_LOG_REGISTER_DEFAULT(hash_logtype, INFO);\n+#define RTE_LOGTYPE_HASH hash_logtype\n+\n #include \"rte_cuckoo_hash.h\"\n \n /* Mask of all flags supported by this version */\ndiff --git a/lib/hash/rte_fbk_hash.c b/lib/hash/rte_fbk_hash.c\nindex 538b23a4030a..b4c4c191abdc 100644\n--- a/lib/hash/rte_fbk_hash.c\n+++ b/lib/hash/rte_fbk_hash.c\n@@ -8,6 +8,8 @@\n #include <errno.h>\n \n #include <sys/queue.h>\n+\n+#include <rte_cpuflags.h>\n #include <rte_eal_memconfig.h>\n #include <rte_malloc.h>\n #include <rte_common.h>\n@@ -18,6 +20,9 @@\n \n #include \"rte_fbk_hash.h\"\n \n+RTE_LOG_REGISTER_SUFFIX(fbk_hash_logtype, fbk, INFO);\n+#define RTE_LOGTYPE_HASH fbk_hash_logtype\n+\n TAILQ_HEAD(rte_fbk_hash_list, rte_tailq_entry);\n \n static struct rte_tailq_elem rte_fbk_hash_tailq = {\ndiff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c\nindex 4ff567ee5adf..d819dddd84f4 100644\n--- a/lib/hash/rte_thash.c\n+++ b/lib/hash/rte_thash.c\n@@ -13,6 +13,9 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n \n+RTE_LOG_REGISTER_SUFFIX(thash_logtype, thash, INFO);\n+#define RTE_LOGTYPE_HASH thash_logtype\n+\n #define THASH_NAME_LEN\t\t64\n #define TOEPLITZ_HASH_LEN\t32\n \ndiff --git a/lib/hash/rte_thash_gfni.c b/lib/hash/rte_thash_gfni.c\nindex eb334185725c..35206d575153 100644\n--- a/lib/hash/rte_thash_gfni.c\n+++ b/lib/hash/rte_thash_gfni.c\n@@ -10,6 +10,9 @@\n \n #ifndef RTE_THASH_GFNI_DEFINED\n \n+RTE_LOG_REGISTER_SUFFIX(hash_gfni_logtype, gfni, INFO);\n+#define RTE_LOGTYPE_HASH hash_gfni_logtype\n+\n uint32_t\n rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n \t const uint8_t *key __rte_unused, int len __rte_unused)\ndiff --git a/lib/log/log.c b/lib/log/log.c\nindex 56877d42e6b9..e3cd4cff0fbc 100644\n--- a/lib/log/log.c\n+++ b/lib/log/log.c\n@@ -353,7 +353,6 @@ struct logtype {\n static const struct logtype logtype_strings[] = {\n \t{RTE_LOGTYPE_EAL, \"lib.eal\"},\n \t{RTE_LOGTYPE_PMD, \"pmd\"},\n-\t{RTE_LOGTYPE_HASH, \"lib.hash\"},\n \t{RTE_LOGTYPE_PORT, \"lib.port\"},\n \t{RTE_LOGTYPE_TABLE, \"lib.table\"},\n \t{RTE_LOGTYPE_PIPELINE, \"lib.pipeline\"},\ndiff --git a/lib/log/rte_log.h b/lib/log/rte_log.h\nindex 189ad2bbd2cf..27fb6129a7aa 100644\n--- a/lib/log/rte_log.h\n+++ b/lib/log/rte_log.h\n@@ -32,7 +32,7 @@ extern \"C\" {\n \t\t\t\t /* was RTE_LOGTYPE_MEMPOOL */\n \t\t\t\t /* was RTE_LOGTYPE_TIMER */\n #define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. */\n-#define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */\n+\t\t\t\t /* was RTE_LOGTYPE_HASH */\n \t\t\t\t /* was RTE_LOGTYPE_LPM */\n \t\t\t\t /* was RTE_LOGTYPE_KNI */\n \t\t\t\t /* was RTE_LOGTYPE_ACL */\n", "prefixes": [ "18/18" ] }