Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134935/?format=api
{ "id": 134935, "url": "http://patchwork.dpdk.org/api/patches/134935/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231207161818.2590661-8-euan.bourke@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231207161818.2590661-8-euan.bourke@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231207161818.2590661-8-euan.bourke@intel.com", "date": "2023-12-07T16:18:17", "name": "[v3,7/8] examples/eventdev_pipeline: update to call arg parser API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a1ac064068532a00744e128e51058f239cbbdae7", "submitter": { "id": 3231, "url": "http://patchwork.dpdk.org/api/people/3231/?format=api", "name": "Euan Bourke", "email": "euan.bourke@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231207161818.2590661-8-euan.bourke@intel.com/mbox/", "series": [ { "id": 30478, "url": "http://patchwork.dpdk.org/api/series/30478/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30478", "date": "2023-12-07T16:18:10", "name": "add new command line argument parsing library", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30478/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134935/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/134935/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DDF2E4369D;\n\tThu, 7 Dec 2023 17:19:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4962042F73;\n\tThu, 7 Dec 2023 17:18:48 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id CBF2342F4F\n for <dev@dpdk.org>; Thu, 7 Dec 2023 17:18:45 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Dec 2023 08:18:45 -0800", "from unknown (HELO silpixa00400630.ir.intel.com) ([10.237.213.151])\n by orsmga007.jf.intel.com with ESMTP; 07 Dec 2023 08:18:44 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1701965926; x=1733501926;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ntTCL7ZgxcrHmd3eNMTw872VD78V+HYFJAaokwfMgTE=;\n b=EWBSAqD86LwAxYRJsHXkVZbULV7z+h5qSBhk3A0BXellwFdl5WeZhJ1w\n FvMjZKIm1I0Xce6rjRxzptF15b+V8DTePypkSfTLsuqM0EHezzvX5GYFn\n Bngqw5GXrwa9/GiV6GrFe9bWT8y+DxFacwrq8YwEjeYynoOpNvzTDMm8w\n BE73UxfcfFsLo8oaKMajTfQhuSwXZHSyhNJO4S0IjnPb8ExpzRmhbKosy\n eNw+4JCuT5rRRaNuxKKcFfHowCtP780d7B0ZDLfwEpTOkmw7W9WIR1UDV\n UeEVUp8SBILtAeMNObszTR1UzpefU1jP4aYBsd36w7BSev0z9OArC2Dde A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10917\"; a=\"397048630\"", "E=Sophos;i=\"6.04,256,1695711600\"; d=\"scan'208\";a=\"397048630\"", "E=McAfee;i=\"6600,9927,10917\"; a=\"765153987\"", "E=Sophos;i=\"6.04,256,1695711600\"; d=\"scan'208\";a=\"765153987\"" ], "X-ExtLoop1": "1", "From": "Euan Bourke <euan.bourke@intel.com>", "To": "dev@dpdk.org", "Cc": "Euan Bourke <euan.bourke@intel.com>,\n Harry van Haaren <harry.van.haaren@intel.com>", "Subject": "[PATCH v3 7/8] examples/eventdev_pipeline: update to call arg parser\n API", "Date": "Thu, 7 Dec 2023 16:18:17 +0000", "Message-Id": "<20231207161818.2590661-8-euan.bourke@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231207161818.2590661-1-euan.bourke@intel.com>", "References": "<20231207161818.2590661-1-euan.bourke@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update to the eventdev_pipeline example application to call the arg parser\nlibrary for its 'combined core string parser' instead of implementing its\nown coremask parser. The default_type passed into the function call is\na coremask.\n\nSigned-off-by: Euan Bourke <euan.bourke@intel.com>\n---\n examples/eventdev_pipeline/main.c | 65 +++-----------------\n examples/eventdev_pipeline/pipeline_common.h | 1 +\n 2 files changed, 10 insertions(+), 56 deletions(-)", "diff": "diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c\nindex 0c995d1a70..c59d01e7a5 100644\n--- a/examples/eventdev_pipeline/main.c\n+++ b/examples/eventdev_pipeline/main.c\n@@ -56,69 +56,22 @@ core_in_use(unsigned int lcore_id) {\n \t\tfdata->tx_core[lcore_id] || fdata->worker_core[lcore_id]);\n }\n \n-/*\n- * Parse the coremask given as argument (hexadecimal string) and fill\n- * the global configuration (core role and core count) with the parsed\n- * value.\n- */\n-static int xdigit2val(unsigned char c)\n-{\n-\tint val;\n-\n-\tif (isdigit(c))\n-\t\tval = c - '0';\n-\telse if (isupper(c))\n-\t\tval = c - 'A' + 10;\n-\telse\n-\t\tval = c - 'a' + 10;\n-\treturn val;\n-}\n-\n static uint64_t\n parse_coremask(const char *coremask)\n {\n-\tint i, j, idx = 0;\n-\tunsigned int count = 0;\n-\tchar c;\n-\tint val;\n+\tint count;\n+\tuint16_t i;\n \tuint64_t mask = 0;\n-\tconst int32_t BITS_HEX = 4;\n+\tuint16_t cores[RTE_MAX_LCORE];\n \n-\tif (coremask == NULL)\n-\t\treturn -1;\n-\t/* Remove all blank characters ahead and after .\n-\t * Remove 0x/0X if exists.\n-\t */\n-\twhile (isblank(*coremask))\n-\t\tcoremask++;\n-\tif (coremask[0] == '0' && ((coremask[1] == 'x')\n-\t\t|| (coremask[1] == 'X')))\n-\t\tcoremask += 2;\n-\ti = strlen(coremask);\n-\twhile ((i > 0) && isblank(coremask[i - 1]))\n-\t\ti--;\n-\tif (i == 0)\n-\t\treturn -1;\n+\tcount = rte_arg_parse_core_string(coremask, cores, RTE_DIM(cores), 0);\n \n-\tfor (i = i - 1; i >= 0 && idx < MAX_NUM_CORE; i--) {\n-\t\tc = coremask[i];\n-\t\tif (isxdigit(c) == 0) {\n-\t\t\t/* invalid characters */\n-\t\t\treturn -1;\n-\t\t}\n-\t\tval = xdigit2val(c);\n-\t\tfor (j = 0; j < BITS_HEX && idx < MAX_NUM_CORE; j++, idx++) {\n-\t\t\tif ((1 << j) & val) {\n-\t\t\t\tmask |= (1ULL << idx);\n-\t\t\t\tcount++;\n-\t\t\t}\n-\t\t}\n-\t}\n-\tfor (; i >= 0; i--)\n-\t\tif (coremask[i] != '0')\n-\t\t\treturn -1;\n-\tif (count == 0)\n+\tif (count == 0 || count == -1)\n \t\treturn -1;\n+\n+\tfor (i = 0; i < count; i++)\n+\t\tmask |= 1ULL << cores[i];\n+\n \treturn mask;\n }\n \ndiff --git a/examples/eventdev_pipeline/pipeline_common.h b/examples/eventdev_pipeline/pipeline_common.h\nindex 28b6ab85ff..2b97a29bfc 100644\n--- a/examples/eventdev_pipeline/pipeline_common.h\n+++ b/examples/eventdev_pipeline/pipeline_common.h\n@@ -6,6 +6,7 @@\n \n #include <stdbool.h>\n \n+#include <rte_arg_parser.h>\n #include <rte_eal.h>\n #include <rte_mempool.h>\n #include <rte_mbuf.h>\n", "prefixes": [ "v3", "7/8" ] }