Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134960/?format=api
{ "id": 134960, "url": "http://patchwork.dpdk.org/api/patches/134960/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231208124231.198138-1-qi_an_hao@126.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231208124231.198138-1-qi_an_hao@126.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231208124231.198138-1-qi_an_hao@126.com", "date": "2023-12-08T12:42:31", "name": "examples/packet_ordering: fix segfault in disable_reorder mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "11f1f9f770e866cd1a1f1bd5b7e0880ba03ab656", "submitter": { "id": 3248, "url": "http://patchwork.dpdk.org/api/people/3248/?format=api", "name": "Qian Hao", "email": "qi_an_hao@126.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231208124231.198138-1-qi_an_hao@126.com/mbox/", "series": [ { "id": 30492, "url": "http://patchwork.dpdk.org/api/series/30492/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30492", "date": "2023-12-08T12:42:31", "name": "examples/packet_ordering: fix segfault in disable_reorder mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30492/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/134960/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/134960/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6466D436A9;\n\tFri, 8 Dec 2023 13:42:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A3DD402BF;\n\tFri, 8 Dec 2023 13:42:44 +0100 (CET)", "from m126.mail.126.com (m126.mail.126.com [220.181.12.36])\n by mails.dpdk.org (Postfix) with ESMTP id 5A46D4029E\n for <dev@dpdk.org>; Fri, 8 Dec 2023 13:42:42 +0100 (CET)", "from R750-427Server16.. (unknown [58.213.8.49])\n by zwqz-smtp-mta-g4-1 (Coremail) with SMTP id\n _____wDHz+E7D3NlEe9fDg--.59065S2;\n Fri, 08 Dec 2023 20:42:38 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=AHgkG\n rAWjKpxc6aHnTN5vO5WwVCzOmDSCdfL1mUUG5o=; b=kxf6WWIsGorMyKvaDrw91\n 1xZ6QxjOzfWkNgIVxa+gdWbtIm2pVMAQoJyL17rS/WA9+QtlaVUxulZkxJ6qTr0U\n opRtTw8L+R2kCdF513NwXfSExMdYSjoepoOEM9wQLEN5vIaOFI0GeXuYyyUvHisq\n L6/HDduTD94XpntXXeZlHA=", "From": "Qian Hao <qi_an_hao@126.com>", "To": "dev@dpdk.org", "Cc": "Volodymyr Fialko <vfialko@marvell.com>", "Subject": "[PATCH] examples/packet_ordering: fix segfault in disable_reorder\n mode", "Date": "Fri, 8 Dec 2023 20:42:31 +0800", "Message-Id": "<20231208124231.198138-1-qi_an_hao@126.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "_____wDHz+E7D3NlEe9fDg--.59065S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7KF4xZFy8Zr48Cw45try8uFg_yoW8WryfpF\n nxK34Iyr48ZryrKrZ7Ja47Xr15WFW5XF1xuryfZ3WYkw4UXa4SvrW0qF15uFW8AFykJw17\n Zr4YgryqvFyqkF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Upq2_UUUUU=", "X-Originating-IP": "[58.213.8.49]", "X-CM-SenderInfo": "ptlbt0pbkd0qqrswhudrp/1tbi4wBAGVpEFAbokQAAsP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "packet_ordering example works in two modes (--disable-reorder):\n - When reorder is enabled: rx_thread - N*worker_thread - send_thread\n - When reorder is disabled: rx_thread - N*worker_thread - tx_thread\nN parallel worker_thread(s) generate out-of-order packets.\n\nWhen reorder is enabled, send_thread uses sequence number generated in rx_thread (Line 459) to enforce packet ordering. Otherwise rx_thread just sends any packet it receives.\n\nrx_thread writes sequence number into a dynamic field, which is only registered by calling rte_reorder_create() (Line 741) when reorder is enabled. However, rx_thread marks sequence number onto each packet no matter whether reorder is enabled, overwriting the leading bytes in packet mbufs when reorder is disabled, resulting in segfaults when PMD tries to DMA packets.\n\nif (!disable_reorder) {...} is added to fix the bug.\n---\n examples/packet_ordering/main.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c\nindex d2fd6f77e4..7688f541ba 100644\n--- a/examples/packet_ordering/main.c\n+++ b/examples/packet_ordering/main.c\n@@ -455,8 +455,11 @@ rx_thread(struct rte_ring *ring_out)\n \t\t\t\tapp_stats.rx.rx_pkts += nb_rx_pkts;\n \n \t\t\t\t/* mark sequence number */\n-\t\t\t\tfor (i = 0; i < nb_rx_pkts; )\n-\t\t\t\t\t*rte_reorder_seqn(pkts[i++]) = seqn++;\n+\t\t\t\tif (!disable_reorder) {\n+\t\t\t\t\tfor (i = 0; i < nb_rx_pkts;) {\n+\t\t\t\t\t\t*rte_reorder_seqn(pkts[i++]) = seqn++; \n+\t\t\t\t\t}\n+\t\t\t\t}\n \n \t\t\t\t/* enqueue to rx_to_workers ring */\n \t\t\t\tret = rte_ring_enqueue_burst(ring_out,\n", "prefixes": [] }