Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135132/?format=api
{ "id": 135132, "url": "http://patchwork.dpdk.org/api/patches/135132/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231213104945.16634-1-qi_an_hao@126.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231213104945.16634-1-qi_an_hao@126.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231213104945.16634-1-qi_an_hao@126.com", "date": "2023-12-13T10:49:45", "name": "[v2] examples/packet_ordering: fix segfault in disable_reorder mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1c5223bb1c65eac12b80df24550bceb3c9da4c1c", "submitter": { "id": 3248, "url": "http://patchwork.dpdk.org/api/people/3248/?format=api", "name": "Qian Hao", "email": "qi_an_hao@126.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231213104945.16634-1-qi_an_hao@126.com/mbox/", "series": [ { "id": 30535, "url": "http://patchwork.dpdk.org/api/series/30535/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30535", "date": "2023-12-13T10:49:45", "name": "[v2] examples/packet_ordering: fix segfault in disable_reorder mode", "version": 2, "mbox": "http://patchwork.dpdk.org/series/30535/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135132/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/135132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3A1D436DE;\n\tWed, 13 Dec 2023 11:51:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B769842E8D;\n\tWed, 13 Dec 2023 11:51:19 +0100 (CET)", "from m126.mail.126.com (m126.mail.126.com [220.181.12.28])\n by mails.dpdk.org (Postfix) with ESMTP id 7766A4021D\n for <dev@dpdk.org>; Wed, 13 Dec 2023 11:51:17 +0100 (CET)", "from R750-427Server16.. (unknown [58.213.8.49])\n by zwqz-smtp-mta-g5-1 (Coremail) with SMTP id\n _____wDnDwJZjHlli_6GDw--.7903S2;\n Wed, 13 Dec 2023 18:50:21 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com;\n s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=zv+ti\n G9/L+57M1ECCAYpmh8gqk1LECXMPTJZ7ccx5g8=; b=SWpHZP4mLlBIRvwTXEHd4\n YrAMFPCKgUlxnIMcW7KtD+a7y/MiSloqmMNj2w6A5n1KUAMNUAUTGy6GVcwgT0td\n w1hhxxVRrPmmexGtA5HvBRNTBenFRFtH8IHADvs/TVNcyTcIoPvnfALOJDt6CVka\n zhvYcJnw8EnC8FbRNhCsG8=", "From": "Qian Hao <qi_an_hao@126.com>", "To": "dev@dpdk.org", "Cc": "vfialko@marvell.com", "Subject": "[PATCH v2] examples/packet_ordering: fix segfault in disable_reorder\n mode", "Date": "Wed, 13 Dec 2023 18:49:45 +0800", "Message-Id": "<20231213104945.16634-1-qi_an_hao@126.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231208124231.198138-1-qi_an_hao@126.com>", "References": "<20231208124231.198138-1-qi_an_hao@126.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CM-TRANSID": "_____wDnDwJZjHlli_6GDw--.7903S2", "X-Coremail-Antispam": "1Uf129KBjvJXoWxWFy8CF1fArWktFyfZr47urg_yoW5ZF48pF\n Z8K34xtr48ZF1Fgrs3Ja47Xry5XrWrXF1xur95Gwn0kw45Ca45ZrW0qFy5uFyUCFykGr4U\n Ar45XF909FWqkF7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U-Vy3UUUUU=", "X-Originating-IP": "[58.213.8.49]", "X-CM-SenderInfo": "ptlbt0pbkd0qqrswhudrp/1tbi4xBFGVpEFE8qSwAAsL", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The packet_ordering example works in two modes (opt via --disable-reorder):\n - When reorder is enabled: rx_thread - N*worker_thread - send_thread\n - When reorder is disabled: rx_thread - N*worker_thread - tx_thread\nN parallel worker_thread(s) generate out-of-order packets.\n\nWhen reorder is enabled, send_thread uses seq number generated in rx_thread\n(L459) to enforce packet ordering. Otherwise rx_thread just sends any packet\nit receives.\n\nrx_thread writes sequence number into a dynamic field, which is only registered\nby calling rte_reorder_create() (Line 741) when reorder is enabled. However,\nrx_thread marks sequence number onto each packet no matter whether reorder is\nenabled, overwriting the leading bytes in packet mbufs when reorder is disabled,\nresulting in segfaults when PMD tries to DMA packets.\n\n`if (!disable_reorder_flag) {...}` is added in rx_thread to fix the bug. The\ntest is inlined by the compiler to prevent any performance loss.\n\nSigned-off-by: Qian Hao <qi_an_hao@126.com>\n---\n examples/packet_ordering/main.c | 32 +++++++++++++++++++++++++-------\n 1 file changed, 25 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c\nindex d2fd6f77e4..f839db9102 100644\n--- a/examples/packet_ordering/main.c\n+++ b/examples/packet_ordering/main.c\n@@ -5,6 +5,7 @@\n #include <stdlib.h>\n #include <signal.h>\n #include <getopt.h>\n+#include <stdbool.h>\n \n #include <rte_eal.h>\n #include <rte_common.h>\n@@ -427,8 +428,8 @@ int_handler(int sig_num)\n * The mbufs are then passed to the worker threads via the rx_to_workers\n * ring.\n */\n-static int\n-rx_thread(struct rte_ring *ring_out)\n+static __rte_always_inline int\n+rx_thread(struct rte_ring *ring_out, bool disable_reorder_flag)\n {\n \tuint32_t seqn = 0;\n \tuint16_t i, ret = 0;\n@@ -454,9 +455,11 @@ rx_thread(struct rte_ring *ring_out)\n \t\t\t\t}\n \t\t\t\tapp_stats.rx.rx_pkts += nb_rx_pkts;\n \n-\t\t\t\t/* mark sequence number */\n-\t\t\t\tfor (i = 0; i < nb_rx_pkts; )\n-\t\t\t\t\t*rte_reorder_seqn(pkts[i++]) = seqn++;\n+\t\t\t\t/* mark sequence number if reorder is enabled */\n+\t\t\t\tif (!disable_reorder_flag) {\n+\t\t\t\t\tfor (i = 0; i < nb_rx_pkts;)\n+\t\t\t\t\t\t*rte_reorder_seqn(pkts[i++]) = seqn++;\n+\t\t\t\t}\n \n \t\t\t\t/* enqueue to rx_to_workers ring */\n \t\t\t\tret = rte_ring_enqueue_burst(ring_out,\n@@ -473,6 +476,18 @@ rx_thread(struct rte_ring *ring_out)\n \treturn 0;\n }\n \n+static __rte_noinline int\n+rx_thread_reorder(struct rte_ring *ring_out)\n+{\n+\treturn rx_thread(ring_out, false);\n+}\n+\n+static __rte_noinline int\n+rx_thread_reorder_disabled(struct rte_ring *ring_out)\n+{\n+\treturn rx_thread(ring_out, true);\n+}\n+\n /**\n * This thread takes bursts of packets from the rx_to_workers ring and\n * Changes the input port value to output port value. And feds it to\n@@ -772,8 +787,11 @@ main(int argc, char **argv)\n \t\t\t\t(void *)&send_args, last_lcore_id);\n \t}\n \n-\t/* Start rx_thread() on the main core */\n-\trx_thread(rx_to_workers);\n+\t/* Start rx_thread_xxx() on the main core */\n+\tif (disable_reorder)\n+\t\trx_thread_reorder_disabled(rx_to_workers);\n+\telse\n+\t\trx_thread_reorder(rx_to_workers);\n \n \tRTE_LCORE_FOREACH_WORKER(lcore_id) {\n \t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n", "prefixes": [ "v2" ] }