Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135230/?format=api
http://patchwork.dpdk.org/api/patches/135230/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231215133858.207911-1-venkatx.sivaramakrishnan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231215133858.207911-1-venkatx.sivaramakrishnan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231215133858.207911-1-venkatx.sivaramakrishnan@intel.com", "date": "2023-12-15T13:38:58", "name": "[v2] net/tap: fix buffer overflow for ptypes list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0eb57837dea08fcdc5a31bbe36a67028fa4e51bf", "submitter": { "id": 3155, "url": "http://patchwork.dpdk.org/api/people/3155/?format=api", "name": "Sivaramakrishnan Venkat", "email": "venkatx.sivaramakrishnan@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231215133858.207911-1-venkatx.sivaramakrishnan@intel.com/mbox/", "series": [ { "id": 30579, "url": "http://patchwork.dpdk.org/api/series/30579/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30579", "date": "2023-12-15T13:38:58", "name": "[v2] net/tap: fix buffer overflow for ptypes list", "version": 2, "mbox": "http://patchwork.dpdk.org/series/30579/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135230/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/135230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3E73436FE;\n\tFri, 15 Dec 2023 14:39:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DBD24326E;\n\tFri, 15 Dec 2023 14:39:08 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.12])\n by mails.dpdk.org (Postfix) with ESMTP id 2209340299;\n Fri, 15 Dec 2023 14:39:06 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Dec 2023 05:39:06 -0800", "from silpixa00400902.ir.intel.com ([10.243.23.146])\n by orsmga007.jf.intel.com with ESMTP; 15 Dec 2023 05:39:02 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1702647547; x=1734183547;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=duurtJGtKVY41Yrn7p9m1ZW3Hze807u6TzUN7GVd8Ac=;\n b=OLj0sizZzB/7dB2Uerjt2JDKFCIj5bt2ilLJBcSYODKWN4zqb+59cmJ0\n 7JmW84pQes51sHCzj2CUjuZTQ1SDjEnhVtY1H+NEylYLpKYKx7/0ygjKX\n A0n69ZzbcDH4yv8DyRdsloa4DTPgoHtmUlESQ5ku/QoLCS9ci7SVwf3ln\n HHkdYkTerOdOtYCSd686D2vq/ZyKV1XbzdwBIpCtN6F9ZHWNtS+zxd9C4\n Ju2XTI3rjpDuCG7eK10LavJ12WY4D0Ub3njSvqQqSiTcIX3amkFZci+TQ\n xmUCWKUrTNGN8HVC4rRJDyCGcTlI0qRVtEPI9Md5zWtky9LaGLJwF0Wiv A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10924\"; a=\"2443594\"", "E=Sophos;i=\"6.04,278,1695711600\";\n d=\"scan'208\";a=\"2443594\"", "E=McAfee;i=\"6600,9927,10924\"; a=\"767982171\"", "E=Sophos;i=\"6.04,278,1695711600\"; d=\"scan'208\";a=\"767982171\"" ], "X-ExtLoop1": "1", "From": "Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>", "To": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>, Zyta Szpak <zr@semihalf.com>,\n Liron Himi <lironh@marvell.com>, Chaoyong He <chaoyong.he@corigine.com>,\n Gagandeep Singh <g.singh@nxp.com>, Jerin Jacob <jerinj@marvell.com>,\n Maciej Czekaj <mczekaj@marvell.com>", "Cc": "dev@dpdk.org, ciara.power@intel.com,\n Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>,\n pascal.mazon@6wind.com, tdu@semihalf.com, jianfeng.tan@intel.com,\n jerin.jacob@caviumnetworks.com, stable@dpdk.org", "Subject": "[PATCH v2] net/tap: fix buffer overflow for ptypes list", "Date": "Fri, 15 Dec 2023 13:38:58 +0000", "Message-Id": "<20231215133858.207911-1-venkatx.sivaramakrishnan@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com>", "References": "<20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Incorrect ptypes list causes buffer overflow for Address Sanitizer\nrun. The last element in the ptypes lists to be \"RTE_PTYPE_UNKNOWN\"\nfor rte_eth_dev_get_supported_ptypes().\nIn rte_eth_dev_get_supported_ptypes(),the loop iterates until it\nfinds \"RTE_PTYPE_UNKNOWN\" to detect last element of the ptypes array.\nFix the ptypes list for drivers.\n\nFixes: 0849ac3b6122 (\"net/tap: add packet type management\")\nFixes: a7bdc3bd4244 (\"net/dpaa: support packet type parsing\")\nFixes: 4ccc8d770d3b (\"net/mvneta: add PMD skeleton\")\nFixes: f3f0d77db6b0 (\"net/mrvl: support packet type parsing\")\nFixes: 78a38edf66de (\"ethdev: query supported packet types\")\nFixes: 659b494d3d88 (\"net/pfe: add packet types and basic statistics\")\nFixes: 398a1be14168 (\"net/thunderx: remove generic passX references\")\nCc: pascal.mazon@6wind.com\nCc: zr@semihalf.com\nCc: tdu@semihalf.com\nCc: jianfeng.tan@intel.com\nCc: g.singh@nxp.com\nCc: jerin.jacob@caviumnetworks.com\nCc: stable@dpdk.org\n\nSigned-off-by: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>\n--\nV2:\nfix ptypes list buffer flow for other drivers\n---\n drivers/net/dpaa/dpaa_ethdev.c | 3 ++-\n drivers/net/mvneta/mvneta_ethdev.c | 3 ++-\n drivers/net/mvpp2/mrvl_ethdev.c | 3 ++-\n drivers/net/nfp/nfp_net_common.c | 1 +\n drivers/net/pfe/pfe_ethdev.c | 3 ++-\n drivers/net/tap/rte_eth_tap.c | 1 +\n drivers/net/thunderx/nicvf_ethdev.c | 1 +\n 7 files changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex ef4c06db6a..779bdc5860 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -363,7 +363,8 @@ dpaa_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_SCTP,\n-\t\tRTE_PTYPE_TUNNEL_ESP\n+\t\tRTE_PTYPE_TUNNEL_ESP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tPMD_INIT_FUNC_TRACE();\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex daa69e533a..212c300c14 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -198,7 +198,8 @@ mvneta_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L3_IPV4,\n \t\tRTE_PTYPE_L3_IPV6,\n \t\tRTE_PTYPE_L4_TCP,\n-\t\tRTE_PTYPE_L4_UDP\n+\t\tRTE_PTYPE_L4_UDP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex c12364941d..4cc64c7cad 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -1777,7 +1777,8 @@ mrvl_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L3_IPV6_EXT,\n \t\tRTE_PTYPE_L2_ETHER_ARP,\n \t\tRTE_PTYPE_L4_TCP,\n-\t\tRTE_PTYPE_L4_UDP\n+\t\tRTE_PTYPE_L4_UDP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex e969b840d6..46d0e07850 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -1299,6 +1299,7 @@ nfp_net_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_INNER_L4_NONFRAG,\n \t\tRTE_PTYPE_INNER_L4_ICMP,\n \t\tRTE_PTYPE_INNER_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tif (dev->rx_pkt_burst != nfp_net_recv_pkts)\ndiff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c\nindex 551f3cf193..0073dd7405 100644\n--- a/drivers/net/pfe/pfe_ethdev.c\n+++ b/drivers/net/pfe/pfe_ethdev.c\n@@ -520,7 +520,8 @@ pfe_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L3_IPV6_EXT,\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n-\t\tRTE_PTYPE_L4_SCTP\n+\t\tRTE_PTYPE_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tif (dev->rx_pkt_burst == pfe_recv_pkts ||\ndiff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex b41fa971cb..3fa03cdbee 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1803,6 +1803,7 @@ tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex a504d41dfe..ff41714927 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -392,6 +392,7 @@ nicvf_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_FRAG,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \tstatic const uint32_t ptypes_tunnel[] = {\n \t\tRTE_PTYPE_TUNNEL_GRE,\n", "prefixes": [ "v2" ] }{ "id": 135230, "url": "