Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135283/?format=api
{ "id": 135283, "url": "http://patchwork.dpdk.org/api/patches/135283/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231218154307.1507322-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231218154307.1507322-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231218154307.1507322-2-david.marchand@redhat.com", "date": "2023-12-18T15:43:07", "name": "[2/2] baseband/acc: fix common logs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14b35d8920d6e175103b1896955afeac3e30bdad", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231218154307.1507322-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 30592, "url": "http://patchwork.dpdk.org/api/series/30592/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30592", "date": "2023-12-18T15:43:06", "name": "[1/2] baseband/acc: fix logtypes register", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30592/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135283/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/135283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 325714373C;\n\tMon, 18 Dec 2023 16:43:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D2BD42D28;\n\tMon, 18 Dec 2023 16:43:21 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id B2A1542D28\n for <dev@dpdk.org>; Mon, 18 Dec 2023 16:43:19 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-663-aal9FNFjOSG5ruEk0yOlKA-1; Mon, 18 Dec 2023 10:43:16 -0500", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA887101AA57;\n Mon, 18 Dec 2023 15:43:14 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.218])\n by smtp.corp.redhat.com (Postfix) with ESMTP id C9B3F492BC6;\n Mon, 18 Dec 2023 15:43:13 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1702914199;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=S3VgREhS2jQH/u3mn+LmeOglUIpRWrEBw8WKxgzFWj4=;\n b=ZUyBdIQUuyYMJWdDgiY7+q/LyOnGWZKjWMxefHEb0FZQrvvP+mlCJmb1kvmNgML0YpYIaI\n RkaMDIf21bOdnv7Pny9RuiS4+W14V9jR8+b23nTpeLNOvvFS9I/+ggldrcB9TlUZ3s0hVB\n jscpaGZ7W7rxR4KtGO6xIH+zZMOGsyo=", "X-MC-Unique": "aal9FNFjOSG5ruEk0yOlKA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Nicolas Chautru <nicolas.chautru@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 2/2] baseband/acc: fix common logs", "Date": "Mon, 18 Dec 2023 16:43:07 +0100", "Message-ID": "<20231218154307.1507322-2-david.marchand@redhat.com>", "In-Reply-To": "<20231218154307.1507322-1-david.marchand@redhat.com>", "References": "<20231218154307.1507322-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Logs generated by helpers common to acc100 and vrb drivers were\nemitted with a RTE_LOG_NOTICE == 6 == RTE_LOGTYPE_HASH.\nRegister a dedicated logtype for this.\n\nFixes: 32e8b7ea35dd (\"baseband/acc100: refactor to segregate common code\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/baseband/acc/acc_common.c | 7 +++++++\n drivers/baseband/acc/acc_common.h | 4 +++-\n drivers/baseband/acc/meson.build | 2 +-\n 3 files changed, 11 insertions(+), 2 deletions(-)\n create mode 100644 drivers/baseband/acc/acc_common.c", "diff": "diff --git a/drivers/baseband/acc/acc_common.c b/drivers/baseband/acc/acc_common.c\nnew file mode 100644\nindex 0000000000..f8d2b19570\n--- /dev/null\n+++ b/drivers/baseband/acc/acc_common.c\n@@ -0,0 +1,7 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2023 Red Hat, Inc.\n+ */\n+\n+#include <rte_log.h>\n+\n+RTE_LOG_REGISTER_SUFFIX(acc_common_logtype, common, INFO);\ndiff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h\nindex bda2ad2f7a..fddeb0737b 100644\n--- a/drivers/baseband/acc/acc_common.h\n+++ b/drivers/baseband/acc/acc_common.h\n@@ -150,9 +150,11 @@\n \n #define ACC_MAX_FFT_WIN 16\n \n+extern int acc_common_logtype;\n+\n /* Helper macro for logging */\n #define rte_acc_log(level, fmt, ...) \\\n-\trte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt \"\\n\", \\\n+\trte_log(RTE_LOG_ ## level, acc_common_logtype, fmt \"\\n\", \\\n \t\t##__VA_ARGS__)\n \n /* ACC100 DMA Descriptor triplet */\ndiff --git a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build\nindex 449d1e176c..64fcf1537a 100644\n--- a/drivers/baseband/acc/meson.build\n+++ b/drivers/baseband/acc/meson.build\n@@ -24,6 +24,6 @@ endif\n \n deps += ['bus_pci']\n \n-sources = files('rte_acc100_pmd.c', 'rte_vrb_pmd.c')\n+sources = files('acc_common.c', 'rte_acc100_pmd.c', 'rte_vrb_pmd.c')\n \n headers = files('rte_acc_cfg.h')\n", "prefixes": [ "2/2" ] }