Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135401/?format=api
{ "id": 135401, "url": "http://patchwork.dpdk.org/api/patches/135401/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231218214759.134188-1-jonathan.erb@threater.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231218214759.134188-1-jonathan.erb@threater.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231218214759.134188-1-jonathan.erb@threater.com", "date": "2023-12-18T21:47:59", "name": "telemetry: correct json empty dictionaries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dabd428773bc66a4e031cc46dbc7a974f229c2b4", "submitter": { "id": 3252, "url": "http://patchwork.dpdk.org/api/people/3252/?format=api", "name": "Jonathan Erb", "email": "jonathan.erb@threater.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231218214759.134188-1-jonathan.erb@threater.com/mbox/", "series": [ { "id": 30632, "url": "http://patchwork.dpdk.org/api/series/30632/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30632", "date": "2023-12-18T21:47:59", "name": "telemetry: correct json empty dictionaries", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30632/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135401/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/135401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 611B04374A;\n\tWed, 20 Dec 2023 15:35:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E9D8742DDB;\n\tWed, 20 Dec 2023 15:35:53 +0100 (CET)", "from mail-oi1-f180.google.com (mail-oi1-f180.google.com\n [209.85.167.180])\n by mails.dpdk.org (Postfix) with ESMTP id 8E09E4064C\n for <dev@dpdk.org>; Mon, 18 Dec 2023 22:48:30 +0100 (CET)", "by mail-oi1-f180.google.com with SMTP id\n 5614622812f47-3b9e07690ccso2414443b6e.3\n for <dev@dpdk.org>; Mon, 18 Dec 2023 13:48:30 -0800 (PST)", "from localhost.localdomain (dyn-170-246-97.myactv.net.\n [24.170.246.97]) by smtp.gmail.com with ESMTPSA id\n w18-20020a0cef92000000b0067f2c03d4adsm2432094qvr.100.2023.12.18.13.48.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Dec 2023 13:48:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=threater-com.20230601.gappssmtp.com; s=20230601; t=1702936110;\n x=1703540910;\n darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=RXV/8pqaCxI+/nmizlhJ+DLtzJEy/7iURxiM1fsDVEM=;\n b=bCqhKtfc9481kneR7a82Kh6HQajgNAWPmckC9kvMbMyA/RJEOyIDBkmr3GZMSgtExQ\n E1ZocJhWvxtOgYQqeRND6Z0LUfzKFR7qnqZ+76a2ovX97qZy1JgL2xaqsw2lnaxDZVna\n XO7vW3Ukyik13LBilSNJ/VRC6GkzstliVkm8UlCgIrTGAQdUjgd9YLqFqr+KBQIhi6Pb\n +vOZeKkcfTP9erS+4qe6MJ5UJeHFo+ZpY/hBgSas+XSo1FcBJWOnFuk4nwqg56h7d5+/\n m35jemaFrvlsdgF41kxYeb0vfrLPMrAINsfrqKS/YpH/KvsIEw5AJw9I646yW3uerWpo\n 5w2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702936110; x=1703540910;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=RXV/8pqaCxI+/nmizlhJ+DLtzJEy/7iURxiM1fsDVEM=;\n b=rcvpoksjLRk3veuR+Kyobn/bdTHwqeRGw/ZcYmr+FBEE9aa5Vbm9JemBW2K48ErAS8\n c87yiQQsu4Ab1hXAW45v1p5WOBPbOwNCY/efEm+nkYEAQtBHOmWh8lyNnzi69jw7qgC6\n qxi9u6GxXJkp53y7hf+lXWiurFeWkOAlNYzWe/JJlvbQQQo1oGtkIRoSBVXE/KLU5oLQ\n L1UZgwBbKuNKVmDovYOypViG0YOnAHfwHvxtNGN1N3F66SphmsjGQKGlmSnaepqyita4\n 9akfgbldnheVWJtM2ua3V4A/K+eoYJU0q3Oaucs4Y2OpxUAoaI4srDNKj3NgF84slQC9\n ZVfw==", "X-Gm-Message-State": "AOJu0YxMRXmtF31L7vkv10kEzw8xIuyv/VxhtDYdFCFKW+Y7EM1iRFHb\n IPuUIsirqMWB5dnDMXPyX4//Kg==", "X-Google-Smtp-Source": "\n AGHT+IGgpyAc9L66JXy22hC3iiTDylYsthgFQK5vL2WfsOzBg5GwEh5MLTGaKdl6tKIfaLctRfT15w==", "X-Received": "by 2002:a05:6808:1708:b0:3b9:d7a0:d152 with SMTP id\n bc8-20020a056808170800b003b9d7a0d152mr19719948oib.40.1702936109739;\n Mon, 18 Dec 2023 13:48:29 -0800 (PST)", "From": "Jonathan Erb <jonathan.erb@threater.com>", "To": "ciara.power@intel.com", "Cc": "dev@dpdk.org,\n\tJonathan Erb <jonathan.erb@threater.com>", "Subject": "[PATCH] telemetry: correct json empty dictionaries", "Date": "Mon, 18 Dec 2023 16:47:59 -0500", "Message-Id": "<20231218214759.134188-1-jonathan.erb@threater.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 20 Dec 2023 15:35:52 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix to allow telemetry to handle empty dictionaries correctly.\n\nThis patch resolves an issue where empty dictionaries are reported\nby telemetry as '[]' rather than '{}'. Initializing the output\nbuffer based on the container type resolves the issue.\n\nSigned-off-by: Jonathan Erb <jonathan.erb@threater.com>\n---\n .mailmap | 2 +-\n lib/telemetry/telemetry.c | 6 +++++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex ab0742a382..a3302ba7a1 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -675,7 +675,7 @@ John Ousterhout <ouster@cs.stanford.edu>\n John Romein <romein@astron.nl>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n-Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n+Jonathan Erb <jonathan.erb@threater.com>\n Jonathan Tsai <jonathan1.tsai@intel.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 92982842a8..0788a32210 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -169,7 +169,11 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \t\td->type != TEL_ARRAY_INT && d->type != TEL_ARRAY_STRING)\n \t\treturn snprintf(out_buf, buf_len, \"null\");\n \n-\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\tif (d->type == RTE_TEL_DICT)\n+\t\tused = rte_tel_json_empty_obj(out_buf, buf_len, 0);\n+\telse\n+\t\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\n \tif (d->type == TEL_ARRAY_UINT)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_uint(out_buf,\n", "prefixes": [] }