Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135475/?format=api
{ "id": 135475, "url": "http://patchwork.dpdk.org/api/patches/135475/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231221174140.3369894-2-euan.bourke@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231221174140.3369894-2-euan.bourke@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231221174140.3369894-2-euan.bourke@intel.com", "date": "2023-12-21T17:41:40", "name": "[v3,2/2] ip_frag: updated name for IP frag max frag define", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6e9d2fb05b4b0cb5069dc86d1b87443584b61cff", "submitter": { "id": 3231, "url": "http://patchwork.dpdk.org/api/people/3231/?format=api", "name": "Euan Bourke", "email": "euan.bourke@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231221174140.3369894-2-euan.bourke@intel.com/mbox/", "series": [ { "id": 30649, "url": "http://patchwork.dpdk.org/api/series/30649/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30649", "date": "2023-12-21T17:41:39", "name": "[v3,1/2] doc: updated incorrect value for IP frag max fragments", "version": 3, "mbox": "http://patchwork.dpdk.org/series/30649/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135475/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/135475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E89F643752;\n\tThu, 21 Dec 2023 18:42:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4500540EE2;\n\tThu, 21 Dec 2023 18:42:40 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by mails.dpdk.org (Postfix) with ESMTP id 6E6594067D\n for <dev@dpdk.org>; Thu, 21 Dec 2023 18:42:38 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Dec 2023 09:42:38 -0800", "from unknown (HELO silpixa00400630.ir.intel.com) ([10.237.213.151])\n by orsmga002.jf.intel.com with ESMTP; 21 Dec 2023 09:42:36 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1703180559; x=1734716559;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=dSMpYC27Bp6giGRLdxXaFWmcnunWYOJDly6WQq1SYVg=;\n b=Ghub25KLv1AoBa9myrKPVSelpNMqqr6YoBM9tw8SFWsZkErznZoeqdRp\n 2GopKbHIlewT9LUz+75DXwWTHb2vNVKp2uxtMldjG5SzJVStyAlS1P2c7\n Xm+rs5yzR/1P+HSO1Kgl1XZnLVaDgcb1PNuRFdPnaR7ATS7eFQOVyiX5w\n zGX1ZCQcKUd/tkU/Ua4RYuXCY9elqd7aSQd6Vm8zlT5X4cxuWuRRXu2mv\n ZMizT2udmKMb+ZtZJBA2PxVPsWGgUQlWlZe05s7mlDGq1tNOG4ESq5VtT\n sE3E7SwxihVg0ulVBJe+KbPRGHTXIGO0Lyp0sjm6ONmlphYSDR7Gkab3I g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10931\"; a=\"9490103\"", "E=Sophos;i=\"6.04,294,1695711600\";\n d=\"scan'208\";a=\"9490103\"", "E=McAfee;i=\"6600,9927,10931\"; a=\"776784439\"", "E=Sophos;i=\"6.04,294,1695711600\"; d=\"scan'208\";a=\"776784439\"" ], "X-ExtLoop1": "1", "From": "Euan Bourke <euan.bourke@intel.com>", "To": "dev@dpdk.org", "Cc": "Euan Bourke <euan.bourke@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH v3 2/2] ip_frag: updated name for IP frag max frag define", "Date": "Thu, 21 Dec 2023 17:41:40 +0000", "Message-Id": "<20231221174140.3369894-2-euan.bourke@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231221174140.3369894-1-euan.bourke@intel.com>", "References": "<20231221113242.3351356-1-euan.bourke@intel.com>\n <20231221174140.3369894-1-euan.bourke@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Removed LIBRTE from name as its an old prefix.\n\nSigned-off-by: Euan Bourke <euan.bourke@intel.com>\n---\n app/test/test_reassembly_perf.c | 2 +-\n config/rte_config.h | 2 +-\n doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 8 ++++----\n doc/guides/sample_app_ug/ip_reassembly.rst | 4 ++--\n examples/ip_fragmentation/main.c | 2 +-\n examples/ip_reassembly/main.c | 2 +-\n examples/ipsec-secgw/ipsec_worker.h | 2 +-\n lib/ip_frag/ip_reassembly.h | 2 +-\n lib/ip_frag/rte_ip_frag.h | 2 +-\n 9 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_reassembly_perf.c b/app/test/test_reassembly_perf.c\nindex 3912179022..805ae2fe9d 100644\n--- a/app/test/test_reassembly_perf.c\n+++ b/app/test/test_reassembly_perf.c\n@@ -20,7 +20,7 @@\n #define MAX_FLOWS\t (1024 * 32)\n #define MAX_BKTS\t MAX_FLOWS\n #define MAX_ENTRIES_PER_BKT 16\n-#define MAX_FRAGMENTS\t RTE_LIBRTE_IP_FRAG_MAX_FRAG\n+#define MAX_FRAGMENTS\t RTE_IP_FRAG_MAX_FRAG\n #define MIN_FRAGMENTS\t 2\n #define MAX_PKTS\t (MAX_FLOWS * MAX_FRAGMENTS)\n \ndiff --git a/config/rte_config.h b/config/rte_config.h\nindex da265d7dd2..e2fa2a58fa 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -85,7 +85,7 @@\n #define RTE_RAWDEV_MAX_DEVS 64\n \n /* ip_fragmentation defines */\n-#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8\n+#define RTE_IP_FRAG_MAX_FRAG 8\n // RTE_LIBRTE_IP_FRAG_TBL_STAT is not set\n \n /* rte_power defines */\ndiff --git a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst\nindex f3ed90d700..2d422309bb 100644\n--- a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst\n+++ b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst\n@@ -43,12 +43,12 @@ Note that all update/lookup operations on Fragment Table are not thread safe.\n So if different execution contexts (threads/processes) will access the same table simultaneously,\n then some external syncing mechanism have to be provided.\n \n-Each table entry can hold information about packets of up to ``RTE_LIBRTE_IP_FRAG_MAX_FRAG`` fragments,\n-where ``RTE_LIBRTE_IP_FRAG_MAX_FRAG`` defaults to:\n+Each table entry can hold information about packets of up to ``RTE_IP_FRAG_MAX_FRAG`` fragments,\n+where ``RTE_IP_FRAG_MAX_FRAG`` defaults to:\n \n .. literalinclude:: ../../../config/rte_config.h\n :language: c\n- :start-at: #define RTE_LIBRTE_IP_FRAG_MAX_FRAG\n+ :start-at: #define RTE_IP_FRAG_MAX_FRAG\n :lines: 1\n \n Code example, that demonstrates creation of a new Fragment table:\n@@ -69,7 +69,7 @@ Also, entries that resides in the table longer then <max_cycles> are considered\n and could be removed/replaced by the new ones.\n \n Note that reassembly demands a lot of mbuf's to be allocated.\n-At any given time up to (2 \\* bucket_entries \\* RTE_LIBRTE_IP_FRAG_MAX \\* <maximum number of mbufs per packet>)\n+At any given time up to (2 \\* bucket_entries \\* RTE_IP_FRAG_MAX \\* <maximum number of mbufs per packet>)\n can be stored inside Fragment Table waiting for remaining fragments.\n \n Packet Reassembly\ndiff --git a/doc/guides/sample_app_ug/ip_reassembly.rst b/doc/guides/sample_app_ug/ip_reassembly.rst\nindex 5280bf4ea0..d9aaa4b5c4 100644\n--- a/doc/guides/sample_app_ug/ip_reassembly.rst\n+++ b/doc/guides/sample_app_ug/ip_reassembly.rst\n@@ -135,7 +135,7 @@ Fragment table maintains information about already received fragments of the pac\n Each IP packet is uniquely identified by triple <Source IP address>, <Destination IP address>, <ID>.\n To avoid lock contention, each RX queue has its own Fragment Table,\n e.g. the application can't handle the situation when different fragments of the same packet arrive through different RX queues.\n-Each table entry can hold information about packet consisting of up to RTE_LIBRTE_IP_FRAG_MAX_FRAGS fragments.\n+Each table entry can hold information about packet consisting of up to RTE_IP_FRAG_MAX_FRAGS fragments.\n \n .. literalinclude:: ../../../examples/ip_reassembly/main.c\n :language: c\n@@ -147,7 +147,7 @@ Mempools Initialization\n ~~~~~~~~~~~~~~~~~~~~~~~\n \n The reassembly application demands a lot of mbuf's to be allocated.\n-At any given time up to (2 \\* max_flow_num \\* RTE_LIBRTE_IP_FRAG_MAX_FRAGS \\* <maximum number of mbufs per packet>)\n+At any given time up to (2 \\* max_flow_num \\* RTE_IP_FRAG_MAX_FRAGS_FRAG \\* <maximum number of mbufs per packet>)\n can be stored inside Fragment Table waiting for remaining fragments.\n To keep mempool size under reasonable limits and to avoid situation when one RX queue can starve other queues,\n each RX queue uses its own mempool.\ndiff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\nindex 744a1aa9b4..1e4471891b 100644\n--- a/examples/ip_fragmentation/main.c\n+++ b/examples/ip_fragmentation/main.c\n@@ -71,7 +71,7 @@\n /*\n * Max number of fragments per packet expected - defined by config file.\n */\n-#define\tMAX_PACKET_FRAG RTE_LIBRTE_IP_FRAG_MAX_FRAG\n+#define\tMAX_PACKET_FRAG RTE_IP_FRAG_MAX_FRAG\n \n #define NB_MBUF 8192\n \ndiff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c\nindex bd0b1d31de..16607d99f3 100644\n--- a/examples/ip_reassembly/main.c\n+++ b/examples/ip_reassembly/main.c\n@@ -69,7 +69,7 @@\n #define\tMIN_FLOW_TTL\t1\n #define\tDEF_FLOW_TTL\tMS_PER_S\n \n-#define MAX_FRAG_NUM RTE_LIBRTE_IP_FRAG_MAX_FRAG\n+#define MAX_FRAG_NUM RTE_IP_FRAG_MAX_FRAG\n \n /* Should be power of two. */\n #define\tIP_FRAG_TBL_BUCKET_ENTRIES\t16\ndiff --git a/examples/ipsec-secgw/ipsec_worker.h b/examples/ipsec-secgw/ipsec_worker.h\nindex ac980b8bcf..918e6b5200 100644\n--- a/examples/ipsec-secgw/ipsec_worker.h\n+++ b/examples/ipsec-secgw/ipsec_worker.h\n@@ -291,7 +291,7 @@ send_fragment_packet(struct lcore_conf *qconf, struct rte_mbuf *m,\n \tlen = tbl->len;\n \n \t/* free space for new fragments */\n-\tif (len + RTE_LIBRTE_IP_FRAG_MAX_FRAG >= RTE_DIM(tbl->m_table)) {\n+\tif (len + RTE_IP_FRAG_MAX_FRAG >= RTE_DIM(tbl->m_table)) {\n \t\tsend_burst(qconf, len, port);\n \t\tlen = 0;\n \t}\ndiff --git a/lib/ip_frag/ip_reassembly.h b/lib/ip_frag/ip_reassembly.h\nindex a9f97aefca..77c22ca9d1 100644\n--- a/lib/ip_frag/ip_reassembly.h\n+++ b/lib/ip_frag/ip_reassembly.h\n@@ -16,7 +16,7 @@ enum {\n \tIP_LAST_FRAG_IDX, /* index of last fragment */\n \tIP_FIRST_FRAG_IDX, /* index of first fragment */\n \tIP_MIN_FRAG_NUM, /* minimum number of fragments */\n-\tIP_MAX_FRAG_NUM = RTE_LIBRTE_IP_FRAG_MAX_FRAG,\n+\tIP_MAX_FRAG_NUM = RTE_IP_FRAG_MAX_FRAG,\n \t/* maximum number of fragments per packet */\n };\n \ndiff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h\nindex 2ad318096b..6465ec316b 100644\n--- a/lib/ip_frag/rte_ip_frag.h\n+++ b/lib/ip_frag/rte_ip_frag.h\n@@ -32,7 +32,7 @@ struct rte_mbuf;\n \n /** death row size in mbufs */\n #define RTE_IP_FRAG_DEATH_ROW_MBUF_LEN \\\n-\t(RTE_IP_FRAG_DEATH_ROW_LEN * (RTE_LIBRTE_IP_FRAG_MAX_FRAG + 1))\n+\t(RTE_IP_FRAG_DEATH_ROW_LEN * (RTE_IP_FRAG_MAX_FRAG + 1))\n \n /** mbuf death row (packets to be freed) */\n struct rte_ip_frag_death_row {\n", "prefixes": [ "v3", "2/2" ] }