Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135748/?format=api
{ "id": 135748, "url": "http://patchwork.dpdk.org/api/patches/135748/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20231224220201.762377-1-jonathan.erb@threater.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231224220201.762377-1-jonathan.erb@threater.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231224220201.762377-1-jonathan.erb@threater.com", "date": "2023-12-24T22:02:00", "name": "[v2,1/2] telemetry: correct json empty dictionaries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dabd428773bc66a4e031cc46dbc7a974f229c2b4", "submitter": { "id": 3252, "url": "http://patchwork.dpdk.org/api/people/3252/?format=api", "name": "Jonathan Erb", "email": "jonathan.erb@threater.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20231224220201.762377-1-jonathan.erb@threater.com/mbox/", "series": [ { "id": 30733, "url": "http://patchwork.dpdk.org/api/series/30733/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30733", "date": "2023-12-24T22:02:00", "name": "[v2,1/2] telemetry: correct json empty dictionaries", "version": 2, "mbox": "http://patchwork.dpdk.org/series/30733/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/135748/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/135748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 19D264383B;\n\tFri, 5 Jan 2024 10:03:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 328B2402EC;\n\tFri, 5 Jan 2024 10:03:06 +0100 (CET)", "from mail-qv1-f52.google.com (mail-qv1-f52.google.com\n [209.85.219.52]) by mails.dpdk.org (Postfix) with ESMTP id 33E5B40268\n for <dev@dpdk.org>; Sun, 24 Dec 2023 23:02:07 +0100 (CET)", "by mail-qv1-f52.google.com with SMTP id\n 6a1803df08f44-67fe0210665so5784486d6.1\n for <dev@dpdk.org>; Sun, 24 Dec 2023 14:02:07 -0800 (PST)", "from localhost.localdomain (dyn-170-246-97.myactv.net.\n [24.170.246.97]) by smtp.gmail.com with ESMTPSA id\n bi5-20020a05620a318500b0077efb969151sm3045939qkb.59.2023.12.24.14.02.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 24 Dec 2023 14:02:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=threater-com.20230601.gappssmtp.com; s=20230601; t=1703455326;\n x=1704060126;\n darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=RXV/8pqaCxI+/nmizlhJ+DLtzJEy/7iURxiM1fsDVEM=;\n b=qkH1KqvcdfTtiUUuEYmmWfwOMWbJKllCMFMO9u7gootuWomSuHTIT9gOX3414NMdYM\n 0uA8p8wPVPrVz9KAG1ZGkRciQV6FtO8vtQNj9lzah9xN/S3YiG8wOsaInI1nBwpUa2oF\n t34BZYXWeXUFqPJGKCNRz4wwhQag96GuKvQ8Eb91mOcIRVrocwKURDmQwysMoQb39TFY\n VPszXRuWmGf36BBCFlcRAaF6Y6/pc19Zjhe6wZtAUgAQOD6+85+dfdOKQquzd4XWQ3+C\n z1h1uDdIye3t3wTQAE0lZf+ss59ixVfqAEPADAthoe0PWPTqi78LTcNbt5btt9DM9wbA\n BUVQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1703455326; x=1704060126;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=RXV/8pqaCxI+/nmizlhJ+DLtzJEy/7iURxiM1fsDVEM=;\n b=cfqU7vCL3uxPSkunwIcbelg3Y7umdj0i20L/p5ZqpSnHKG/6zNAa13CLFDXF86KVvx\n T9X8vu/6PvCB3HB/hf9h5UvTlOj2jLMF9I1+CzN1c7B/KQp2j7lOCQoK0+TEKslnBt4g\n ZqcbdKjehWxM7upLOArEEOk2eIqd13qqFV/4QczZkh7d6cHsTtPA2DngotqKfMa2hmaV\n o1ijZeH2/iNapFghXYh6NCTmp3FAvB73MDTU83BUCKV7E7dj04Xvqkm0Bk+D4toAJ4P8\n yBaOuNA3cNNxnRKhbothDjYAZHjyXkzulNoVbwM7nZfyA0r3d6VD/T6SpQTK12b3ZTHi\n fQRg==", "X-Gm-Message-State": "AOJu0Yy8fDvuG41BuN/E4BCcaYDpzIflq35SE9dSA96CIHkietMdUllx\n SSKbwfmeqwxO5+PZzrXFE13rxEuqcAPw5A==", "X-Google-Smtp-Source": "\n AGHT+IHpCZolmxEz4ZSeDTpvWTbJnfWk0ugpPQR6fbtdPaYLnkPkDhfhqIkzY65ojS/rBrH3kx9AtQ==", "X-Received": "by 2002:a05:620a:108a:b0:77e:fba3:757e with SMTP id\n g10-20020a05620a108a00b0077efba3757emr5731221qkk.118.1703455326414;\n Sun, 24 Dec 2023 14:02:06 -0800 (PST)", "From": "Jonathan Erb <jonathan.erb@threater.com>", "To": "ciara.power@intel.com", "Cc": "dev@dpdk.org,\n\tJonathan Erb <jonathan.erb@threater.com>", "Subject": "[PATCH v2 1/2] telemetry: correct json empty dictionaries", "Date": "Sun, 24 Dec 2023 17:02:00 -0500", "Message-Id": "<20231224220201.762377-1-jonathan.erb@threater.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 05 Jan 2024 10:03:03 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix to allow telemetry to handle empty dictionaries correctly.\n\nThis patch resolves an issue where empty dictionaries are reported\nby telemetry as '[]' rather than '{}'. Initializing the output\nbuffer based on the container type resolves the issue.\n\nSigned-off-by: Jonathan Erb <jonathan.erb@threater.com>\n---\n .mailmap | 2 +-\n lib/telemetry/telemetry.c | 6 +++++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex ab0742a382..a3302ba7a1 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -675,7 +675,7 @@ John Ousterhout <ouster@cs.stanford.edu>\n John Romein <romein@astron.nl>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n-Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n+Jonathan Erb <jonathan.erb@threater.com>\n Jonathan Tsai <jonathan1.tsai@intel.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 92982842a8..0788a32210 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -169,7 +169,11 @@ container_to_json(const struct rte_tel_data *d, char *out_buf, size_t buf_len)\n \t\td->type != TEL_ARRAY_INT && d->type != TEL_ARRAY_STRING)\n \t\treturn snprintf(out_buf, buf_len, \"null\");\n \n-\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\tif (d->type == RTE_TEL_DICT)\n+\t\tused = rte_tel_json_empty_obj(out_buf, buf_len, 0);\n+\telse\n+\t\tused = rte_tel_json_empty_array(out_buf, buf_len, 0);\n+\n \tif (d->type == TEL_ARRAY_UINT)\n \t\tfor (i = 0; i < d->data_len; i++)\n \t\t\tused = rte_tel_json_add_array_uint(out_buf,\n", "prefixes": [ "v2", "1/2" ] }