Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 135979,
    "url": "http://patchwork.dpdk.org/api/patches/135979/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com",
    "date": "2024-01-19T11:40:00",
    "name": "lib/telemetry:fix telemetry conns leak in case of socket write fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fa64d47287baf7ed8b4ebc9e419116a9f5eac7ac",
    "submitter": {
        "id": 3266,
        "url": "http://patchwork.dpdk.org/api/people/3266/?format=api",
        "name": "ShaoWei Sun",
        "email": "1819846787@qq.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com/mbox/",
    "series": [
        {
            "id": 30846,
            "url": "http://patchwork.dpdk.org/api/series/30846/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30846",
            "date": "2024-01-19T11:40:00",
            "name": "lib/telemetry:fix telemetry conns leak in case of socket write fail",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/30846/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/135979/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/135979/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C3D6438FD;\n\tFri, 19 Jan 2024 12:40:18 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A4F0640A75;\n\tFri, 19 Jan 2024 12:40:17 +0100 (CET)",
            "from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com\n [162.62.57.49]) by mails.dpdk.org (Postfix) with ESMTP id 09D0C4029F\n for <dev@dpdk.org>; Fri, 19 Jan 2024 12:40:15 +0100 (CET)",
            "from localhost.localdomain ([240e:83:205:2010:a390:40ae:a390:40af])\n by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP\n id A0295A51; Fri, 19 Jan 2024 19:40:02 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1705664407; bh=7AigjmPYdPQYkxiU0Iml6upGiuKibmdjBZ9JIk4WMng=;\n h=From:To:Cc:Subject:Date;\n b=NRwKF+R+uz26pqwhH7AnyMZ4IBEze/AFRCwXMr6F0kxnQrJOmkaPOBFPz1R4RH2qF\n fZdWcKA5zTa1rSw/Z6ZMfvH/OmtpGOUWigi+8Y61S8QHHuZv3EMKI98FVvuxTeWvjV\n mrz4/QzTtmoK7bWea+wAnKjjjKOV8Wm9R9HGDMho=",
        "X-QQ-mid": "xmsmtpt1705664402tuwj8pgok",
        "Message-ID": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
        "X-QQ-XMAILINFO": "MCRX/AdJLrpeVJKwLnGB/XaBQE6bM5hFm5x36gwvzs7grqEdqHNaEKmmbwC8a7\n VTAyVTsx9JdMpcJx9H2X3vpGJ/BZPEvnb1D3qGy1VNCjYbkX+oKDq0f/LGc6eGNKuKYYc/G19JGI\n gi+LE4d+OSCh66U/ylHh82LqZaT3eWT5WaUrqPwaEbrpvq9C9ioc2ORmQ3NKejZrD9j9cRwj40yp\n GYXGubl65SOZKCRT51MwF/Q43QCSuWtC8ujqXvXGnqnlju3wOTHKLguwmpE2bDlIA+1yAYWrNfRl\n Ebx8YzxA2RxiHt4vxMzzPuG+aGNUbxDccAeuCkiwK78prBzYyM+yyYxIRk4z6yxY3UnfY9UaAKSi\n awCBsxLcVdXGsbibg/WfNlrOuLLjsOzfmW3eO0CDufl21X3Ox6O3A38T4wvnpUjNpbYsSmTlOpJB\n OJlpHZAcxAF1ZKE7MfsAzfcRaKFxWEJFfzCSt+W4WWLhmxECOx4Ql9LhJUxBqSIjX1SbmfyWj/PO\n mkj/5AR2PBq2nTB2UpiM+w4/NTv+T3c3J7yVGGVslvdtN32ARNgTnYz06Zq0tqme8fJQdKp1NBpl\n s7udQoS7B3M6I1xrhyTmwGxDmXsVzCEukloXC25NqzBJqN2T25E4l+9aqz1DSjHsjNEcrqIjVVyY\n DMrp4FAjHnTt8xYidB0oY9M4GZQO1ZWVmrX+Bfn/Sb274JS52KU32G0UL31EvUU2VuB5m6bkPOEK\n dMy3DNsdp7DSb4OSqVlR0Hlu+G/9gbzaXc1aUr+vWTnhSzP6orOaJUFEFQrvKIMBcdX/DSOSHgF6\n u0QSVzSZO+VsxBssqjY1r+ZxpndSbB601Lc7u36kYxN+yPnsnFPvwzReXz0ht3XcOx7JnMYn63qJ\n 6Q3i25xK4C5LyyJEqOVrT2Z5w5AOGUXKB68kuDMTekIRI5CZ2SyZ8iohbApu2mel3g28Fdh/PK",
        "X-QQ-XMRINFO": "OWPUhxQsoeAVDbp3OJHYyFg=",
        "From": "sunshaowei01 <1819846787@qq.com>",
        "To": "dev@dpdk.org",
        "Cc": "ciara.power@intel.com",
        "Subject": "[PATCH] lib/telemetry:fix telemetry conns leak in case of socket\n write fail",
        "Date": "Fri, 19 Jan 2024 19:40:00 +0800",
        "X-OQ-MSGID": "<20240119114000.67384-1-1819846787@qq.com>",
        "X-Mailer": "git-send-email 2.37.1 (Apple Git-137.1)",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Telemetry can only create 10 conns by default, each of which is processed\nby a thread.\n\nWhen a thread fails to write using socket, the thread will end directly\nwithout reducing the total number of conns.\n\nThis will result in the machine running for a long time, and if there are\n10 failures, the telemetry will be unavailable\n\nSigned-off-by: sunshaowei01 <1819846787@qq.com>\n---\n lib/telemetry/telemetry.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 31e2391867..0b00c04090 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -378,8 +378,8 @@ client_handler(void *sock_id)\n \t\t\t\"{\\\"version\\\":\\\"%s\\\",\\\"pid\\\":%d,\\\"max_output_len\\\":%d}\",\n \t\t\ttelemetry_version, getpid(), MAX_OUTPUT_LEN);\n \tif (write(s, info_str, strlen(info_str)) < 0) {\n-\t\tclose(s);\n-\t\treturn NULL;\n+\t\tTMTY_LOG_LINE(ERR, \"Socket write base info to client failed\");\n+\t\tgoto exit;\n \t}\n \n \t/* receive data is not null terminated */\n@@ -404,6 +404,7 @@ client_handler(void *sock_id)\n \n \t\tbytes = read(s, buffer, sizeof(buffer) - 1);\n \t}\n+exit:\n \tclose(s);\n \trte_atomic_fetch_sub_explicit(&v2_clients, 1, rte_memory_order_relaxed);\n \treturn NULL;\n",
    "prefixes": []
}