Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 135988,
    "url": "http://patchwork.dpdk.org/api/patches/135988/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_B60C0D44A22BD9086CDAD53966C870E0DB0A@qq.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_B60C0D44A22BD9086CDAD53966C870E0DB0A@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_B60C0D44A22BD9086CDAD53966C870E0DB0A@qq.com",
    "date": "2024-01-19T16:12:05",
    "name": "lib/telemetry:fix telemetry conns leak in case of socket write fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fa64d47287baf7ed8b4ebc9e419116a9f5eac7ac",
    "submitter": {
        "id": 3266,
        "url": "http://patchwork.dpdk.org/api/people/3266/?format=api",
        "name": "ShaoWei Sun",
        "email": "1819846787@qq.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_B60C0D44A22BD9086CDAD53966C870E0DB0A@qq.com/mbox/",
    "series": [
        {
            "id": 30855,
            "url": "http://patchwork.dpdk.org/api/series/30855/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30855",
            "date": "2024-01-19T16:12:05",
            "name": "lib/telemetry:fix telemetry conns leak in case of socket write fail",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/30855/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/135988/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/135988/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08AE643900;\n\tFri, 19 Jan 2024 17:12:21 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 821644029F;\n\tFri, 19 Jan 2024 17:12:20 +0100 (CET)",
            "from out203-205-251-66.mail.qq.com (out203-205-251-66.mail.qq.com\n [203.205.251.66])\n by mails.dpdk.org (Postfix) with ESMTP id 6B75540279\n for <dev@dpdk.org>; Fri, 19 Jan 2024 17:12:18 +0100 (CET)",
            "from localhost.localdomain\n ([2408:8207:1851:a300:71c7:2812:f2e:cd5c])\n by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP\n id 308B0249; Sat, 20 Jan 2024 00:12:08 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1705680730; bh=pGICy/8s7IpoKmeLEKbXOz1w0JmxUm6XzrrOnQl0APE=;\n h=From:To:Cc:Subject:Date;\n b=J7i08Lg1gbaK5h3kFW4xtITSBPCSnX2Imvw4D0o0PjcDczj/ON+DkllWoWqVJwCZw\n kFKlFUNgouFSGS4I8uKs2cdQOn4i+84GYRReeI9CDaaxn4L2eZOD26561Q/K3Npftc\n y0Gdpue+vdAK/zgEGuHrJqhiFyE46ONesGQDAF1I=",
        "X-QQ-mid": "xmsmtpt1705680728to8vnqo02",
        "Message-ID": "<tencent_B60C0D44A22BD9086CDAD53966C870E0DB0A@qq.com>",
        "X-QQ-XMAILINFO": "N2DE1hXbKkmsQuAB4f6z+Jutx5nTl7FWAfIEqdyZxcSvL0aoGv1OMxrM2fjgDa\n LLOkZGBpkxaSj6jCCkKIBnIpxpMkg5IQh4VjKUwgOwHoIWLa3XaI2kRCWowoM0qDnvSjbkmPTTHh\n ILGY9s7Y/gQ2Vwn4tZUru5PKa9xXhVAEjH6dzXuKHatLY7XVsjjIDCHiYHeAKWsBVGX7EFs7tI7y\n nLBhMjyy9W63WK96ePjwBx4bHDFKB28a8+2itmm2sWGh0i0yg6wdOKHFrKHEz4vJ+Hw5L9G5wQAb\n zaUsE9GjxPhlWe/y5QhZA4k0l4yjbP59BhOLD0S2xUkN0tkikLwkpEpt3Lsoqf6sOg+GbdQF/oIn\n 8RwsaFnr/N4WPa3I72DLd6xvFfwdW0+/AhzUh184xg/hIOnU5PsGxdeVUXl6GJBmWpOnC7f6G4ZE\n 3fTDHXxCLe9dh9uVB1pZDIvrRKPRQXF6M9B1KP2Lcxz5yMQ4nIxfq2Ppj8qLQJHkqBLSpBh87qy6\n VtW3g66ZB0Us72WcaQjcjPf+DNE0u4WZKLAS6L9a7e/aewqUZlrsdY6pY+AaOJUHjbjKqEgQIYdX\n qEXa21jom2J5RpnKFiqimzLyxgvx6Mp+ney7uOD4nejd/GzSQJ5j/yFUhf/73dzI6ypWbRr9cyz4\n 7kIop4FVlGqCKgfTjs8Rb+cXydd39x332LOcufL/Ag9pQ04d23LBdacHi4VNSbSEoyAHZkR0aQXM\n uXny/+enjJBakdMAvi8MUiksRbhzFJyNVIVQSjGZTr7/JBTEXOu5DHJp48ijib1IkEBU+6RkHLR0\n WjJOMawN/cYiZrmXFvY6vxpJncjklNR/DydCqteTnout0FVdtarm3owuBpHgmoOuMVf12xyqzR5d\n dj4iOALgxNpuv6xMKOR1Kmmc001eVkX+NzhoG4YB1zYwFjmlgehWnwssi7262MLFVA6GG/88ttih\n 5IKH6NJ14qL3P14ToRfEmOTNX0Qh6T8lsz3+cAS+bQpWrjRFNDlmkrwKnMvTVnwGod16GM9uo7OW\n d+o2Zgkg==",
        "X-QQ-XMRINFO": "Mp0Kj//9VHAxr69bL5MkOOs=",
        "From": "sunshaowei01 <1819846787@qq.com>",
        "To": "dev@dpdk.org",
        "Cc": "ciara.power@intel.com,\n\tShaowei Sun <1819846787@qq.com>",
        "Subject": "[PATCH] lib/telemetry:fix telemetry conns leak in case of socket\n write fail",
        "Date": "Sat, 20 Jan 2024 00:12:05 +0800",
        "X-OQ-MSGID": "<20240119161205.75888-1-1819846787@qq.com>",
        "X-Mailer": "git-send-email 2.37.1 (Apple Git-137.1)",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Telemetry can only create 10 conns by default, each of which is processed\nby a thread.\n\nWhen a thread fails to write using socket, the thread will end directly\nwithout reducing the total number of conns.\n\nThis will result in the machine running for a long time, and if there are\n10 failures, the telemetry will be unavailable\n\nFixes: 6dd571fd07c3 (\"telemetry: introduce new functionality\")\n\nSigned-off-by: Shaowei Sun <1819846787@qq.com>\n---\n lib/telemetry/telemetry.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 31e2391867..0b00c04090 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -378,8 +378,8 @@ client_handler(void *sock_id)\n \t\t\t\"{\\\"version\\\":\\\"%s\\\",\\\"pid\\\":%d,\\\"max_output_len\\\":%d}\",\n \t\t\ttelemetry_version, getpid(), MAX_OUTPUT_LEN);\n \tif (write(s, info_str, strlen(info_str)) < 0) {\n-\t\tclose(s);\n-\t\treturn NULL;\n+\t\tTMTY_LOG_LINE(ERR, \"Socket write base info to client failed\");\n+\t\tgoto exit;\n \t}\n \n \t/* receive data is not null terminated */\n@@ -404,6 +404,7 @@ client_handler(void *sock_id)\n \n \t\tbytes = read(s, buffer, sizeof(buffer) - 1);\n \t}\n+exit:\n \tclose(s);\n \trte_atomic_fetch_sub_explicit(&v2_clients, 1, rte_memory_order_relaxed);\n \treturn NULL;\n",
    "prefixes": []
}