Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136008,
    "url": "http://patchwork.dpdk.org/api/patches/136008/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_0E9C5D9023884C2CBEC35057A4B392834006@qq.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_0E9C5D9023884C2CBEC35057A4B392834006@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_0E9C5D9023884C2CBEC35057A4B392834006@qq.com",
    "date": "2024-01-20T08:58:32",
    "name": "[v2] lib/telemetry:fix telemetry conns leak in case of socket write fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fa64d47287baf7ed8b4ebc9e419116a9f5eac7ac",
    "submitter": {
        "id": 3266,
        "url": "http://patchwork.dpdk.org/api/people/3266/?format=api",
        "name": "ShaoWei Sun",
        "email": "1819846787@qq.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_0E9C5D9023884C2CBEC35057A4B392834006@qq.com/mbox/",
    "series": [
        {
            "id": 30865,
            "url": "http://patchwork.dpdk.org/api/series/30865/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30865",
            "date": "2024-01-20T08:58:32",
            "name": "[v2] lib/telemetry:fix telemetry conns leak in case of socket write fail",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/30865/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/136008/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/136008/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C0BD43909;\n\tSat, 20 Jan 2024 09:58:47 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 071FD402AE;\n\tSat, 20 Jan 2024 09:58:47 +0100 (CET)",
            "from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com\n [162.62.57.49]) by mails.dpdk.org (Postfix) with ESMTP id 911F4402AA\n for <dev@dpdk.org>; Sat, 20 Jan 2024 09:58:44 +0100 (CET)",
            "from localhost.localdomain\n ([2408:8207:1851:a300:71c7:2812:f2e:cd5c])\n by newxmesmtplogicsvrszb9-1.qq.com (NewEsmtp) with SMTP\n id EA31C6DE; Sat, 20 Jan 2024 16:58:35 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1705741116; bh=pGICy/8s7IpoKmeLEKbXOz1w0JmxUm6XzrrOnQl0APE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=EmFppfiK3v9LrZb/Tnj5G6OQHgQmiyRQv7SXr/6kU/IEXfpKr0dHAplLpb3MQEMyg\n z9b8CKyHChGz6vYYgT1yxIjjWr+GyjiUMpRdtWNfzkVe1hDHF5aiFZjDUzwl6ZUthW\n oaD6jNAr5Ryyo0Hunv+5XTKGbBCKKma8UTSVjSJA=",
        "X-QQ-mid": "xmsmtpt1705741115taups05qe",
        "Message-ID": "<tencent_0E9C5D9023884C2CBEC35057A4B392834006@qq.com>",
        "X-QQ-XMAILINFO": "MkHoH8gM1N8kIdNIqSVEdoyRDRDpiMvJcBPwEwgYPqsEmBsTmP9V0ruI5saMDm\n uxzHn/ztjmAo8MAOQU+0qml3KgYxcrGk9ZHgSnGMAhjXlkK4lsRp0/KJgHuLnjhZVBrcYq0l/R9t\n qFS3SAYkpmi8Cye8V7vWmEEaX/ygZ9BOpP7RmyJdxfSnBzCsHmeLUAC4GbW8wKZGt9a6v8qTjI7q\n YcyzRBDnYwU+uheYr2t7fwPgBVmM2M7yeLAmUV4ICqmdq/xkhuFSVul0qvtiG9Th3roK9QrWHuvS\n 0hsHDV6+H1I+YKRj06klpg4kTttqpV89we/TTFKMlgqFwbu4tRlHd1BMwt6MXceDvjOD8BDrxWMh\n RfRWsvt7CJCuy7RJ/JRIQOtLlPVesTQKbSfQN6lXNapVApY6ZmDfeIpEVnP6Zz7SgtBHZAgls6Cr\n Z+FwBhLm3lGnYKSS8qZkbv2RBpQPlvmLZ7T8465qXKihz3T2gbOSAiI/8Du6lXXLozCWfBSa3hOV\n fbRPkAK2oVqCoQANS0Qz46RVjOM5cz8WksVOQakGHmvoCSEtUcY+QRTxLxoYJf9MqJojVwZY67Pj\n rtxULBaLFNFj7duJRePZQsueon7CtRZL5L8BYsyt2tvzUNEpQHniZRYtWjp3MEkfejhKaIbawEak\n KQUhHQFtXwkqKJQkSWwAYkcn/u6ikEdhC64ZrR3B6ylkifWxEWmYsMbHOFAoWQiSgtfG0WScDBg5\n 5i6LzykCEWnjxBbniSKP1koj2dJuXPFaYYa1JK8Zr4jZOASYTW2Fzv5g4U7nD1+oM4QFDoLQQrJb\n UwGQttpxdPN62ZQ+9mFCTN27AK0uZqLQ1+6RWhkpEQOTf0uT5otOZUO7M/24erJ/BQ7np6edXyOJ\n aSOQFZPic9kEbrnFfmRIIvw+aaInf3SpX5tHFJz9kyC99E3VpIEVDvbtsQCEJjwGoE97fGyqFgIk\n inSQoRk1yDxIDVJ9t+orLAfVumWxkiBjBDj1IdFsL+8tTodxucEc7HA52uk/+3SnHF+PePeUOkzs\n T9EQBxNg1PbRoAK04FcTN2/QGMR31aMpZv4tCUYRXk+B/CbTJc0r/mU1HxgvMZBJe0PcbqzDuWCc\n 7F4RJfPvu2OzmdFJU=",
        "X-QQ-XMRINFO": "OWPUhxQsoeAVDbp3OJHYyFg=",
        "From": "Shaowei Sun <1819846787@qq.com>",
        "To": "dev@dpdk.org",
        "Cc": "ciara.power@intel.com",
        "Subject": "[PATCH] [v2]lib/telemetry:fix telemetry conns leak in case of socket\n write fail",
        "Date": "Sat, 20 Jan 2024 16:58:32 +0800",
        "X-OQ-MSGID": "<20240120085832.19599-1-1819846787@qq.com>",
        "X-Mailer": "git-send-email 2.37.1 (Apple Git-137.1)",
        "In-Reply-To": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
        "References": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Telemetry can only create 10 conns by default, each of which is processed\nby a thread.\n\nWhen a thread fails to write using socket, the thread will end directly\nwithout reducing the total number of conns.\n\nThis will result in the machine running for a long time, and if there are\n10 failures, the telemetry will be unavailable\n\nFixes: 6dd571fd07c3 (\"telemetry: introduce new functionality\")\n\nSigned-off-by: Shaowei Sun <1819846787@qq.com>\n---\n lib/telemetry/telemetry.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 31e2391867..0b00c04090 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -378,8 +378,8 @@ client_handler(void *sock_id)\n \t\t\t\"{\\\"version\\\":\\\"%s\\\",\\\"pid\\\":%d,\\\"max_output_len\\\":%d}\",\n \t\t\ttelemetry_version, getpid(), MAX_OUTPUT_LEN);\n \tif (write(s, info_str, strlen(info_str)) < 0) {\n-\t\tclose(s);\n-\t\treturn NULL;\n+\t\tTMTY_LOG_LINE(ERR, \"Socket write base info to client failed\");\n+\t\tgoto exit;\n \t}\n \n \t/* receive data is not null terminated */\n@@ -404,6 +404,7 @@ client_handler(void *sock_id)\n \n \t\tbytes = read(s, buffer, sizeof(buffer) - 1);\n \t}\n+exit:\n \tclose(s);\n \trte_atomic_fetch_sub_explicit(&v2_clients, 1, rte_memory_order_relaxed);\n \treturn NULL;\n",
    "prefixes": [
        "v2"
    ]
}