Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136101/?format=api
{ "id": 136101, "url": "http://patchwork.dpdk.org/api/patches/136101/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240124120450.546364-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240124120450.546364-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240124120450.546364-1-david.marchand@redhat.com", "date": "2024-01-24T12:04:49", "name": "lib: remove duplicate prefix in logs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9230d48d4c430ca7a83efc1394159fb8c795fa7a", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240124120450.546364-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 30898, "url": "http://patchwork.dpdk.org/api/series/30898/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30898", "date": "2024-01-24T12:04:49", "name": "lib: remove duplicate prefix in logs", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30898/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136101/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136101/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EA79439B5;\n\tWed, 24 Jan 2024 13:05:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3FFE740294;\n\tWed, 24 Jan 2024 13:05:19 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 15E9E4026F\n for <dev@dpdk.org>; Wed, 24 Jan 2024 13:05:18 +0100 (CET)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-kubC0j6APb68P4KvboVHzw-1; Wed,\n 24 Jan 2024 07:05:12 -0500", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8799E29AB3FD;\n Wed, 24 Jan 2024 12:05:11 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.95])\n by smtp.corp.redhat.com (Postfix) with ESMTP id A26DF1C060AF;\n Wed, 24 Jan 2024 12:05:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1706097917;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=oaTG9ryOr/oDh+MISFmDLQOgcgs/czTAe92m9N5cgxI=;\n b=c8Udknztc1gEnnB4DbUtT9fX88gj4we0hpqr7BbeMm7k3/1NV3xzhvNfQMoJbSIVW84noM\n lQquOJbzq+oGMGuxrGCH9P9yCOfvtHbpqtypK7bZkirkv1YUlfhrijm/223IlJyuoRmNDl\n QR9+bOucmWkGFZOFkWDMva+ZKvSERZ8=", "X-MC-Unique": "kubC0j6APb68P4KvboVHzw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas@monjalon.net>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Elena Agostini <eagostini@nvidia.com>, Jerin Jacob <jerinj@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Zhirun Yan <zhirun.yan@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Ciara Power <ciara.power@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbox@nvidia.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH] lib: remove duplicate prefix in logs", "Date": "Wed, 24 Jan 2024 13:04:49 +0100", "Message-ID": "<20240124120450.546364-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_LOG() macros prefixe the log messages based on the logtype.\nThis results in logs like:\n\nTMTY: TELEMETRY: Attempting socket bind to path '/run/user/...'\nTMTY: TELEMETRY: Socket creation and binding ok\nTMTY: TELEMETRY: Telemetry initialized ok\n\nRemove redundancy in some libraries following their conversion to\nRTE_LOG/RTE_LOG_LINE.\n\nFixes: 97433132c2ed (\"lib: use per line logging in helpers\")\nFixes: 0e21c7c07d62 (\"lib: replace logging helpers\")\n\nReported-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/dmadev/rte_dmadev.c | 3 +--\n lib/gpudev/gpudev.c | 3 +--\n lib/graph/graph_private.h | 2 +-\n lib/node/node_private.h | 2 +-\n lib/telemetry/telemetry.c | 4 ++--\n lib/vhost/vhost.h | 6 +++---\n 6 files changed, 9 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c\nindex 5953a77bd6..dbaa14f262 100644\n--- a/lib/dmadev/rte_dmadev.c\n+++ b/lib/dmadev/rte_dmadev.c\n@@ -35,8 +35,7 @@ RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO);\n #define RTE_LOGTYPE_DMA rte_dma_logtype\n \n #define RTE_DMA_LOG(level, ...) \\\n-\tRTE_LOG_LINE(level, DMA, RTE_FMT(\"dma: \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n-\t\tRTE_FMT_TAIL(__VA_ARGS__ ,)))\n+\tRTE_LOG_LINE(level, DMA, \"\" __VA_ARGS__)\n \n int\n rte_dma_dev_max(size_t dev_max)\ndiff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c\nindex de8291151f..1c2011b856 100644\n--- a/lib/gpudev/gpudev.c\n+++ b/lib/gpudev/gpudev.c\n@@ -20,8 +20,7 @@ RTE_LOG_REGISTER_DEFAULT(gpu_logtype, NOTICE);\n #define RTE_LOGTYPE_GPUDEV gpu_logtype\n \n #define GPU_LOG(level, ...) \\\n-\tRTE_LOG_LINE(level, GPUDEV, RTE_FMT(\"gpu: \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n-\t\tRTE_FMT_TAIL(__VA_ARGS__ ,)))\n+\tRTE_LOG_LINE(level, GPUDEV, \"\" __VA_ARGS__)\n \n /* Set any driver error as EPERM */\n #define GPU_DRV_RET(function) \\\ndiff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex f9274ce96c..fb88d4bc84 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -22,7 +22,7 @@ extern int rte_graph_logtype;\n \n #define GRAPH_LOG(level, ...) \\\n \tRTE_LOG_LINE(level, GRAPH, \\\n-\t\tRTE_FMT(\"GRAPH: %s():%u \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n+\t\tRTE_FMT(\"%s():%u \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n \t\t\t__func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__ ,)))\n \n #define graph_err(...) GRAPH_LOG(ERR, __VA_ARGS__)\ndiff --git a/lib/node/node_private.h b/lib/node/node_private.h\nindex 845fdaa12e..73563e4cd2 100644\n--- a/lib/node/node_private.h\n+++ b/lib/node/node_private.h\n@@ -15,7 +15,7 @@ extern int rte_node_logtype;\n \n #define NODE_LOG(level, node_name, ...) \\\n \tRTE_LOG_LINE(level, NODE, \\\n-\t\tRTE_FMT(\"NODE %s: %s():%u \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n+\t\tRTE_FMT(\"%s: %s():%u \" RTE_FMT_HEAD(__VA_ARGS__ ,), \\\n \t\t\tnode_name, __func__, __LINE__, \\\n \t\t\tRTE_FMT_TAIL(__VA_ARGS__ ,)))\n \ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 31e2391867..47846ef868 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -56,8 +56,8 @@ static const char *socket_dir; /* runtime directory */\n static rte_cpuset_t *thread_cpuset;\n \n RTE_LOG_REGISTER_DEFAULT(logtype, WARNING);\n-#define RTE_LOGTYPE_TMTY logtype\n-#define TMTY_LOG_LINE(l, ...) RTE_LOG_LINE(l, TMTY, \"TELEMETRY: \" __VA_ARGS__)\n+#define RTE_LOGTYPE_TELEMETRY logtype\n+#define TMTY_LOG_LINE(l, ...) RTE_LOG_LINE(l, TELEMETRY, \"\" __VA_ARGS__)\n \n /* list of command callbacks, with one command registered by default */\n static struct cmd_callback *callbacks;\ndiff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 470dadbba6..0b13374980 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -678,10 +678,10 @@ extern int vhost_data_log_level;\n #define RTE_LOGTYPE_VHOST_DATA vhost_data_log_level\n \n #define VHOST_CONFIG_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_LINE(level, VHOST_CONFIG, \"VHOST_CONFIG: (%s) \" fmt, prefix, ##args)\n+\tRTE_LOG_LINE(level, VHOST_CONFIG, \"(%s) \" fmt, prefix, ##args)\n \n #define VHOST_DATA_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_DP_LINE(level, VHOST_DATA, \"VHOST_DATA: (%s) \" fmt, prefix, ##args)\n+\tRTE_LOG_DP_LINE(level, VHOST_DATA, \"(%s) \" fmt, prefix, ##args)\n \n #ifdef RTE_LIBRTE_VHOST_DEBUG\n #define VHOST_MAX_PRINT_BUFF 6072\n@@ -700,7 +700,7 @@ extern int vhost_data_log_level;\n \t} \\\n \tsnprintf(packet + strnlen(packet, VHOST_MAX_PRINT_BUFF), VHOST_MAX_PRINT_BUFF - strnlen(packet, VHOST_MAX_PRINT_BUFF), \"\\n\"); \\\n \t\\\n-\tRTE_LOG_DP(DEBUG, VHOST_DATA, \"VHOST_DATA: (%s) %s\", dev->ifname, packet); \\\n+\tRTE_LOG_DP(DEBUG, VHOST_DATA, \"(%s) %s\", dev->ifname, packet); \\\n } while (0)\n #else\n #define PRINT_PACKET(device, addr, size, header) do {} while (0)\n", "prefixes": [] }