Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136208,
    "url": "http://patchwork.dpdk.org/api/patches/136208/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_39DA29090964DA893A7ACB80E04F0D1D470A@qq.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<tencent_39DA29090964DA893A7ACB80E04F0D1D470A@qq.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/tencent_39DA29090964DA893A7ACB80E04F0D1D470A@qq.com",
    "date": "2024-01-30T01:57:04",
    "name": "[v3] lib/telemetry:fix telemetry conns leak in case of socket write fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fa64d47287baf7ed8b4ebc9e419116a9f5eac7ac",
    "submitter": {
        "id": 3266,
        "url": "http://patchwork.dpdk.org/api/people/3266/?format=api",
        "name": "ShaoWei Sun",
        "email": "1819846787@qq.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/tencent_39DA29090964DA893A7ACB80E04F0D1D470A@qq.com/mbox/",
    "series": [
        {
            "id": 30934,
            "url": "http://patchwork.dpdk.org/api/series/30934/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30934",
            "date": "2024-01-30T01:57:04",
            "name": "[v3] lib/telemetry:fix telemetry conns leak in case of socket write fail",
            "version": 3,
            "mbox": "http://patchwork.dpdk.org/series/30934/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/136208/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/136208/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF3B443A04;\n\tTue, 30 Jan 2024 02:57:18 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B2825402C2;\n\tTue, 30 Jan 2024 02:57:18 +0100 (CET)",
            "from out203-205-221-155.mail.qq.com (out203-205-221-155.mail.qq.com\n [203.205.221.155])\n by mails.dpdk.org (Postfix) with UTF8SMTP id D10A14029A\n for <dev@dpdk.org>; Tue, 30 Jan 2024 02:57:16 +0100 (CET)",
            "from localhost.localdomain ([240e:83:205:2010:cac7:1ec8:cac7:1ec9])\n by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP\n id E4727659; Tue, 30 Jan 2024 09:57:07 +0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;\n t=1706579829; bh=E5miMliYkL2iRqAq7Kh/6yMwARf5U6var0WBF0hFW8o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=lgSaLwuBzBw69QmaOs3acw5uPfUJK5xbgs1GBC28F2cWzdrw9IqL8hAEuDyXvO2Nq\n GBTjy84wPgVleuoffEaxp4WoEazgIT5RcDi3q4Ks7gFu5nPzqitRhXr647qtv4VT+B\n HHaPoMF+FBMa8qGsMEY1IKUr+/3lLp6awkDRXS7I=",
        "X-QQ-mid": "xmsmtpt1706579827ty96givi7",
        "Message-ID": "<tencent_39DA29090964DA893A7ACB80E04F0D1D470A@qq.com>",
        "X-QQ-XMAILINFO": "NvKyM24IHTKSPGrgOEoK1R0CK8ZNvy5dcIlxaoa5s1PEkHNtYkrRAep014DfIN\n XUKX5zzmjkeNKQAFP0pj7j3VnJRMFe39VG/4IhiowYhGf0cUmequimch4K8vDYiCG+/OBiz+BiXj\n UI2qlJJypGvBaFdD88v/QHHUWJ1FeqyTrxLMue9Ue6/niv3+oQ6EM+Fd+F8IwQ180ivpYDOD1Qlt\n znZLHk22RALb6RAIq2y656J5Nn9vol8h7Ncry9bxbYTN3r4nyX8kGwSc9jJtpFA/J49IxXODU/6D\n GDP8dtTjD8TxESu7lrFDGj9sUdK392Zdi26C4wW2jx2nl4NyvgeYEgP0tIemEC4v4M5zJMTNACPW\n JueUNO1A2G+qeqK/+iSUUQNRLxMxkKi1Ozu44MLrhYI6/Ge+Ea9Ftj9PO5fxsCSJJx9p4/Pizp9x\n GoCuFeeabRpcIehHX9VUA7kqGwnK8nvEZ7MUEQ4/Zu6hNHhY892QbcbYSl4QP9ykhPpVpSmX6Tf2\n a9UMMnthFl5SbH8qS+w6nu9bKR3Jp0cFVqRGtEukYo/JEG26SsnqDI7E/exn74DKF5veKE1HAIM/\n i6QeDVlihfq8ohULI4NdRcHiwGNtu4ZSw4/lvADVlxWoqksF7noQUy9mzhrnx1bW6t2pBxy6V39l\n B0DL5UkRaROQbClB1UytHDNjsUe4SRMA2ed40InwYuXYbcRe69HaRk6cYK55e34brZOmv/kV1K6o\n t/LT93hotwDzHh3s4cAUEWrXypu1U+asd1CjVtTtQ1OKiJ1SG/XhZ5gKv1B9WDY7/8rYT4aP/V4e\n +BbWp0j9sMuYWFOGu1A1vSOKL6xHWAvoGl70e4cQo6IDMWr9Wz0ES+luOPOIUrD1/Q2y68Hb7X7W\n mx/JMJs9txVrxPXpui3FK+9TjIrWK0RcRAuplHeuTPGYYRNbQJwVNaiuHrSWjJkWtbPfwZq4s7u2\n 0ylRHk1IY=",
        "X-QQ-XMRINFO": "Mp0Kj//9VHAxr69bL5MkOOs=",
        "From": "Shaowei Sun <1819846787@qq.com>",
        "To": "dev@dpdk.org",
        "Cc": "ciara.power@intel.com, Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>",
        "Subject": "[PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket\n write fail",
        "Date": "Tue, 30 Jan 2024 09:57:04 +0800",
        "X-OQ-MSGID": "<20240130015704.8019-1-1819846787@qq.com>",
        "X-Mailer": "git-send-email 2.37.1 (Apple Git-137.1)",
        "In-Reply-To": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
        "References": "<tencent_69E4B1D2B6C0865DA223940C173EC4904506@qq.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Telemetry can only create 10 conns by default, each of which is processed\nby a thread.\n\nWhen a thread fails to write using socket, the thread will end directly\nwithout reducing the total number of conns.\n\nThis will result in the machine running for a long time, and if there are\n10 failures, the telemetry will be unavailable\n\nFixes: 6dd571fd07c3 (\"telemetry: introduce new functionality\")\n\nSigned-off-by: Shaowei Sun <1819846787@qq.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n lib/telemetry/telemetry.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex 31e2391867..0b00c04090 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -378,8 +378,8 @@ client_handler(void *sock_id)\n \t\t\t\"{\\\"version\\\":\\\"%s\\\",\\\"pid\\\":%d,\\\"max_output_len\\\":%d}\",\n \t\t\ttelemetry_version, getpid(), MAX_OUTPUT_LEN);\n \tif (write(s, info_str, strlen(info_str)) < 0) {\n-\t\tclose(s);\n-\t\treturn NULL;\n+\t\tTMTY_LOG_LINE(ERR, \"Socket write base info to client failed\");\n+\t\tgoto exit;\n \t}\n \n \t/* receive data is not null terminated */\n@@ -404,6 +404,7 @@ client_handler(void *sock_id)\n \n \t\tbytes = read(s, buffer, sizeof(buffer) - 1);\n \t}\n+exit:\n \tclose(s);\n \trte_atomic_fetch_sub_explicit(&v2_clients, 1, rte_memory_order_relaxed);\n \treturn NULL;\n",
    "prefixes": [
        "v3"
    ]
}