Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136237/?format=api
{ "id": 136237, "url": "http://patchwork.dpdk.org/api/patches/136237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240131174552.2601531-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240131174552.2601531-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240131174552.2601531-1-david.marchand@redhat.com", "date": "2024-01-31T17:45:51", "name": "[1/2] build: fix reasons conflict", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c82de1c52a47da9453eb21efe98a032135d8243", "submitter": { "id": 1173, "url": "http://patchwork.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240131174552.2601531-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 30955, "url": "http://patchwork.dpdk.org/api/series/30955/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=30955", "date": "2024-01-31T17:45:51", "name": "[1/2] build: fix reasons conflict", "version": 1, "mbox": "http://patchwork.dpdk.org/series/30955/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136237/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136237/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3065C43A22;\n\tWed, 31 Jan 2024 18:46:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 19CF042DA1;\n\tWed, 31 Jan 2024 18:46:03 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id D436D402ED\n for <dev@dpdk.org>; Wed, 31 Jan 2024 18:46:00 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-650-GOC1_rilMeWrdw3tuW4bUA-1; Wed, 31 Jan 2024 12:45:57 -0500", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8EA8085A58B;\n Wed, 31 Jan 2024 17:45:56 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.95])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3CD912166B08;\n Wed, 31 Jan 2024 17:45:55 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1706723160;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=604kyxMPtixIYh3pP8OkU/VgeAwo0vGZAzHrSPZL1pI=;\n b=Vv/GKTNAIK/Qp7fmw5BmUp0LuYrIpp6oZ0+5T9XlosIKcYwhWGRUxKlfCwwAc+b3NZWKPU\n tbG7xZu32LcKIk556Eb3NSWC9/hxOGgTs0uOzZ87+nh75bc192OLY2+sRI2arHOBssvJ2a\n 7UmOfiObONp8Rv6f96W7FqU72XqHsIM=", "X-MC-Unique": "GOC1_rilMeWrdw3tuW4bUA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Kai Ji <kai.ji@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Markus Theil <markus.theil@tu-ilmenau.de>", "Subject": "[PATCH 1/2] build: fix reasons conflict", "Date": "Wed, 31 Jan 2024 18:45:51 +0100", "Message-ID": "<20240131174552.2601531-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The \"_disable_reason\" variables are subject to naming conflicts.\n\nThis has been caught while looking at mingw builds where the graph\napplication was skipped with an <unknown_reason> (which is caused by a\nmissing reason variable set in app/graph/meson.build) and the graph\nlibrary was skipped with the same <unknown_reason> too, even though\nthis library meson does set a proper reason variable.\n\nExample in GHA:\n\n=================\nContent Skipped\n=================\n\napps:\n\tdumpcap:\tnot supported on Windows\n\tgraph:\t<unknown reason>\n\tpdump:\tnot supported on Windows\n...\n\nlibs:\n\tacl:\tnot supported on Windows\n\tbbdev:\tnot supported on Windows\n...\n\tgraph:\t<unknown reason>\n\tnode:\tnot supported on Windows\n\nPrefix all those variables with the type of component.\n\nFixes: ecf75180171b (\"build: list selected applications\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/meson.build | 2 +-\n drivers/common/qat/meson.build | 10 +++++-----\n drivers/meson.build | 4 ++--\n lib/meson.build | 2 +-\n meson.build | 6 +++---\n 5 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/meson.build b/app/meson.build\nindex 8aaed59f39..21b6da29b3 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -93,7 +93,7 @@ foreach app:apps\n if not build\n if reason != ''\n dpdk_apps_disabled += app\n- set_variable(app.underscorify() + '_disable_reason', reason)\n+ set_variable('app_' + app.underscorify() + '_disable_reason', reason)\n endif\n continue\n endif\ndiff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build\nindex 5c36fbb270..62abcb6fe3 100644\n--- a/drivers/common/qat/meson.build\n+++ b/drivers/common/qat/meson.build\n@@ -17,13 +17,13 @@ qat_compress_relpath = '../../' + qat_compress_path\n if disable_drivers.contains(qat_crypto_path)\n qat_crypto = false\n dpdk_drvs_disabled += qat_crypto_path\n- set_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+ set_variable('drv_' + qat_crypto_path.underscorify() + '_disable_reason',\n 'Explicitly disabled via build config')\n endif\n if disable_drivers.contains(qat_compress_path)\n qat_compress = false\n dpdk_drvs_disabled += qat_compress_path\n- set_variable(qat_compress_path.underscorify() + '_disable_reason',\n+ set_variable('drv_' + qat_compress_path.underscorify() + '_disable_reason',\n 'Explicitly disabled via build config')\n endif\n \n@@ -36,7 +36,7 @@ if arch_subdir == 'arm'\n else\n qat_crypto = false\n dpdk_drvs_disabled += qat_crypto_path\n- set_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+ set_variable('drv_' + qat_crypto_path.underscorify() + '_disable_reason',\n 'missing dependency for Arm, libcrypto')\n endif\n else\n@@ -57,7 +57,7 @@ else\n else\n qat_crypto = false\n dpdk_drvs_disabled += qat_crypto_path\n- set_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+ set_variable('drv_' + qat_crypto_path.underscorify() + '_disable_reason',\n 'missing dependency, libipsecmb or libcrypto')\n endif\n elif libcrypto.found()\n@@ -66,7 +66,7 @@ else\n else\n qat_crypto = false\n dpdk_drvs_disabled += qat_crypto_path\n- set_variable(qat_crypto_path.underscorify() + '_disable_reason',\n+ set_variable('drv_' + qat_crypto_path.underscorify() + '_disable_reason',\n 'missing dependency, libipsecmb or libcrypto')\n endif\n endif\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 5ba534049a..f2be71bc05 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -93,7 +93,7 @@ foreach subpath:subdirs\n if skip_class\n drv_path = join_paths(class, '*')\n dpdk_drvs_disabled += drv_path\n- set_variable(drv_path.underscorify() + '_disable_reason', reason)\n+ set_variable('drv_' + drv_path.underscorify() + '_disable_reason', reason)\n continue\n endif\n endif\n@@ -199,7 +199,7 @@ foreach subpath:subdirs\n # component disable printout in those cases\n if reason != ''\n dpdk_drvs_disabled += drv_path\n- set_variable(drv_path.underscorify() + '_disable_reason', reason)\n+ set_variable('drv_' + drv_path.underscorify() + '_disable_reason', reason)\n endif\n continue\n endif\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 6c143ce5a6..55d483cd26 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -228,7 +228,7 @@ foreach l:libraries\n \n if not build\n dpdk_libs_disabled += name\n- set_variable(name.underscorify() + '_disable_reason', reason)\n+ set_variable('lib_' + name.underscorify() + '_disable_reason', reason)\n continue\n endif\n \ndiff --git a/meson.build b/meson.build\nindex 5e161f43e5..8b248d4505 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -164,17 +164,17 @@ message(output_message + '\\n')\n output_message = '\\n=================\\nContent Skipped\\n=================\\n'\n output_message += '\\napps:\\n\\t'\n foreach app:dpdk_apps_disabled\n- reason = get_variable(app.underscorify() + '_disable_reason')\n+ reason = get_variable('app_' + app.underscorify() + '_disable_reason')\n output_message += app + ':\\t' + reason + '\\n\\t'\n endforeach\n output_message += '\\nlibs:\\n\\t'\n foreach lib:dpdk_libs_disabled\n- reason = get_variable(lib.underscorify() + '_disable_reason')\n+ reason = get_variable('lib_' + lib.underscorify() + '_disable_reason')\n output_message += lib + ':\\t' + reason + '\\n\\t'\n endforeach\n output_message += '\\ndrivers:\\n\\t'\n foreach drv:dpdk_drvs_disabled\n- reason = get_variable(drv.underscorify() + '_disable_reason')\n+ reason = get_variable('drv_' + drv.underscorify() + '_disable_reason')\n output_message += drv + ':\\t' + reason + '\\n\\t'\n endforeach\n message(output_message + '\\n')\n", "prefixes": [ "1/2" ] }