Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136461/?format=api
{ "id": 136461, "url": "http://patchwork.dpdk.org/api/patches/136461/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240207031317.32293-5-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240207031317.32293-5-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240207031317.32293-5-andrew.boyer@amd.com", "date": "2024-02-07T03:13:08", "name": "[v3,04/13] net/ionic: fix missing volatile type for cqe pointers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db2bed59031efd269fcfdb6c643cd6e66dee686a", "submitter": { "id": 2861, "url": "http://patchwork.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240207031317.32293-5-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31031, "url": "http://patchwork.dpdk.org/api/series/31031/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31031", "date": "2024-02-07T03:13:04", "name": "net/ionic: miscellaneous fixes and improvements", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31031/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136461/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0320943A2A;\n\tWed, 7 Feb 2024 04:14:41 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D86A442DE9;\n\tWed, 7 Feb 2024 04:14:26 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2082.outbound.protection.outlook.com [40.107.237.82])\n by mails.dpdk.org (Postfix) with ESMTP id 99F7D42D9D;\n Wed, 7 Feb 2024 04:14:21 +0100 (CET)", "from DM6PR02CA0153.namprd02.prod.outlook.com (2603:10b6:5:332::20)\n by BY5PR12MB4274.namprd12.prod.outlook.com (2603:10b6:a03:206::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.12; Wed, 7 Feb\n 2024 03:14:19 +0000", "from CO1PEPF000044F7.namprd21.prod.outlook.com\n (2603:10b6:5:332:cafe::3d) by DM6PR02CA0153.outlook.office365.com\n (2603:10b6:5:332::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend\n Transport; Wed, 7 Feb 2024 03:14:19 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1PEPF000044F7.mail.protection.outlook.com (10.167.241.197) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7292.0 via Frontend Transport; Wed, 7 Feb 2024 03:14:19 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb\n 2024 21:14:14 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cvbmbPo0wyA45w5GpaZZSMcPKEwGc4mam2GCBiTPQqRttmVMthUeq71o02QzKaBupJqoSGPMFFRbf1MepDkxRSn6wav8TjAZ8FHSvzyl+zN/7baBNrHlsp6X3DQFfJ413AJRc0WN0lx2FpUeH3G4lanuyj7t6Iu1olCcxfP6ZFGt9EXTCprVtb1BKYamZ+x3EfrDEOqE+A+ti1ONfb0CaZyya/IVQ4fBP6QyDuy/Rl1YIuf/2MNlU/qrig+gwaGNZWdy4pVUxhFu+GNGhoi6acOHbBJqlSk+E2g+vcp11F7k9yYKOEjOBfkrnUoqU3LtjxOCoVCxZ2BxWsxkwTvJBA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=hdbNK4cDDyjob2hzNPI5WkWb16qJXwQWFqAbjSI/Qtw=;\n b=YnhcSGuWg3jjfPIsTwcRBGYKgNSPpd01jpGgiWOtX0Rhr1k0di0u921SS71x6z3ITKLWk4VKRJqZzbGvw+0tfxREHbSVvs8Cl54OWkY12JfZ6qkIW+AiIC7zFArTIRI1d3vWYNaWLwtXsmbYizmT95b9CoWGFMXy77mYP5V9/NOCaiB2TT+S7AMhWchAjU/4HheIKRxt8w/p35N35hgYcLQgo5dlk0JZDlLZNX1BdOPnbjQoxHSoLU5PauIsu8ChNBRZM8xGiUuPj5xN4WVTc96Az88EyRVjlmJpOSaCzakRXWmeA4GNvTNjLDZXak6S4KTpJcLUPdOoUUc2RII5Ww==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=hdbNK4cDDyjob2hzNPI5WkWb16qJXwQWFqAbjSI/Qtw=;\n b=JhKzfNcC3qWvcTVYsentw5upkJONj8LmhI9HlkNy5xRegog1Wf2H7ggnyiMkNos8edtKeLzOB2S0LajAcqmq4OoRpXg5IJO3acBphvWUEs95A3q+mXTsHImxB/2xLhH11KtvbUxSWYZy6ury92i4B9icFpUz+1TGCfwPd/hYP50=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Neel Patel <neel.patel@amd.com>, <stable@dpdk.org>, Andrew Boyer\n <andrew.boyer@amd.com>", "Subject": "[PATCH v3 04/13] net/ionic: fix missing volatile type for cqe\n pointers", "Date": "Tue, 6 Feb 2024 19:13:08 -0800", "Message-ID": "<20240207031317.32293-5-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240207031317.32293-1-andrew.boyer@amd.com>", "References": "<20240202193238.62669-1-andrew.boyer@amd.com>\n <20240207031317.32293-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1PEPF000044F7:EE_|BY5PR12MB4274:EE_", "X-MS-Office365-Filtering-Correlation-Id": "2a8d5ef5-d083-449a-52d2-08dc278adfbb", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n iD+H+bVgJLhxhNq6CpqZStv0wbRtjPV3m/5qWFtisn3NjuJYXqs0LcczvGOhRJ0ms5nGPQzGBr4ZAYfSfTpAsEFw4YUyOsTcW/IH2v3OxIyprCOaRdUU6DjIrdUkfW9Hop/aXOl1QlLZBwlBklL+2x/uGjPHCLP8EK+pf1MXxayDIQdfbCyLMBUfA7zDcibJfNaXX2+BgXPwONc8pDlbd1j6WTUUixOJ+XxhBjkdPkSf3WMA3lnfGA6rPDHopy79cmVUQhQfmwJuc8ZpWbXi0DImUP1ubuC6VSUe/R9LQM5BPjVKYXwKiisaBgaQvH/xknNp7/N69f5L/yFn6Ixp4s2V9jdaTcM2ypN+EypyAvSNGOVJTZK4KUFUZlYY8vTILZAR09KxeqgQ7BifNTtRGtxkQWG+ItGJVLSJ19BflWt0fsBiMgwdW9dwkEyzFem9nskouW0f2cKiC/xuM5uvXvGAYxwErWB49FWQLMfS3IZ3vULugNi99544ATpHLlCHyyXbOxDmQDJb9NrBlvwWx+FPTRSixmYAYaB2SBwNrwIzB41y0cpdbkGy8xftxnv94iEHvufOOFj8O3O5JOgn2GCpucVDy6tKJcpkfokkvVCwtqO/W+ld+y6OUITJ1++y2qGpAA5BVPFRqDx+AXDWBlwGrrXxKbohgKTaOP3hAgoopWFAFuDxExCnMBuVaMVz8NQNLzyWmJjNvr7iydnqB9h8fbB0HibWyKhtTVXIJc4LkWSwnDT0JSSLCHAthItakbtb/eEXaLlcSXdtXOT1Hg==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(396003)(346002)(136003)(376002)(230922051799003)(82310400011)(186009)(64100799003)(1800799012)(451199024)(36840700001)(40470700004)(46966006)(40460700003)(40480700001)(478600001)(5660300002)(41300700001)(2616005)(86362001)(4326008)(36756003)(2906002)(81166007)(83380400001)(426003)(450100002)(26005)(356005)(54906003)(1076003)(47076005)(16526019)(70206006)(8676002)(70586007)(44832011)(6666004)(316002)(336012)(6916009)(82740400003)(8936002)(36860700001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Feb 2024 03:14:19.0614 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2a8d5ef5-d083-449a-52d2-08dc278adfbb", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1PEPF000044F7.namprd21.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB4274", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Neel Patel <neel.patel@amd.com>\n\nThis memory may be changed by the hardware, so the volatile\nkeyword is required for correctness.\n\nFixes: e86a6fcc7cf3 (\"net/ionic: add optimized non-scattered Rx/Tx\")\ncc: stable@dpdk.org\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\nSigned-off-by: Neel Patel <neel.patel@amd.com>\n---\n drivers/net/ionic/ionic_rxtx.c | 4 ++--\n drivers/net/ionic/ionic_rxtx_sg.c | 8 +++++---\n drivers/net/ionic/ionic_rxtx_simple.c | 8 +++++---\n 3 files changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex d92b231f8f..d92fa1cca7 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -755,7 +755,7 @@ ionic_dev_rx_descriptor_status(void *rx_queue, uint16_t offset)\n {\n \tstruct ionic_rx_qcq *rxq = rx_queue;\n \tstruct ionic_qcq *qcq = &rxq->qcq;\n-\tstruct ionic_rxq_comp *cq_desc;\n+\tvolatile struct ionic_rxq_comp *cq_desc;\n \tuint16_t mask, head, tail, pos;\n \tbool done_color;\n \n@@ -794,7 +794,7 @@ ionic_dev_tx_descriptor_status(void *tx_queue, uint16_t offset)\n {\n \tstruct ionic_tx_qcq *txq = tx_queue;\n \tstruct ionic_qcq *qcq = &txq->qcq;\n-\tstruct ionic_txq_comp *cq_desc;\n+\tvolatile struct ionic_txq_comp *cq_desc;\n \tuint16_t mask, head, tail, pos, cq_pos;\n \tbool done_color;\n \ndiff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c\nindex 6c028a698c..1392342463 100644\n--- a/drivers/net/ionic/ionic_rxtx_sg.c\n+++ b/drivers/net/ionic/ionic_rxtx_sg.c\n@@ -28,7 +28,8 @@ ionic_tx_flush_sg(struct ionic_tx_qcq *txq)\n \tstruct ionic_queue *q = &txq->qcq.q;\n \tstruct ionic_tx_stats *stats = &txq->stats;\n \tstruct rte_mbuf *txm;\n-\tstruct ionic_txq_comp *cq_desc, *cq_desc_base = cq->base;\n+\tstruct ionic_txq_comp *cq_desc_base = cq->base;\n+\tvolatile struct ionic_txq_comp *cq_desc;\n \tvoid **info;\n \tuint32_t i;\n \n@@ -254,7 +255,7 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts,\n */\n static __rte_always_inline void\n ionic_rx_clean_one_sg(struct ionic_rx_qcq *rxq,\n-\t\tstruct ionic_rxq_comp *cq_desc,\n+\t\tvolatile struct ionic_rxq_comp *cq_desc,\n \t\tstruct ionic_rx_service *rx_svc)\n {\n \tstruct ionic_queue *q = &rxq->qcq.q;\n@@ -440,7 +441,8 @@ ionic_rxq_service_sg(struct ionic_rx_qcq *rxq, uint32_t work_to_do,\n \tstruct ionic_cq *cq = &rxq->qcq.cq;\n \tstruct ionic_queue *q = &rxq->qcq.q;\n \tstruct ionic_rxq_desc *q_desc_base = q->base;\n-\tstruct ionic_rxq_comp *cq_desc, *cq_desc_base = cq->base;\n+\tstruct ionic_rxq_comp *cq_desc_base = cq->base;\n+\tvolatile struct ionic_rxq_comp *cq_desc;\n \tuint32_t work_done = 0;\n \tuint64_t then, now, hz, delta;\n \ndiff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c\nindex 5969287b66..00152c885a 100644\n--- a/drivers/net/ionic/ionic_rxtx_simple.c\n+++ b/drivers/net/ionic/ionic_rxtx_simple.c\n@@ -28,7 +28,8 @@ ionic_tx_flush(struct ionic_tx_qcq *txq)\n \tstruct ionic_queue *q = &txq->qcq.q;\n \tstruct ionic_tx_stats *stats = &txq->stats;\n \tstruct rte_mbuf *txm;\n-\tstruct ionic_txq_comp *cq_desc, *cq_desc_base = cq->base;\n+\tstruct ionic_txq_comp *cq_desc_base = cq->base;\n+\tvolatile struct ionic_txq_comp *cq_desc;\n \tvoid **info;\n \n \tcq_desc = &cq_desc_base[cq->tail_idx];\n@@ -227,7 +228,7 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n */\n static __rte_always_inline void\n ionic_rx_clean_one(struct ionic_rx_qcq *rxq,\n-\t\tstruct ionic_rxq_comp *cq_desc,\n+\t\tvolatile struct ionic_rxq_comp *cq_desc,\n \t\tstruct ionic_rx_service *rx_svc)\n {\n \tstruct ionic_queue *q = &rxq->qcq.q;\n@@ -361,7 +362,8 @@ ionic_rxq_service(struct ionic_rx_qcq *rxq, uint32_t work_to_do,\n \tstruct ionic_cq *cq = &rxq->qcq.cq;\n \tstruct ionic_queue *q = &rxq->qcq.q;\n \tstruct ionic_rxq_desc *q_desc_base = q->base;\n-\tstruct ionic_rxq_comp *cq_desc, *cq_desc_base = cq->base;\n+\tstruct ionic_rxq_comp *cq_desc_base = cq->base;\n+\tvolatile struct ionic_rxq_comp *cq_desc;\n \tuint32_t work_done = 0;\n \tuint64_t then, now, hz, delta;\n \n", "prefixes": [ "v3", "04/13" ] }