Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136521/?format=api
{ "id": 136521, "url": "http://patchwork.dpdk.org/api/patches/136521/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-6-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240208085956.1741174-6-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240208085956.1741174-6-ndabilpuram@marvell.com", "date": "2024-02-08T08:59:49", "name": "[06/13] net/cnxk: fix issue with buff size compute", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ba9a64188e24d009aea9fc75c7754df7181c1173", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-6-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 31048, "url": "http://patchwork.dpdk.org/api/series/31048/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31048", "date": "2024-02-08T08:59:44", "name": "[01/13] common/cnxk: remove cn9k Inline IPsec FP opcode defines", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31048/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136521/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD71643ACC;\n\tThu, 8 Feb 2024 10:01:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3BB8E42E3F;\n\tThu, 8 Feb 2024 10:00:20 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 3167D42E30\n for <dev@dpdk.org>; Thu, 8 Feb 2024 10:00:18 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 4184GW5k000444 for <dev@dpdk.org>; Thu, 8 Feb 2024 01:00:17 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w4qsq0pu0-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 08 Feb 2024 01:00:17 -0800 (PST)", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 8 Feb 2024 01:00:15 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 8 Feb 2024 01:00:15 -0800", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 942953F7090;\n Thu, 8 Feb 2024 01:00:13 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=qmTaEijGjCnWZui+IgjuopyXv/3LMCMJRg6j0dTZTTc=; b=eWA\n TWYDw6aVVTOULy5aQbAfGHRU65uZVJeOuzb5/hbXz0C43UAIKZT1e6lCr/ZI5eDp\n yMe0BxRh+V9bW7HqitM8/8KMBNqALII2nuKZI6/Ln2e2iPziEw8a9O+sg++YfiiX\n 8h20gHNO4WGB9tr4/dXuMYIu1xtkt2JPlqEYcH4mP9+zpzsVclAuDv6G95RqIh57\n 4wt4EYPcKC24gYZ+tImkkCGCR13CGQBUqhLOfw3oTH23dT/uG8T7k3n3XPrezKUg\n whjgBqi6nycxrqMHC9jPme+aJz16UPoqGTzEk+5fdm0Icrx+6Dfpdw85JwvYHTzd\n yHogUg03lte9ilYlhlQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 06/13] net/cnxk: fix issue with buff size compute", "Date": "Thu, 8 Feb 2024 14:29:49 +0530", "Message-ID": "<20240208085956.1741174-6-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "References": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Pk991ULeqCIqi0TQnjNi9M5KhSa2Wu0B", "X-Proofpoint-GUID": "Pk991ULeqCIqi0TQnjNi9M5KhSa2Wu0B", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In case where cnxk_nix_mtu_set() is called before\ndata->min_rx_buf_size is set, use buf size from first RQ's\nmempool.\n\nFixes: 34b46320f446 (\"net/cnxk: perform early MTU setup for event mode\")\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/net/cnxk/cnxk_ethdev_ops.c | 25 ++++++++++++++++++++++---\n 1 file changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c\nindex e9ab8da781..e816884d47 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_ops.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_ops.c\n@@ -544,8 +544,9 @@ cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \tstruct rte_eth_dev_data *data = eth_dev->data;\n \tstruct roc_nix *nix = &dev->nix;\n+\tstruct cnxk_eth_rxq_sp *rxq_sp;\n+\tuint32_t buffsz = 0;\n \tint rc = -EINVAL;\n-\tuint32_t buffsz;\n \n \tframe_size += CNXK_NIX_TIMESYNC_RX_OFFSET * dev->ptp_en;\n \n@@ -561,8 +562,24 @@ cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n \t\tgoto exit;\n \t}\n \n-\tbuffsz = data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;\n-\told_frame_size = data->mtu + CNXK_NIX_L2_OVERHEAD;\n+\tif (!eth_dev->data->nb_rx_queues)\n+\t\tgoto skip_buffsz_check;\n+\n+\t/* Perform buff size check */\n+\tif (data->min_rx_buf_size) {\n+\t\tbuffsz = data->min_rx_buf_size;\n+\t} else if (eth_dev->data->rx_queues && eth_dev->data->rx_queues[0]) {\n+\t\trxq_sp = cnxk_eth_rxq_to_sp(data->rx_queues[0]);\n+\n+\t\tif (rxq_sp->qconf.mp)\n+\t\t\tbuffsz = rte_pktmbuf_data_room_size(rxq_sp->qconf.mp);\n+\t}\n+\n+\t/* Skip validation if RQ's are not yet setup */\n+\tif (!buffsz)\n+\t\tgoto skip_buffsz_check;\n+\n+\tbuffsz -= RTE_PKTMBUF_HEADROOM;\n \n \t/* Refuse MTU that requires the support of scattered packets\n \t * when this feature has not been enabled before.\n@@ -580,6 +597,8 @@ cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n \t\tgoto exit;\n \t}\n \n+skip_buffsz_check:\n+\told_frame_size = data->mtu + CNXK_NIX_L2_OVERHEAD;\n \t/* if new MTU was smaller than old one, then flush all SQs before MTU change */\n \tif (old_frame_size > frame_size) {\n \t\tif (data->dev_started) {\n", "prefixes": [ "06/13" ] }