Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136522/?format=api
{ "id": 136522, "url": "http://patchwork.dpdk.org/api/patches/136522/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-7-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240208085956.1741174-7-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240208085956.1741174-7-ndabilpuram@marvell.com", "date": "2024-02-08T08:59:50", "name": "[07/13] common/cnxk: skip setting Tx MTU separately", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "34f210fa0723c679ec090f63c40270b22b89fb36", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-7-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 31048, "url": "http://patchwork.dpdk.org/api/series/31048/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31048", "date": "2024-02-08T08:59:44", "name": "[01/13] common/cnxk: remove cn9k Inline IPsec FP opcode defines", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31048/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136522/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03FBD43ACC;\n\tThu, 8 Feb 2024 10:01:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6B13142E44;\n\tThu, 8 Feb 2024 10:00:22 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 9158642E41\n for <dev@dpdk.org>; Thu, 8 Feb 2024 10:00:20 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 4184Gl3R001166 for <dev@dpdk.org>; Thu, 8 Feb 2024 01:00:20 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w4qsq0pu9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 08 Feb 2024 01:00:19 -0800 (PST)", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 8 Feb 2024 01:00:17 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 8 Feb 2024 01:00:17 -0800", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 0A0B03F708F;\n Thu, 8 Feb 2024 01:00:15 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=SVG3OGxMfdQbvjclZmQ0itusqHjtbMGiJMspPR1US9g=; b=WkV\n ETJqm6DWptajzctQ23Z/v7KYNtyx1Q2Jk6prstidvSnUVrGtPYnl4RvbYRA6CJSg\n LIg2SLeOSAtW0iZeYUdnAyQM3Nkfk62kPmMcusZ73MsGigRF5edP1afza3mvR3yM\n 2oDQNuh56wA26WSyVOBQakgVBhVvQlrlEwBWFW1grOgbUEHAlx+2I+TIJGmFGe5A\n R1jWtUJUNGby1EwtMZTjLNq3O9Jvojgw3EaxvCotXh00GAfimg6I6p8dp9pYP0Ex\n NtrGIBTsGJTo4/ukntNwhpXVUcjBZl/CAqnNsvfV2hb1M0Z/vgSEQx6gtO3H1gGY\n yBJlFnlEOGAFNlzgTMQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 07/13] common/cnxk: skip setting Tx MTU separately", "Date": "Thu, 8 Feb 2024 14:29:50 +0530", "Message-ID": "<20240208085956.1741174-7-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "References": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "eegdQhBhfSwPetDRZtjnQi25-K8-YkZ6", "X-Proofpoint-GUID": "eegdQhBhfSwPetDRZtjnQi25-K8-YkZ6", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Skip setting Tx MTU separately as now the Tx credit configuration\nis based on max MTU possible for that link.\nAlso init MTU with max value for that port.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/common/cnxk/roc_nix.c | 2 +-\n drivers/common/cnxk/roc_nix.h | 2 --\n drivers/net/cnxk/cnxk_ethdev_ops.c | 12 +-----------\n 3 files changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c\nindex f64933a1d9..afbc3eb901 100644\n--- a/drivers/common/cnxk/roc_nix.c\n+++ b/drivers/common/cnxk/roc_nix.c\n@@ -482,7 +482,7 @@ roc_nix_dev_init(struct roc_nix *roc_nix)\n \tsdp_lbk_id_update(pci_dev, nix);\n \tnix->pci_dev = pci_dev;\n \tnix->reta_sz = reta_sz;\n-\tnix->mtu = ROC_NIX_DEFAULT_HW_FRS;\n+\tnix->mtu = roc_nix_max_pkt_len(roc_nix);\n \tnix->dmac_flt_idx = -1;\n \n \t/* Register error and ras interrupts */\ndiff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h\nindex 9d57ca0be7..3799b551f2 100644\n--- a/drivers/common/cnxk/roc_nix.h\n+++ b/drivers/common/cnxk/roc_nix.h\n@@ -267,8 +267,6 @@ struct roc_nix_eeprom_info {\n #define ROC_NIX_RSS_KEY_LEN\t 48 /* 352 Bits */\n #define ROC_NIX_RSS_MCAM_IDX_DEFAULT (-1)\n \n-#define ROC_NIX_DEFAULT_HW_FRS 1514\n-\n #define ROC_NIX_VWQE_MAX_SIZE_LOG2 11\n #define ROC_NIX_VWQE_MIN_SIZE_LOG2 2\n \ndiff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c\nindex e816884d47..4962f3bced 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_ops.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_ops.c\n@@ -610,19 +610,9 @@ cnxk_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n \n \tframe_size -= RTE_ETHER_CRC_LEN;\n \n-\t/* Update mtu on Tx */\n-\trc = roc_nix_mac_mtu_set(nix, frame_size);\n-\tif (rc) {\n-\t\tplt_err(\"Failed to set MTU, rc=%d\", rc);\n-\t\tgoto exit;\n-\t}\n-\n-\t/* Sync same frame size on Rx */\n+\t/* Set frame size on Rx */\n \trc = roc_nix_mac_max_rx_len_set(nix, frame_size);\n \tif (rc) {\n-\t\t/* Rollback to older mtu */\n-\t\troc_nix_mac_mtu_set(nix,\n-\t\t\t\t old_frame_size - RTE_ETHER_CRC_LEN);\n \t\tplt_err(\"Failed to max Rx frame length, rc=%d\", rc);\n \t\tgoto exit;\n \t}\n", "prefixes": [ "07/13" ] }