Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136526/?format=api
{ "id": 136526, "url": "http://patchwork.dpdk.org/api/patches/136526/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-11-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240208085956.1741174-11-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240208085956.1741174-11-ndabilpuram@marvell.com", "date": "2024-02-08T08:59:54", "name": "[11/13] net/cnxk: fix check cookies for multi-seg offload", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "15032adf55ad47fd0f9503da303f721720b92b5d", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240208085956.1741174-11-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 31048, "url": "http://patchwork.dpdk.org/api/series/31048/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31048", "date": "2024-02-08T08:59:44", "name": "[01/13] common/cnxk: remove cn9k Inline IPsec FP opcode defines", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31048/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136526/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136526/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 743A743ACC;\n\tThu, 8 Feb 2024 10:01:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2098242E60;\n\tThu, 8 Feb 2024 10:00:33 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8972942E52\n for <dev@dpdk.org>; Thu, 8 Feb 2024 10:00:30 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 4184HMSD003404 for <dev@dpdk.org>; Thu, 8 Feb 2024 01:00:30 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w4qsq0pva-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 08 Feb 2024 01:00:29 -0800 (PST)", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 8 Feb 2024 01:00:27 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 8 Feb 2024 01:00:27 -0800", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id EFA753F708E;\n Thu, 8 Feb 2024 01:00:25 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=BpFZBX71ipPl+FdpbR7anyEVBMX1GKBzK14n5QMkSlE=; b=K0X\n Jqe0B0ssfEulmveu5vknL2B8/r6NGkn5d+U2zmfysTPp4fO3sxmqZcrUiqLq772f\n y1TQbQtsvkD7rsw5Zra0Nk+9PEj4+udlXSHK663ALaw3mbCAA9z2pGJlTyCcRXRx\n h2jz6/jTtEZ1XIIfcP8OozW2ZWMblNZsqcwYqUBYKGElYeQuoL95djtQ7+ASmxsP\n U6cKH+YzgUjo17Kyj/XNIR2ChQzjFZQzxGTQ3TO6N4bBdwJ1MB8UE93+LDzQvkQa\n /+q4eNXlcfrPY/RlvV9c28onaHNiirj55lbx6grfWhci24YfXq6gaMZKpFMfJqBB\n VLlA6CLPQJIS5wrlWTg==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Rahul Bhansali <rbhansali@marvell.com>", "Subject": "[PATCH 11/13] net/cnxk: fix check cookies for multi-seg offload", "Date": "Thu, 8 Feb 2024 14:29:54 +0530", "Message-ID": "<20240208085956.1741174-11-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "References": "<20240208085956.1741174-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "5H8K7-HFkRGo0bNrNTwB8hKrScc-RQZz", "X-Proofpoint-GUID": "5H8K7-HFkRGo0bNrNTwB8hKrScc-RQZz", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rahul Bhansali <rbhansali@marvell.com>\n\nFix missing check cookies with multi-seg offload case\n\nFixes: 3626d5195d49 (\"net/cnxk: add multi-segment Tx for CN10K\")\n\nSigned-off-by: Rahul Bhansali <rbhansali@marvell.com>\n---\n drivers/net/cnxk/cn10k_tx.h | 21 ++++++++++++++++++++-\n 1 file changed, 20 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h\nindex 9721b7584a..a995696e66 100644\n--- a/drivers/net/cnxk/cn10k_tx.h\n+++ b/drivers/net/cnxk/cn10k_tx.h\n@@ -1863,6 +1863,9 @@ cn10k_nix_prepare_mseg_vec_list(struct rte_mbuf *m, uint64_t *cmd,\n \tlen -= dlen;\n \tsg_u = sg_u | ((uint64_t)dlen);\n \n+\t/* Mark mempool object as \"put\" since it is freed by NIX */\n+\tRTE_MEMPOOL_CHECK_COOKIES(m->pool, (void **)&m, 1, 0);\n+\n \tnb_segs = m->nb_segs - 1;\n \tm_next = m->next;\n \tm->next = NULL;\n@@ -1888,6 +1891,9 @@ cn10k_nix_prepare_mseg_vec_list(struct rte_mbuf *m, uint64_t *cmd,\n \t\t\tslist++;\n \t\t}\n \t\tm->next = NULL;\n+\t\t/* Mark mempool object as \"put\" since it is freed by NIX */\n+\t\tRTE_MEMPOOL_CHECK_COOKIES(m->pool, (void **)&m, 1, 0);\n+\n \t\tm = m_next;\n \t} while (nb_segs);\n \n@@ -1911,8 +1917,11 @@ cn10k_nix_prepare_mseg_vec(struct rte_mbuf *m, uint64_t *cmd, uint64x2_t *cmd0,\n \tunion nix_send_hdr_w0_u sh;\n \tunion nix_send_sg_s sg;\n \n-\tif (m->nb_segs == 1)\n+\tif (m->nb_segs == 1) {\n+\t\t/* Mark mempool object as \"put\" since it is freed by NIX */\n+\t\tRTE_MEMPOOL_CHECK_COOKIES(m->pool, (void **)&m, 1, 0);\n \t\treturn;\n+\t}\n \n \tsh.u = vgetq_lane_u64(cmd0[0], 0);\n \tsg.u = vgetq_lane_u64(cmd1[0], 0);\n@@ -1972,6 +1981,11 @@ cn10k_nix_prep_lmt_mseg_vector(struct cn10k_eth_txq *txq,\n \t\t\t*data128 |= ((__uint128_t)7) << *shift;\n \t\t\t*shift += 3;\n \n+\t\t\t/* Mark mempool object as \"put\" since it is freed by NIX */\n+\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[0]->pool, (void **)&mbufs[0], 1, 0);\n+\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[1]->pool, (void **)&mbufs[1], 1, 0);\n+\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[2]->pool, (void **)&mbufs[2], 1, 0);\n+\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[3]->pool, (void **)&mbufs[3], 1, 0);\n \t\t\treturn 1;\n \t\t}\n \t}\n@@ -1990,6 +2004,11 @@ cn10k_nix_prep_lmt_mseg_vector(struct cn10k_eth_txq *txq,\n \t\t\t\tvst1q_u64(lmt_addr + 10, cmd2[j + 1]);\n \t\t\t\tvst1q_u64(lmt_addr + 12, cmd1[j + 1]);\n \t\t\t\tvst1q_u64(lmt_addr + 14, cmd3[j + 1]);\n+\n+\t\t\t\t/* Mark mempool object as \"put\" since it is freed by NIX */\n+\t\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[j]->pool, (void **)&mbufs[j], 1, 0);\n+\t\t\t\tRTE_MEMPOOL_CHECK_COOKIES(mbufs[j + 1]->pool,\n+\t\t\t\t\t\t\t (void **)&mbufs[j + 1], 1, 0);\n \t\t\t} else if (flags & NIX_TX_NEED_EXT_HDR) {\n \t\t\t\t/* EXT header take 3 each, space for 2 segs.*/\n \t\t\t\tcn10k_nix_prepare_mseg_vec(mbufs[j],\n", "prefixes": [ "11/13" ] }