Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136574/?format=api
{ "id": 136574, "url": "http://patchwork.dpdk.org/api/patches/136574/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com", "date": "2024-02-09T15:50:51", "name": "[v4] net/netvsc: fix parsing of VLAN metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc8208058ffd8d939a061af0eabe057eec99fdcd", "submitter": { "id": 3272, "url": "http://patchwork.dpdk.org/api/people/3272/?format=api", "name": "Alan Elder", "email": "alan.elder@microsoft.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com/mbox/", "series": [ { "id": 31063, "url": "http://patchwork.dpdk.org/api/series/31063/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31063", "date": "2024-02-09T15:50:51", "name": "[v4] net/netvsc: fix parsing of VLAN metadata", "version": 4, "mbox": "http://patchwork.dpdk.org/series/31063/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136574/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136574/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B9C443ABD;\n\tFri, 9 Feb 2024 16:50:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 23F9242E64;\n\tFri, 9 Feb 2024 16:50:55 +0100 (CET)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur04on2095.outbound.protection.outlook.com [40.107.8.95])\n by mails.dpdk.org (Postfix) with ESMTP id 4FD8040697\n for <dev@dpdk.org>; Fri, 9 Feb 2024 16:50:54 +0100 (CET)", "from PA4PR83MB0526.EURPRD83.prod.outlook.com (2603:10a6:102:26b::17)\n by PR3PR83MB0394.EURPRD83.prod.outlook.com (2603:10a6:102:7c::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.8; Fri, 9 Feb\n 2024 15:50:51 +0000", "from PA4PR83MB0526.EURPRD83.prod.outlook.com\n ([fe80::b55f:3890:59e4:b623]) by PA4PR83MB0526.EURPRD83.prod.outlook.com\n ([fe80::b55f:3890:59e4:b623%7]) with mapi id 15.20.7292.012; Fri, 9 Feb 2024\n 15:50:51 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=nGVkclrrffNU9WRCnLbFRjCKuVg0qRGQzdEH/quBh/JBoHR3aLeLPg+/Cinb1Bt7fPQhTULex7/FtodqtyRz63pTetCZ1Rg/uaDBZI4Gj95x5wrtxECuLqxfbkm6dT4wshbBWNX+gMq3RwOs/SeGY3EuxGFKxeC3+rbHcpEkxhZgFKaFwKWR+MvQg6q/I+UBr7sZbBKwP1ikeb4xFPpZjbraoiv5LSb97QqTl2SQFeMeB+pGee77OXTGPfl/YfzBSAR7tkqSUIjFUUH8N/yDYfB3G2p+0toNLNS1mCpOk6O3O1Lo4Wh4BU775JJLP/HXk0VYkWsyFxHLIAqfFumPBg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XSpRsL15qIj2IGnaCcy2RH0VVGPR7APap7bCCsVZReA=;\n b=Eo82eE8nvwccqfYz7XPcTxsa421bSXHGhyQgMylVBX58SJIJtSIi6gKujZ5vUP25317KTVqP5Lbf52sNZaaE2d1lr+ZCCLEyJUob/edM00l+8dwqU1crqhvXF5CMuMXBe3tXlU2VlFn7cHEUVRO1oAsb72jXZY4J6Vx9y6xGMVyR5IWZKz7RjjUU72lpnRhdE7DRACmNnjN1TNRIw25sSt7vFvpZ8oncD076tKO9M4+/V+zXRX+Nk5lnuhoQ0oSC870cKZmZJaP3cpVFDrlVX5VKxY7cHMWybmuQ4JEWb7SXgueCpMde4P9iNzBRqQy07r//XD3r2luFrHkU8mPt8g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=microsoft.com; dmarc=pass action=none\n header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XSpRsL15qIj2IGnaCcy2RH0VVGPR7APap7bCCsVZReA=;\n b=NrxvgKwnFGMSXgPbdqeVb+kAAh67iMpxMMHOQPSqP9wO5mChZt1CKk2tRq6SPOqswusyH2ZpoRCji2Mx2lkFV8yVj+ixhT7kKKWUwS2vhWwabj9fhuFg4guZ95UdHAbg1Uvpx7GzHTjBA6bXzUqfMYuFow3VszXJ7jFtzE1m8QI=", "From": "Alan Elder <alan.elder@microsoft.com>", "To": "Long Li <longli@microsoft.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, stephen <stephen@networkplumber.org>", "Subject": "[PATCH v4] net/netvsc: fix parsing of VLAN metadata", "Thread-Topic": "[PATCH v4] net/netvsc: fix parsing of VLAN metadata", "Thread-Index": "AQHaW2/BkMZtI9MwdEG6Mrvm6lxkhA==", "Date": "Fri, 9 Feb 2024 15:50:51 +0000", "Message-ID": "\n <PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "References": "\n <PA4PR83MB0526CCCB791C5510CE053A9497442@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <PH7PR21MB3263EFEA76459C959F2EA954CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com>", "In-Reply-To": "\n <PH7PR21MB3263EFEA76459C959F2EA954CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "msip_labels": "\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=56178cb2-c070-454c-9d7f-d5fa4a8e41c0;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-08T14:59:43Z;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;", "authentication-results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=microsoft.com;", "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "PA4PR83MB0526:EE_|PR3PR83MB0394:EE_", "x-ms-office365-filtering-correlation-id": "85129fb1-9124-4526-f9dd-08dc2986e434", "x-ld-processed": "72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n bjZhv+gNIgxzoYkcNdL+mCV/6CZZ0XUPcLix1KOyaMulBxqcKbHTqhpwOcRSCLgtzJsc7jVrsV3Ks9yDF2D2oE1m2BbEp2k2XsEMuTRk5ypXYMTHPb3kjDTXu2fHicIkxODM7KpThwUdkprg+/PFQLvaHwd4KEMmS2we41jVI0rWdhQUl0+7sbTgzt5RQuolQgR5XttQ0YoBf2PXSWdQwKgj046Kchdr3PqOWmVTzP970GyG3JLf7/EGarTBsz5tS0vTY2T2cz8kqPNCIRtJYO+GzP2BgXoVow9we5a75oYE7f7kDxtH8XQ1u4xAjcjUjDcoACY2OMvrlhtbOl9GGrwNAr8aRacdVXgZpYrs1O68I/gvqWzQ7W/cimCTzW9aXV6rqEkwRjDL5BPOqWJEg3qzl7Q9sYue0kHJjkC+dJhE6dw3qml4c1W7Y4UxenJjqK6UiwZ5TmMc/dFs53Zw71NiwiK2XzKqkRRT7bo1dBl0zS63Nk63v4L4vGwrRzrZU9uJKZ78RIlToEHA/fjEcC4y13JZddwMsKYRTE9dajQVpDjzuQAIE0Gd/DnKPX1BA557e73+Lrcza0oIS5VimOoc592eeFtni9hzjnIZ1hlNVl43vYh8Gi89nHEwyL2P", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PA4PR83MB0526.EURPRD83.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(346002)(39860400002)(136003)(376002)(396003)(366004)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(52536014)(4326008)(5660300002)(2906002)(44832011)(8990500004)(83380400001)(33656002)(38100700002)(122000001)(86362001)(82950400001)(82960400001)(8676002)(66946007)(76116006)(66476007)(54906003)(38070700009)(110136005)(66556008)(66446008)(64756008)(8936002)(316002)(71200400001)(6506007)(9686003)(10290500003)(478600001)(55016003)(7696005)(41300700001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "\n Okb4BaZQIvc+Ho96baRVsjFyEVM2g754l8ye+Rmrmr5bhH3OPY0xqj4h2I4sQz7BmQDnq/OD5MePnUmJkCZB/l2Vmap5WgZDhc7gvbk4lCa+/1RTwHC5lpk0DRts1vlHmOlTl5fxY3ZHS692YQMoli+tOYPHGUCpr3w5OqBOn+pav4ofDRx2FxVNaytfJZnkfP0huYN67XeVPEoxvaPByDp1RJpNk9yRWBh9OQdEbGZv0kOEoc3Hoee+1GStjxN8uYDj6H9Ude2N3M9CDvr6ZzoOq23c4GuqQeB2oyV40sKuaShB+z40dndQGZVHlrNeYxkNw1fwW2LlfqfzmfPtd8Kee1uJkBxrG5y9DtURv+vk7P6+lOoBT5EACpznVPbUmniBk7hrwzRJ9MdjMrj0rSNJ0UbvgE9A+UnciNlfdQLA1H7udmUVihAJe6qWMOKmo4Edc70kFTLwRG2rhJGS+tRKoH5ugIJf52htKT/RnRTy60Cab4hgsCH5xn0joEri1iXy62sWW+i/Kb1KgSceuHLjJR0ZQC3DgkLe0OUq13HUKTo2VmUZK8H+eJAGr6X/i5bi03vM+qQOAxnfZx/B2Mzb1yaK8T058qzn2tz4VacL3HBkTndNy1C0w0BIytGGPAoKpso2Pj7k61Hwba/K8ikD1LZZ12McEei1NU7AL8S/kWGVm2takvb0LZeA3MyfljOGJjggwbUC/ypv02cnf9npDRSYROsW4QxX8A560ivoBQO5HZXa8yH4/m77/HsiXRRcbEv5Kzw7zATr22gBABo7KzRiPv2drAqdFNuXmhsss6PUSlQtCrPS2bjz+ldgyfbUtysl2MGakeV8+xO8vu1Ybq27PPi/uFZuXyTKaDPcQkPUK2jw8Yw6atpUdvfwwPEGFeW8auTlnY2exEOiQ1ErVfgODQqw5a5vH2vsm2N1DezZGrr/mw/K7cSjNQgRzXKE9UGf2Ru104wM822hKbGMCk0R5VSoVzONAHsLEBV1KbQmVkdrNM/8LhFmLKOSox2Kpcksh8rnPDmYiC6MJk2bLhX+hB3JLaMCnkUdu3WrXVVQSNlnnoLQWN30LgK7IGtGQws3XzimRNYVaicRBsH70ZZPOh/NT0iaLQJVFbesF5KmjV7bg+nls2BGnGpOJDZNNAgHlcSACO9RNtDWPeYVp52K8jfWKrtMynrRq/Tx7iJDDsWgerL1w+/WAcMuR8GKvhy9b9Favn+duxz4mdnF66ADCkc2Uiy/6olW2Espe4f8k9E0u4t7ug6tPVpNTi4kwELW5WUSoZIv5d5eIU6dETT2slvvNJl2GmOjEYe8e3/BnWUcUCe567LuI39jtxl1Zh1utJ5r8/1qygR9feuJTmw5qzU8jUsx8Esb5wPuMbQLLWUtuPLYy5liEGzbTz8QPcwaBzYd7U1fh14EX0KCOm2B5cBN9O6RTbJ9lZesr/QikeUP4IPRZwJ+GHOoRU/IQo8ZZUrYW46YLaIcLg4JQ4HvCKsJYo8GtT+hYHqkAaaMKwd6aYdyhczA5XQO6rQ87ixeS5HcbhhETya5bjofnIGy3pl/rS52yZG7l30Q9vU958cn7cKVwfu1rVom", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "microsoft.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "PA4PR83MB0526.EURPRD83.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 85129fb1-9124-4526-f9dd-08dc2986e434", "X-MS-Exchange-CrossTenant-originalarrivaltime": "09 Feb 2024 15:50:51.0724 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "72f988bf-86f1-41af-91ab-2d7cd011db47", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n NIOcede+g2RLjkvCWyQqL8OXYMw9P996OBybljgrsu8uO8FWnp8kFK9tYG6A9/a3prL2y1gMzdR0Q7OQX9gu3g==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PR3PR83MB0394", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The previous code incorrectly parsed the VLAN ID and priority.\nIf the 16-bits of VLAN ID and priority/CFI on the wire was\n0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There\nwere macros defined to handle this conversion but they were not\nused.\n\nFixes: 4e9c73e96e83 (\"net/netvsc: add Hyper-V network device\")\nCc: sthemmin@microsoft.com\nCc: stable@dpdk.org\n\nSigned-off-by: Alan Elder <alan.elder@microsoft.com>\n---\nv4:\n* Make consistent with FreeBSD code\n\n .mailmap | 1 +\n drivers/net/netvsc/hn_rxtx.c | 21 +++++++++++++++++++--\n 2 files changed, 20 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex a0756974e2..eca02318d6 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -33,6 +33,7 @@ Alain Leon <xerebz@gmail.com>\n Alan Brady <alan.brady@intel.com>\n Alan Carew <alan.carew@intel.com>\n Alan Dewar <alan.dewar@att.com> <adewar@brocade.com>\n+Alan Elder <alan.elder@microsoft.com>\n Alan Liu <zaoxingliu@gmail.com>\n Alan Winkowski <walan@marvell.com>\n Alejandro Lucero <alejandro.lucero@netronome.com>\ndiff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex e4f5015aa3..1cbb8df03f 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -42,6 +42,19 @@\n #define HN_TXD_CACHE_SIZE\t32 /* per cpu tx_descriptor pool cache */\n #define HN_RXQ_EVENT_DEFAULT\t2048\n \n+#define HN_VLAN_CFI_SHIFT\t12\n+#define HN_VLAN_PRI_SHIFT\t13\n+#define HN_VLAN_PRI_MASK\t0xe000 /* Priority Code Point */\n+#define HN_VLAN_CFI_MASK\t0x1000 /* Canonical Format Indicator / Drop Eligible Indicator */\n+#define HN_VLAN_VID_MASK\t0x0fff /* VLAN Identifier */\n+\n+#define HN_VLAN_TCI_ID(vlan_tci)\t((vlan_tci) & HN_VLAN_VID_MASK)\n+#define HN_VLAN_TCI_PRI(vlan_tci)\t(((vlan_tci) & HN_VLAN_PRI_MASK) >> HN_VLAN_PRI_SHIFT)\n+#define HN_VLAN_TCI_CFI(vlan_tci)\t(((vlan_tci) & HN_VLAN_CFI_MASK) >> HN_VLAN_CFI_SHIFT)\n+#define HN_VLAN_TCI_MAKE(id, pri, cfi)\t((id) |\t\t\t\t\\\n+\t\t\t\t\t ((pri) << HN_VLAN_PRI_SHIFT) |\t\\\n+\t\t\t\t\t ((cfi) << HN_VLAN_CFI_SHIFT))\n+\n struct hn_rxinfo {\n \tuint32_t\tvlan_info;\n \tuint32_t\tcsum_info;\n@@ -612,7 +625,9 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,\n \t\t\t\t\t RTE_PTYPE_L4_MASK);\n \n \tif (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) {\n-\t\tm->vlan_tci = info->vlan_info;\n+\t\tm->vlan_tci = HN_VLAN_TCI_MAKE(NDIS_VLAN_INFO_ID(info->vlan_info),\n+\t\t\t\t\t NDIS_VLAN_INFO_PRI(info->vlan_info),\n+\t\t\t\t\t NDIS_VLAN_INFO_CFI(info->vlan_info));\n \t\tm->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED | RTE_MBUF_F_RX_VLAN;\n \n \t\t/* NDIS always strips tag, put it back if necessary */\n@@ -1332,7 +1347,9 @@ static void hn_encap(struct rndis_packet_msg *pkt,\n \tif (m->ol_flags & RTE_MBUF_F_TX_VLAN) {\n \t\tpi_data = hn_rndis_pktinfo_append(pkt, NDIS_VLAN_INFO_SIZE,\n \t\t\t\t\t\t NDIS_PKTINFO_TYPE_VLAN);\n-\t\t*pi_data = m->vlan_tci;\n+\t\t*pi_data = NDIS_VLAN_INFO_MAKE(HN_VLAN_TCI_ID(m->vlan_tci),\n+\t\t\t\t\t HN_VLAN_TCI_PRI(m->vlan_tci),\n+\t\t\t\t\t HN_VLAN_TCI_CFI(m->vlan_tci));\n \t}\n \n \tif (m->ol_flags & RTE_MBUF_F_TX_TCP_SEG) {\n", "prefixes": [ "v4" ] }