Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136747/?format=api
{ "id": 136747, "url": "http://patchwork.dpdk.org/api/patches/136747/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240214073015.2060103-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240214073015.2060103-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240214073015.2060103-3-michaelba@nvidia.com", "date": "2024-02-14T07:30:14", "name": "[v5,2/3] net/mlx5: add support to compare random value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f11b3d31e0bcba0675981cbbee99c75adad45f62", "submitter": { "id": 1949, "url": "http://patchwork.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240214073015.2060103-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 31103, "url": "http://patchwork.dpdk.org/api/series/31103/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31103", "date": "2024-02-14T07:30:12", "name": "net/mlx5: add compare item support", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31103/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136747/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98C5B43B27;\n\tWed, 14 Feb 2024 08:30:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9661B42FCF;\n\tWed, 14 Feb 2024 08:30:54 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65])\n by mails.dpdk.org (Postfix) with ESMTP id 8D2E742FA1\n for <dev@dpdk.org>; Wed, 14 Feb 2024 08:30:52 +0100 (CET)", "from DM6PR17CA0022.namprd17.prod.outlook.com (2603:10b6:5:1b3::35)\n by SJ1PR12MB6194.namprd12.prod.outlook.com (2603:10b6:a03:458::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.8; Wed, 14 Feb\n 2024 07:30:49 +0000", "from DS1PEPF0001709A.namprd05.prod.outlook.com\n (2603:10b6:5:1b3:cafe::b7) by DM6PR17CA0022.outlook.office365.com\n (2603:10b6:5:1b3::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26 via Frontend\n Transport; Wed, 14 Feb 2024 07:30:49 +0000", "from mail.nvidia.com (216.228.117.160) by\n DS1PEPF0001709A.mail.protection.outlook.com (10.167.18.104) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Wed, 14 Feb 2024 07:30:48 +0000", "from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 13 Feb\n 2024 23:30:33 -0800", "from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com\n (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 13 Feb\n 2024 23:30:33 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Tue, 13 Feb 2024 23:30:31 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=bN4/2r0mB0VLVV4xALyvkBU3dgdz6zVjHAaEmZ6YTTny45HtRapqkZYv9/dMyPkSs22CoPrCLNxpORcWa81B5vBY5WKOWHbsTwgHfZ+WI8N52qdYdBe1I/mfgFnUfZgQnJi3pFbcw5xJUENIzGijHhZt9ZpvI3urn8Kw3Gy493va62ecis+9ifHLE6uq1m1WIJZOuiSfvztwCeNxruW2D5CvoaX3yVQNYjN/u4OYUAhRn7OqVVYCGzd5G60QJWPE/oVcJR0tFCv6F42QZ+ennLpyfg7uTbyBUExHdkUqOTXYSg+vYtSSuSkV+GMANMMBhb9eJyHGL3GMboPoVgKzKQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=v2VSdEwMj6tihEgWamVgZr6s1ZIU1ndaoQygnGfy8+w=;\n b=eeJxvxpwrC1fz8HyRAriSATquL3B7PQSwx53B0Wb6CZD65+JtxlgM2OboSpV/4wkHdV1kYoPzF5G4zECjP6s/zCdmFLvqlDrBCF1MeszWnqg//N5CmZkLpvEWAifLFCVhx/2ALwrk71ETRy5BznfmqGysHVPK3NcR0jLzsyuT3FagwGF3UE8ma/xZeHyIWcY+R3VNBVm8iirq5rxTkuCSN+4rm8Xsq/4KDJQzYde3QC7Tq8+1KdjDsxMxmmAo5YxQ35w2LO6twg6g1d69y9nd7Z/akSP2x0CNyDr1SAbNebmATjvWI8C/zfLxLaJFoxqzptrI3cgknjenUy8uIN+CQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=v2VSdEwMj6tihEgWamVgZr6s1ZIU1ndaoQygnGfy8+w=;\n b=sHshCYvTHKDWgtAhi9jMnF/pZDC4XFr8TltSan+GJksJPB2zDUeSheo3BsZruPGDAweai2OZNYlfjSrW7kfc+QYnzqqBrTiUwOKlm0x6HLM1Bpng1bvxV5Z6xAyyWpnDfJpiOU8I6UTJVXKahfV/nvpmdY1jPG22jaXpVa9Z9uU3LaQkiZJQJbj4ncAtD2WDZB/B68L9SZX5P5ABKe0c8eBGO6R6BBeKq+LTX6IlPDAQmY8ogZpNT0fh/IKggxsAhuh6vxPKyc4k/JkdPB3UzXCY3MM2Iw6faNSColNgZPQ8CbeqRyPuD52or6IOTzsAce+/V92V/iqirdO72mDfEg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>", "Subject": "[PATCH v5 2/3] net/mlx5: add support to compare random value", "Date": "Wed, 14 Feb 2024 09:30:14 +0200", "Message-ID": "<20240214073015.2060103-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240214073015.2060103-1-michaelba@nvidia.com>", "References": "<20240207161414.1583125-1-michaelba@nvidia.com>\n <20240214073015.2060103-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS1PEPF0001709A:EE_|SJ1PR12MB6194:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7df6c2e0-5b14-491a-cf5a-08dc2d2edd6d", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ktci4iFClIUnql43QSPRMCe3HwvMH0CPZ7olWZlkbjgbEgqhVkX5XQNBr8iXrCXBfgZSgaw6a5NmIlymNGIWUmvr2WFO4jWY147ni/Nr7GJUbKgt/vPcKgzFxhAmSV+7ssk3lZYagJM8xDFf0uZQj+t3nU/nhu3YtJPRsUg2UJZDwE4wXUdDpmTfmBUJEe+c/vFhferSFZlBC/5EIlk1GHFtkJfb17VpA4nyce8KuiE/TsQxGkJ1Xn6X7127MeOL9dbLFpaR3vDdAlzTxMqRTj3MaKxm41RL267s32Nc2dHj7kE1bHJeKfOWDqtIb1KkA9UhBukcbbJKQRpbFN55BGgQ74nybG47puKFRq5qYUFfVlmIuBo3jrJoPCdhcITIsBK5vvtLTOfWmcigBM0qKfMUO45SH+5pI9tYDH49VT7hQowRa9FHYI58WX0FSEw8yUFEVZmrXwlunN4M9q0NrVNRRXcuxtgL+6NSOPmUq1OJl/lEJQ/TviuCh/SNS0+kOG4E58Z/Z7CLRT8FfOk58QkOYkYRkpzOmT8kTGJkhfiMEdXUnqwy6EF776b3dCSwx5IsnfyKEkHWx2H8OBoL8CoiOocpGMV+eOD9zVQ4fys=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(136003)(376002)(346002)(396003)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(82310400011)(46966006)(36840700001)(40470700004)(478600001)(55016003)(41300700001)(8676002)(8936002)(5660300002)(2906002)(4326008)(7696005)(7636003)(86362001)(6666004)(54906003)(6916009)(70206006)(70586007)(316002)(2616005)(83380400001)(107886003)(336012)(426003)(356005)(6286002)(1076003)(26005)(82740400003)(36756003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Feb 2024 07:30:48.4912 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7df6c2e0-5b14-491a-cf5a-08dc2d2edd6d", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DS1PEPF0001709A.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ1PR12MB6194", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support to use \"RTE_FLOW_ITEM_TYPE_COMPARE\" with\n\"RTE_FLOW_FIELD_RAMDOM\" as an argument.\nThe random field is supported only when base is an immediate value,\nrandom field cannot be compared with enother field.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n doc/guides/nics/mlx5.rst | 9 ++++-\n drivers/net/mlx5/mlx5_flow_hw.c | 70 ++++++++++++++++++++++++---------\n 2 files changed, 59 insertions(+), 20 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex fa013b03bb..43ef8a99dc 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -820,8 +820,13 @@ Limitations\n \n - Only supported in HW steering(``dv_flow_en`` = 2) mode.\n - Only single flow is supported to the flow table.\n- - Only 32-bit comparison is supported.\n- - Only match with compare result between packet fields is supported.\n+ - Only single item is supported per pattern template.\n+ - Only 32-bit comparison is supported or 16-bits for random field.\n+ - Only supported for ``RTE_FLOW_FIELD_META``, ``RTE_FLOW_FIELD_TAG``,\n+ ``RTE_FLOW_FIELD_RANDOM`` and ``RTE_FLOW_FIELD_VALUE``.\n+ - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.\n+ - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with\n+ ``RTE_FLOW_FIELD_VALUE``.\n \n \n Statistics\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 3af5e1f160..b5741f0817 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -6717,18 +6717,55 @@ flow_hw_prepend_item(const struct rte_flow_item *items,\n \treturn copied_items;\n }\n \n-static inline bool\n-flow_hw_item_compare_field_supported(enum rte_flow_field_id field)\n+static int\n+flow_hw_item_compare_field_validate(enum rte_flow_field_id arg_field,\n+\t\t\t\t enum rte_flow_field_id base_field,\n+\t\t\t\t struct rte_flow_error *error)\n {\n-\tswitch (field) {\n+\tswitch (arg_field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\tif (base_field == RTE_FLOW_FIELD_VALUE)\n+\t\t\treturn 0;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare random is supported only with immediate value\");\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item argument field is not supported\");\n+\t}\n+\tswitch (base_field) {\n \tcase RTE_FLOW_FIELD_TAG:\n \tcase RTE_FLOW_FIELD_META:\n \tcase RTE_FLOW_FIELD_VALUE:\n-\t\treturn true;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item base field is not supported\");\n+\t}\n+\treturn 0;\n+}\n+\n+static inline uint32_t\n+flow_hw_item_compare_width_supported(enum rte_flow_field_id field)\n+{\n+\tswitch (field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\treturn 32;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\treturn 16;\n \tdefault:\n \t\tbreak;\n \t}\n-\treturn false;\n+\treturn 0;\n }\n \n static int\n@@ -6737,6 +6774,7 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n {\n \tconst struct rte_flow_item_compare *comp_m = item->mask;\n \tconst struct rte_flow_item_compare *comp_v = item->spec;\n+\tint ret;\n \n \tif (unlikely(!comp_m))\n \t\treturn rte_flow_error_set(error, EINVAL,\n@@ -6748,19 +6786,13 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t NULL,\n \t\t\t\t \"compare item only support full mask\");\n-\tif (!flow_hw_item_compare_field_supported(comp_m->a.field) ||\n-\t !flow_hw_item_compare_field_supported(comp_m->b.field))\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare item field not support\");\n-\tif (comp_m->a.field == RTE_FLOW_FIELD_VALUE &&\n-\t comp_m->b.field == RTE_FLOW_FIELD_VALUE)\n-\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare between value is not valid\");\n+\tret = flow_hw_item_compare_field_validate(comp_m->a.field,\n+\t\t\t\t\t\t comp_m->b.field, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n \tif (comp_v) {\n+\t\tuint32_t width;\n+\n \t\tif (comp_v->operation != comp_m->operation ||\n \t\t comp_v->a.field != comp_m->a.field ||\n \t\t comp_v->b.field != comp_m->b.field)\n@@ -6768,7 +6800,9 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"compare item spec/mask not matching\");\n-\t\tif ((comp_v->width & comp_m->width) != 32)\n+\t\twidth = flow_hw_item_compare_width_supported(comp_v->a.field);\n+\t\tMLX5_ASSERT(width > 0);\n+\t\tif ((comp_v->width & comp_m->width) != width)\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n", "prefixes": [ "v5", "2/3" ] }