Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136814,
    "url": "http://patchwork.dpdk.org/api/patches/136814/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1707978080-28859-18-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1707978080-28859-18-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1707978080-28859-18-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-02-15T06:21:19",
    "name": "[v4,17/18] common/idpf: stop using zero sized marker fields",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1d5f9c9a50e25f27a311c40b9eaacb9cd8ce7a8c",
    "submitter": {
        "id": 2077,
        "url": "http://patchwork.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1707978080-28859-18-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31113,
            "url": "http://patchwork.dpdk.org/api/series/31113/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31113",
            "date": "2024-02-15T06:21:02",
            "name": "stop using zero sized marker fields",
            "version": 4,
            "mbox": "http://patchwork.dpdk.org/series/31113/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/136814/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/136814/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36DED43B06;\n\tThu, 15 Feb 2024 07:23:16 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0749B433DD;\n\tThu, 15 Feb 2024 07:21:57 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 65B9943386\n for <dev@dpdk.org>; Thu, 15 Feb 2024 07:21:38 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 087C220B200A; Wed, 14 Feb 2024 22:21:36 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 087C220B200A",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707978097;\n bh=t1Eyb2fWA0JLrPxQIydeO5rt9tkBFM5KupDk0VYoHDQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=iATEfrVJnheczHRKdY07vByqPyHOOcU1jtul4k8JPJtZGnOM1cExtKSaysrabJgbd\n HPmqyF4uOjkkNZX8RwJ15Fp2Cs/ZjirUuvImJXFEWUBIrsSPeLVaojvlofyQXC+H8H\n /t6tcFgbfVOTQv77pjYdDPD9BHHiReSKSGiBXh8Q=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH v4 17/18] common/idpf: stop using zero sized marker fields",
        "Date": "Wed, 14 Feb 2024 22:21:19 -0800",
        "Message-Id": "<1707978080-28859-18-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Update to reference newly named anonymous union markers supported by\nstandard C and stop referencing zero sized compiler extension markers.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/common/idpf/idpf_common_rxtx.c        |  4 +-\n drivers/common/idpf/idpf_common_rxtx_avx512.c | 60 +++++++++++++--------------\n 2 files changed, 32 insertions(+), 32 deletions(-)",
    "diff": "diff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c\nindex 83b131e..06f1e9d 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.c\n+++ b/drivers/common/idpf/idpf_common_rxtx.c\n@@ -1603,9 +1603,9 @@\n \tmb_def.port = rxq->port_id;\n \trte_mbuf_refcnt_set(&mb_def, 1);\n \n-\t/* prevent compiler reordering: rearm_data covers previous fields */\n+\t/* prevent compiler reordering: mbuf_rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n+\tp = (uintptr_t)&mb_def.mbuf_rearm_data;\n \trxq->mbuf_initializer = *(uint64_t *)p;\n \treturn 0;\n }\ndiff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c b/drivers/common/idpf/idpf_common_rxtx_avx512.c\nindex f65e8d5..65c5bd1 100644\n--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c\n+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c\n@@ -313,13 +313,13 @@\n \t * calls above.\n \t */\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 4);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 8);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, vlan_tci) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 10);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 10);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 12);\n \n \tuint16_t i, received;\n \n@@ -457,10 +457,10 @@\n \t\t */\n \t\t/* check the structure matches expectations */\n \t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=\n-\t\t\t\t offsetof(struct rte_mbuf, rearm_data) + 8);\n-\t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, rearm_data) !=\n+\t\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) + 8);\n+\t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, mbuf_rearm_data) !=\n \t\t\t\t RTE_ALIGN(offsetof(struct rte_mbuf,\n-\t\t\t\t\t\t    rearm_data),\n+\t\t\t\t\t\t    mbuf_rearm_data),\n \t\t\t\t\t\t    16));\n \t\t/* build up data and do writes */\n \t\t__m256i rearm0, rearm1, rearm2, rearm3, rearm4, rearm5,\n@@ -476,13 +476,13 @@\n \t\trearm0 = _mm256_permute2f128_si256(mbuf_init, mb0_1, 0x20);\n \n \t\t/* write to mbuf */\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 6]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 6]->mbuf_rearm_data,\n \t\t\t\t    rearm6);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 4]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 4]->mbuf_rearm_data,\n \t\t\t\t    rearm4);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 2]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 2]->mbuf_rearm_data,\n \t\t\t\t    rearm2);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 0]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 0]->mbuf_rearm_data,\n \t\t\t\t    rearm0);\n \n \t\trearm7 = _mm256_blend_epi32(mbuf_init, mb6_7, 0xF0);\n@@ -491,13 +491,13 @@\n \t\trearm1 = _mm256_blend_epi32(mbuf_init, mb0_1, 0xF0);\n \n \t\t/* again write to mbufs */\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 7]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 7]->mbuf_rearm_data,\n \t\t\t\t    rearm7);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 5]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 5]->mbuf_rearm_data,\n \t\t\t\t    rearm5);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 3]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 3]->mbuf_rearm_data,\n \t\t\t\t    rearm3);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 1]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 1]->mbuf_rearm_data,\n \t\t\t\t    rearm1);\n \n \t\t/* perform dd_check */\n@@ -774,13 +774,13 @@\n \t * calls above.\n \t */\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 4);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 8);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, vlan_tci) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 10);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 10);\n \tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash) !=\n-\t\t\t offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);\n+\t\t\t offsetof(struct rte_mbuf, mbuf_rx_descriptor_fields1) + 12);\n \n \tuint16_t i, received;\n \n@@ -917,10 +917,10 @@\n \t\t */\n \t\t/* check the structure matches expectations */\n \t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=\n-\t\t\t\t offsetof(struct rte_mbuf, rearm_data) + 8);\n-\t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, rearm_data) !=\n+\t\t\t\t offsetof(struct rte_mbuf, mbuf_rearm_data) + 8);\n+\t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, mbuf_rearm_data) !=\n \t\t\t\t RTE_ALIGN(offsetof(struct rte_mbuf,\n-\t\t\t\t\t\t    rearm_data),\n+\t\t\t\t\t\t    mbuf_rearm_data),\n \t\t\t\t\t\t    16));\n \t\t\t\t/* build up data and do writes */\n \t\t__m256i rearm0, rearm1, rearm2, rearm3, rearm4, rearm5,\n@@ -936,13 +936,13 @@\n \t\trearm0 = _mm256_permute2f128_si256(mbuf_init, mb0_1, 0x20);\n \n \t\t/* write to mbuf */\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 6]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 6]->mbuf_rearm_data,\n \t\t\t\t    rearm6);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 4]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 4]->mbuf_rearm_data,\n \t\t\t\t    rearm4);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 2]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 2]->mbuf_rearm_data,\n \t\t\t\t    rearm2);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 0]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 0]->mbuf_rearm_data,\n \t\t\t\t    rearm0);\n \n \t\trearm7 = _mm256_blend_epi32(mbuf_init, mb6_7, 0xF0);\n@@ -951,13 +951,13 @@\n \t\trearm1 = _mm256_blend_epi32(mbuf_init, mb0_1, 0xF0);\n \n \t\t/* again write to mbufs */\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 7]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 7]->mbuf_rearm_data,\n \t\t\t\t    rearm7);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 5]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 5]->mbuf_rearm_data,\n \t\t\t\t    rearm5);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 3]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 3]->mbuf_rearm_data,\n \t\t\t\t    rearm3);\n-\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 1]->rearm_data,\n+\t\t_mm256_storeu_si256((__m256i *)&rx_pkts[i + 1]->mbuf_rearm_data,\n \t\t\t\t    rearm1);\n \n \t\tconst __mmask8 dd_mask = _mm512_cmpeq_epi64_mask(\n",
    "prefixes": [
        "v4",
        "17/18"
    ]
}