Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136872/?format=api
{ "id": 136872, "url": "http://patchwork.dpdk.org/api/patches/136872/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/PA4PR83MB0526A110A4028F45AA53806297512@PA4PR83MB0526.EURPRD83.prod.outlook.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<PA4PR83MB0526A110A4028F45AA53806297512@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/PA4PR83MB0526A110A4028F45AA53806297512@PA4PR83MB0526.EURPRD83.prod.outlook.com", "date": "2024-02-19T09:31:39", "name": "[v7,2/2] net/netvsc: fix parsing of VLAN metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e1bf1a772ea77f3ce61a39828849adf3b8f5f4d3", "submitter": { "id": 3272, "url": "http://patchwork.dpdk.org/api/people/3272/?format=api", "name": "Alan Elder", "email": "alan.elder@microsoft.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/PA4PR83MB0526A110A4028F45AA53806297512@PA4PR83MB0526.EURPRD83.prod.outlook.com/mbox/", "series": [ { "id": 31138, "url": "http://patchwork.dpdk.org/api/series/31138/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31138", "date": "2024-02-19T09:31:25", "name": "[v7,1/2] lib/net: fix parsing of VLAN metadata", "version": 7, "mbox": "http://patchwork.dpdk.org/series/31138/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136872/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136872/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BDC8343B4B;\n\tMon, 19 Feb 2024 10:31:42 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD15140685;\n\tMon, 19 Feb 2024 10:31:42 +0100 (CET)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2134.outbound.protection.outlook.com [40.107.20.134])\n by mails.dpdk.org (Postfix) with ESMTP id 853084067E\n for <dev@dpdk.org>; Mon, 19 Feb 2024 10:31:41 +0100 (CET)", "from PA4PR83MB0526.EURPRD83.prod.outlook.com (2603:10a6:102:26b::17)\n by DBAPR83MB0421.EURPRD83.prod.outlook.com (2603:10a6:10:190::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.6; Mon, 19 Feb\n 2024 09:31:39 +0000", "from PA4PR83MB0526.EURPRD83.prod.outlook.com\n ([fe80::3256:dd6f:ad59:ee34]) by PA4PR83MB0526.EURPRD83.prod.outlook.com\n ([fe80::3256:dd6f:ad59:ee34%7]) with mapi id 15.20.7339.001; Mon, 19 Feb 2024\n 09:31:39 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=XZhCmNT8ULHMZHNKKBV++QGKz4vmESHpu1fwZ89dmYb0o7vD+s5MBTrHp0YS9k7ZdHPhidGJD5JuZ4TyOifK5IoXV7RZht522ws61eYm5DZSNCkvZDmoEJVHPwE78YV65c3DhQ02PExvA7Ugu87VTfIG3A2BdhZ9eltXtFqQ9wu5gol4hNdnoPcbf1/zn0YwFkncoLwKeG7YvQUrXjOkISkWVqB6VK4eXF9/x1nZ/PBjQyXFZApfrgjyqeUO+hkx/OuJ/erQeiAGy/6VsWKSRGRl5F/mb9XdMJDdQDEpfkAmdGlwv2hieSD5m3ail6EzRJOZK8xVIrw+e6Niu3k5Fg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qfyaOztTc2o5uq9hrypsd2Itf+Tv8e0AXEz0+NI3/0s=;\n b=P2zijpV554nvOjYFGN1tYkYFTuUdRfiODGtdft2K6y0z40FQJQ6yhnSoqsck4ISgSELi+SQZLFXUF/x4apfZYBKw2vUn5mc+1oOD1bJ77HHXbdQ8/CNwAYfxOr8VSb3oHJcSJNN0DrKt3RxJgb8tVzp1CuPXGqr0eIlPe8UrtzoNyxei0lEl1BVqtLCuSptBLI0yWPwe/SViHKUZXmlBbA7gSw//A2cK028z7VK0QZ5E1H9TYeevRfNUcWuusy6MOfMFHlTCFazpB+/1Pp0fZQJgHIn7xb6k/+nZoo1SyaBu8GOrSEihqeEqDLxy9LoVNeP7vKcASTkrVRXp8O16gw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=microsoft.com; dmarc=pass action=none\n header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qfyaOztTc2o5uq9hrypsd2Itf+Tv8e0AXEz0+NI3/0s=;\n b=VyJJ3V/bAIssoIHC92OQ6TZbFL5465yAI1uf9g/B6q2/lRC71Z74lSy8uUwzUCGpnlRF1HywkoWzRvOv/4ZtPjCyYW5HAFdWbpvyvnnJ/4aHbeZ3Q+C0sZkv1cNalOS0PdPmdVqB/LQZXhqIZAzTtVviA78F7UNDgJTBTuVkmqQ=", "From": "Alan Elder <alan.elder@microsoft.com>", "To": "Ferruh Yigit <ferruh.yigit@amd.com>, Long Li <longli@microsoft.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, stephen <stephen@networkplumber.org>", "Subject": "[PATCH v7 2/2] net/netvsc: fix parsing of VLAN metadata", "Thread-Topic": "[PATCH v7 2/2] net/netvsc: fix parsing of VLAN metadata", "Thread-Index": "AQHaYxZw6hmKT4BOwkOfjURn3nVrtQ==", "Date": "Mon, 19 Feb 2024 09:31:39 +0000", "Message-ID": "\n <PA4PR83MB0526A110A4028F45AA53806297512@PA4PR83MB0526.EURPRD83.prod.outlook.com>", "References": "\n <PA4PR83MB0526CCCB791C5510CE053A9497442@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <PH7PR21MB3263EFEA76459C959F2EA954CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com>\n <PA4PR83MB0526A80FD64166748D7E1962974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <PH7PR21MB3263C50C506E47271E1B4B09CE4E2@PH7PR21MB3263.namprd21.prod.outlook.com>\n <cd727ea7-6353-4b94-acde-08a93b43f315@amd.com>\n <PA4PR83MB0526A094C53E5613C0A669A3974D2@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <PA4PR83MB0526EA2AD123EA2927F47E10974C2@PA4PR83MB0526.EURPRD83.prod.outlook.com>\n <8139ddff-aabf-4ee0-a51b-a2a658691624@amd.com>", "In-Reply-To": "<8139ddff-aabf-4ee0-a51b-a2a658691624@amd.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "msip_labels": "\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7ae1a5e5-dec8-4ee2-a466-240d3d109cc8;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-19T09:07:03Z;\n MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;", "authentication-results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=microsoft.com;", "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "PA4PR83MB0526:EE_|DBAPR83MB0421:EE_", "x-ms-office365-filtering-correlation-id": "9afebe47-ee74-4483-2163-08dc312d9350", "x-ld-processed": "72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n bD3vUSrxJkQEdAewS2fbNRHEKLqGK7detkumumEmsdMLzNwntjljRX486diPFhuZ17p3atj59bzd4SClCaFmFEBwYEQ+TNbIeAw9vfMjK7pWWs8Zu8nC911S+J2qxv4lJg1pcLBTwY0nnYWtbbC1TVxq7FJvLQNbv0EoUnlNVKyTRgFiVO54BarSAZWtOdt9m9U5DAzkP0Hhh9hU6ywSsNh2QmPGJ+dRugtWGXPj4vntzKyogM134xQLiAV918zStTE9/G4IERYaMUYex5EygfOPCojglpP7JaT7W9UyDD4xtQIAp3bJ08FU7NZsmk9BO1KvLDkvILGbbsODg27nt6Vg7cYT7okcw4Z9U51nnwXOx0Q+nAeUsLh/up16MqmAiYjXK6UNdjBO2ewORde/yrifBDO0DdFcta8iz7eIvbceVJuz3KDpv4/eQcMtxBzKF3nn1kVYrTmHZBCsiULQaZyU+XlAlJMnL/9cOfBqssUseoDH9ONJZxppph489g0WRYnBMjVFxvKpFqPW503cz89FhUzBaQzZAEEOTA7nVfbKY6FaDeSRrIRSpe3s3uvriz9o9usa0H+H7RAYNR4OFVc4/EJ/EZbHYTclP+IKwHcjvtGcKN07szwQne6r6yA+", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:PA4PR83MB0526.EURPRD83.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39860400002)(366004)(346002)(136003)(376002)(396003)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(6506007)(10290500003)(9686003)(7696005)(478600001)(71200400001)(54906003)(316002)(38070700009)(83380400001)(82950400001)(82960400001)(122000001)(33656002)(86362001)(38100700002)(41300700001)(110136005)(26005)(2906002)(44832011)(55016003)(8990500004)(5660300002)(66946007)(76116006)(66476007)(66556008)(4326008)(52536014)(8676002)(64756008)(66446008)(8936002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?utf-8?q?BOGk8CiUse/0mXPKVPqWLTXQjjGd?=\n\t=?utf-8?q?IMWm4y8VssAFBtVEWdf3b6PHbWjRmDheCjEVajngCqZnmUahDkO8SNDXQwRpwVc+g?=\n\t=?utf-8?q?32LKRiUC/GqyoAeEXquNBjZMAje/S0Ol6+9l/G1nIIFvu2l4RZ9seZG6XNI8wFm6b?=\n\t=?utf-8?q?Ow4u+KANf0TNIwyb//MVL/gyPN07CZOCVWNjkYMl4wa1UXhn/932Z+gL7uGBDf7DT?=\n\t=?utf-8?q?wEXhxsSh6a2ML7kOexiIC15e3sm5am3EeqrxlWK2yoywtp/9aVmtL5BavmSHIi15Q?=\n\t=?utf-8?q?P6iU4qvorldHqbaS+Iz3rg6OWpQNdRePZeGIUTQD53wn35pCnRe91IuCSH6aLZFQM?=\n\t=?utf-8?q?u6yLhclWSYzOm1G0xIJBsSsnTQHod4pGCDky49LF73xsSd/f5nJbFklybWm1eEK4H?=\n\t=?utf-8?q?aMAsScLCq83Dw5jj93Z0S/aNLOXZndNG8TjZtLD/Ao6xg5t77wYE0meWG6qyx59AR?=\n\t=?utf-8?q?OvmESVhyYUfdMgBH26lJxWa/DRdt549BJQRpq28aIZEUhJqkgVoHdjswsiVBu5oZp?=\n\t=?utf-8?q?ZW0SvFSj5yi5wOpSrWBTNXpHcZhXEf3TwfGHspcEwiKjXFisy0phd43tO881bs+H0?=\n\t=?utf-8?q?rSQ1nEG6LHxygDavhPUIR0p+t1hyy1S0c+wFsGVN5lqp0drCENVSYJ7RtkGUxrJ8m?=\n\t=?utf-8?q?R7d0UpiEt851IL+BLACCyXA/DRsNVEwnlRimcDOQ7olBnKL9GRACCBHXCJDITpgB9?=\n\t=?utf-8?q?3V14qkfE0x4nouWuWh2lG0h1V9UwaDy1FNJoBFQbqj9wEUvVl1+2fBg6gK4XYTfIc?=\n\t=?utf-8?q?eRr2Cu5++aWcfw2+U4MdsMsQYVtGJpp5dRNO4b1S+ytCWM1eW8NnG+8+dlN30BCtj?=\n\t=?utf-8?q?B897yFWqHKLYZvlLboKxDZDTE7YjIoo0cnyDNaT6CGaetCGLj4GpemxVlIimjuoio?=\n\t=?utf-8?q?q2ZOE3tJiglI6V33/stq+JteVPd8FU4I7ZKOgyoPnDTBUSrhEKNxPZQ14lBrzuka1?=\n\t=?utf-8?q?WSuTuL5qXEm8QIreuVLSmCmdnhUw5fiygADqkqkxxmR/idyUteHoS7qtlyAejzart?=\n\t=?utf-8?q?N8SCOI8f7jLZgA4cNrUMLRs0PUx0YC8D9Y/bEFG4uyRfzJcQIhwuDyE96fNlKVCqI?=\n\t=?utf-8?q?4uzgaWKWk7aQ/jDCMlIE4JlofPlmLHnejbYIG5ltn/bUxaeEJEo9rI8+hYts1GcS7?=\n\t=?utf-8?q?fll45XnvjtnELvTLMAK8mX6Tsa/ts1HVFuEES1uXgnFV8COkLA04XuSS/qrRCU8Qn?=\n\t=?utf-8?q?xMowMhO493KN1Y0GRM+jqXJ/MrZEBLCHxoWJvVfr1hdAjlD6Kky/PLVOTZemp3HX/?=\n\t=?utf-8?q?1Olp6u7vyhc5gZLGmLZNs5GzPHZ059iEyd0akPdJezLoGHBrjIao4/OTe8oYubeD3?=\n\t=?utf-8?q?HWFFQyZUsmcS+0WoF5yIhQqZkrsfPVhVKnW0zzN9Anq16gDUfGhYELpC+TzzkfyTP?=\n\t=?utf-8?q?N/KDxf8rTSVr/b845Gy0gIfNNOjgPTHNeSjGRRCZGNPcJX8uvPbPxnaSkOPQ2x1ui?=\n\t=?utf-8?q?UEJwFO2AKtke6?=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "microsoft.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "PA4PR83MB0526.EURPRD83.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9afebe47-ee74-4483-2163-08dc312d9350", "X-MS-Exchange-CrossTenant-originalarrivaltime": "19 Feb 2024 09:31:39.4271 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "72f988bf-86f1-41af-91ab-2d7cd011db47", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n bYuy58WiKF7FwVDQeuiYotsnwE1nnY7Fm9Ly/kLYgpY6ZLQfjBh9PEnc3noU78eH7r/oEsPz5dqa+YfUa6W8LA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DBAPR83MB0421", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The previous code incorrectly parsed the VLAN ID and priority.\nIf the 16-bits of VLAN ID and priority/CFI on the wire was\n0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There\nwere macros defined to handle this conversion but they were not\nused.\n\nFixes: 4e9c73e96e83 (\"net/netvsc: add Hyper-V network device\")\nCc: sthemmin@microsoft.com\nCc: stable@dpdk.org\n\nSigned-off-by: Alan Elder <alan.elder@microsoft.com>\n---\nv7:\n* Split into two patches, one for lib and one for driver\n\nv6:\n* Line length can be 100 - un-split lines\n\nv5:\n* Move the VLAN parsing macros to rte_ether.h\n\nv4:\n* Make consistent with FreeBSD code\n\n---\n drivers/net/netvsc/hn_rxtx.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)\n\n-- \n2.25.1", "diff": "diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\r\nindex e4f5015aa3..9bf1ec5509 100644\r\n--- a/drivers/net/netvsc/hn_rxtx.c\r\n+++ b/drivers/net/netvsc/hn_rxtx.c\r\n@@ -612,7 +612,9 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,\r\n \t\t\t\t\t RTE_PTYPE_L4_MASK);\r\n \r\n \tif (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) {\r\n-\t\tm->vlan_tci = info->vlan_info;\r\n+\t\tm->vlan_tci = RTE_VLAN_TCI_MAKE(NDIS_VLAN_INFO_ID(info->vlan_info),\r\n+\t\t\t\t\t\tNDIS_VLAN_INFO_PRI(info->vlan_info),\r\n+\t\t\t\t\t\tNDIS_VLAN_INFO_CFI(info->vlan_info));\r\n \t\tm->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED | RTE_MBUF_F_RX_VLAN;\r\n \r\n \t\t/* NDIS always strips tag, put it back if necessary */\r\n@@ -1332,7 +1334,9 @@ static void hn_encap(struct rndis_packet_msg *pkt,\r\n \tif (m->ol_flags & RTE_MBUF_F_TX_VLAN) {\r\n \t\tpi_data = hn_rndis_pktinfo_append(pkt, NDIS_VLAN_INFO_SIZE,\r\n \t\t\t\t\t\t NDIS_PKTINFO_TYPE_VLAN);\r\n-\t\t*pi_data = m->vlan_tci;\r\n+\t\t*pi_data = NDIS_VLAN_INFO_MAKE(RTE_VLAN_TCI_ID(m->vlan_tci),\r\n+\t\t\t\t\t RTE_VLAN_TCI_PRI(m->vlan_tci),\r\n+\t\t\t\t\t RTE_VLAN_TCI_DEI(m->vlan_tci));\r\n \t}\r\n \r\n \tif (m->ol_flags & RTE_MBUF_F_TX_TCP_SEG) {\r\n", "prefixes": [ "v7", "2/2" ] }