Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136982/?format=api
{ "id": 136982, "url": "http://patchwork.dpdk.org/api/patches/136982/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240221212044.27209-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240221212044.27209-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240221212044.27209-6-ajit.khaparde@broadcom.com", "date": "2024-02-21T21:20:40", "name": "[05/10] net/bnxt: fix a null pointer dereference", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d174301c1d730b6a6b4690281ba65cfa4c049ed3", "submitter": { "id": 501, "url": "http://patchwork.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240221212044.27209-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 31173, "url": "http://patchwork.dpdk.org/api/series/31173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31173", "date": "2024-02-21T21:20:35", "name": "patchset for bnxt", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31173/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/136982/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/136982/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D3E143B67;\n\tWed, 21 Feb 2024 22:21:43 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0D89940C35;\n\tWed, 21 Feb 2024 22:21:13 +0100 (CET)", "from mail-qt1-f182.google.com (mail-qt1-f182.google.com\n [209.85.160.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5029940A67\n for <dev@dpdk.org>; Wed, 21 Feb 2024 22:21:10 +0100 (CET)", "by mail-qt1-f182.google.com with SMTP id\n d75a77b69052e-42a9c21f9ecso35148401cf.0\n for <dev@dpdk.org>; Wed, 21 Feb 2024 13:21:10 -0800 (PST)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n 20-20020ac84e94000000b0042bff97d9a3sm4743467qtp.40.2024.02.21.13.21.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 21 Feb 2024 13:21:08 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1708550469; x=1709155269; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=pGelwZX894N5zKkxoAL62ocdSU97N1oXPKsMERWAB6s=;\n b=EDdAI8xFGNIjh9k1i90aTL/LwBxcRoXWwR/EcQx1tFgPuugw0nKt51dGi6i9J2Udyu\n TTe0ItCzQ0Kaht7qsAo1/y93na1beNZPSfQyDrYm7Cx43oJwJ9YJ7ke28zRC4dIHRDCE\n MLqTQMClzehUkFoPfHDNpsG2rJZmsUaj9j1Vs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1708550469; x=1709155269;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=pGelwZX894N5zKkxoAL62ocdSU97N1oXPKsMERWAB6s=;\n b=Max2DIhiDJI+QCj5i+A38x9862A+vQVsyra765WcysoDv4L+MiRgMeizSjJAJFbey0\n JlTa7TEgCKKqnX+uGM4AYlwk5q8LDXGPzlWpe93pLguDPW7DlHHKcEXUH4bkCNCSe32P\n svmkTMYOfWSiIIGMZJwZjPGSQbj6h1NGZKn4tlNjmPFdlpWxGneciY51osaWP5otpj4S\n njCh5hwC2MERDczFtRHWwKRQaf6NgrOuSFrTH7u16Tx75iVAu7uIdObl7zK4r7U7ntd1\n ZckzoyWa6buGhYz0g2WD5Jg73rvTN0Tl/eIgNF0srHjmyyIchbKYYi01fSZxDtEu2XGc\n EXtg==", "X-Gm-Message-State": "AOJu0Yxtk5Vhpryh/n9ARPfyPA7fJSM5ddzIPJB7C0IPbIvsaQmWdlF9\n 0emgbxent8ohjCnz15TguCAkWrN8Oy0tvE4pEwrzx/1AxRmGlOSSif+LvLbQeC+gMjd0LkvKsKf\n 3/tUg5qguswnfAnNUzgfLaNm3kMBovq4aXSkL49n61kqgthcJ1X68cDR/7hWFscbOdYK/v5QgfR\n PUo+r0Gma3/aKOmMioNmhWIHC06KVY", "X-Google-Smtp-Source": "\n AGHT+IF+nWf0cW02yBSu/TAbagCu7+lbsNKu7hIU8yrt9Biuq+Ccs9xMws5jqoFWBLK4ePVpKokdYw==", "X-Received": "by 2002:ac8:7f10:0:b0:42e:43f0:cffd with SMTP id\n f16-20020ac87f10000000b0042e43f0cffdmr1379217qtk.67.1708550469259;\n Wed, 21 Feb 2024 13:21:09 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@amd.com, thomas@monjalon.net,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, stable@dpdk.org,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Subject": "[PATCH 05/10] net/bnxt: fix a null pointer dereference", "Date": "Wed, 21 Feb 2024 13:20:40 -0800", "Message-Id": "<20240221212044.27209-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20240221212044.27209-1-ajit.khaparde@broadcom.com>", "References": "<20240221212044.27209-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000d379960611eae761\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nIn the recent changes to rte_eth_dev_release_port() the library sets\neth_dev->data to NULL at the end of the routine. This causes a NULL\npointer dereference in the bnxt_rep_dev_info_get_op() and\nbnxt_representor_uninit() routines when it tries to validate parent dev.\n\nAdd code to handle this.\n\nFixes: 6dc83230b43b (\"net/bnxt: support port representor data path\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_reps.c | 19 ++++++++++++++-----\n 1 file changed, 14 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 3a4720bc3c..edcc27f556 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -32,6 +32,14 @@ static const struct eth_dev_ops bnxt_rep_dev_ops = {\n \t.flow_ops_get = bnxt_flow_ops_get_op\n };\n \n+static bool bnxt_rep_check_parent(struct bnxt_representor *rep)\n+{\n+\tif (!rep->parent_dev->data->dev_private)\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n uint16_t\n bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf)\n {\n@@ -266,12 +274,12 @@ int bnxt_representor_uninit(struct rte_eth_dev *eth_dev)\n \tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d VFR uninit\\n\", eth_dev->data->port_id);\n \teth_dev->data->mac_addrs = NULL;\n \n-\tparent_bp = rep->parent_dev->data->dev_private;\n-\tif (!parent_bp) {\n+\tif (!bnxt_rep_check_parent(rep)) {\n \t\tPMD_DRV_LOG(DEBUG, \"BNXT Port:%d already freed\\n\",\n \t\t\t eth_dev->data->port_id);\n \t\treturn 0;\n \t}\n+\tparent_bp = rep->parent_dev->data->dev_private;\n \n \tparent_bp->num_reps--;\n \tvf_id = rep->vf_id;\n@@ -539,11 +547,12 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,\n \tint rc = 0;\n \n \t/* MAC Specifics */\n-\tparent_bp = rep_bp->parent_dev->data->dev_private;\n-\tif (!parent_bp) {\n-\t\tPMD_DRV_LOG(ERR, \"Rep parent NULL!\\n\");\n+\tif (!bnxt_rep_check_parent(rep_bp)) {\n+\t\t/* Need not be an error scenario, if parent is closed first */\n+\t\tPMD_DRV_LOG(INFO, \"Rep parent port does not exist.\\n\");\n \t\treturn rc;\n \t}\n+\tparent_bp = rep_bp->parent_dev->data->dev_private;\n \tPMD_DRV_LOG(DEBUG, \"Representor dev_info_get_op\\n\");\n \tdev_info->max_mac_addrs = parent_bp->max_l2_ctx;\n \tdev_info->max_hash_mac_addrs = 0;\n", "prefixes": [ "05/10" ] }